USB comm: prepare for @micolous change (PR#463) (#587)

[proxmark3-svn] / client / flasher.c

diff --git a/client/flasher.c b/client/flasher.c
index f257d994517b4c6a7a5675a83c5f4f13890cfac7..2bb87df9a96ea1ab5ab63a56a9e387a545f72272 100644 (file)
--- a/client/flasher.c
+++ b/client/flasher.c
@@ -23,9 +23,6 @@
 # include <unistd.h>
 #endif
 
 # include <unistd.h>
 #endif
 

-static serial_port sp;
-static char* serial_port_name;
-

 void cmd_debug(UsbCommand* UC) {
   //  Debug
   printf("UsbCommand length[len=%zd]\n",sizeof(UsbCommand));
 void cmd_debug(UsbCommand* UC) {
   //  Debug
   printf("UsbCommand length[len=%zd]\n",sizeof(UsbCommand));


@@ -43,15 +40,15 @@ void cmd_debug(UsbCommand* UC) {
 void SendCommand(UsbCommand* txcmd) {
 //  printf("send: ");
 //  cmd_debug(txcmd);
 void SendCommand(UsbCommand* txcmd) {
 //  printf("send: ");
 //  cmd_debug(txcmd);

-  if (!uart_send(sp,(byte_t*)txcmd,sizeof(UsbCommand))) {
+  if (!uart_send(sp,(uint8_t*)txcmd,sizeof(UsbCommand))) {

     printf("Sending bytes to proxmark failed\n");
     exit(1);
   }
 }
 
 void ReceiveCommand(UsbCommand* rxcmd) {
     printf("Sending bytes to proxmark failed\n");
     exit(1);
   }
 }
 
 void ReceiveCommand(UsbCommand* rxcmd) {

-  byte_t* prxcmd = (byte_t*)rxcmd;
-  byte_t* prx = prxcmd;
+  uint8_t* prxcmd = (uint8_t*)rxcmd;
+  uint8_t* prx = prxcmd;

   size_t rxlen;
   while (true) {
     if (uart_receive(sp, prx, sizeof(UsbCommand) - (prx-prxcmd), &rxlen)) {
   size_t rxlen;
   while (true) {
     if (uart_receive(sp, prx, sizeof(UsbCommand) - (prx-prxcmd), &rxlen)) {


@@ -63,32 +60,17 @@ void ReceiveCommand(UsbCommand* rxcmd) {
   }
 }
 
   }
 }
 

-void CloseProxmark() {
-  // Clean up the port
-  uart_close(sp);
-  // Fix for linux, it seems that it is extremely slow to release the serial port file descriptor /dev/*
-  unlink(serial_port_name);
-}
-
-int OpenProxmark(size_t i) {
-  sp = uart_open(serial_port_name);
-  if (sp == INVALID_SERIAL_PORT || sp == CLAIMED_SERIAL_PORT) {
-    //poll once a second
-    return 0;
-  }
-  return 1;
-}
-

 static void usage(char *argv0)
 {
        fprintf(stderr, "Usage:   %s <port> [-b] image.elf [image.elf...]\n\n", argv0);
        fprintf(stderr, "\t-b\tEnable flashing of bootloader area (DANGEROUS)\n\n");
 static void usage(char *argv0)
 {
        fprintf(stderr, "Usage:   %s <port> [-b] image.elf [image.elf...]\n\n", argv0);
        fprintf(stderr, "\t-b\tEnable flashing of bootloader area (DANGEROUS)\n\n");

-       //Is the example below really true? /Martin
-       fprintf(stderr, "Example:\n\n\t %s path/to/osimage.elf path/to/fpgaimage.elf\n", argv0);
-       fprintf(stderr, "\nExample (Linux):\n\n\t %s  /dev/ttyACM0 armsrc/obj/fullimage.elf\n", argv0);
-       fprintf(stderr, "\nNote (Linux): if the flasher gets stuck in 'Waiting for Proxmark to reappear on <DEVICE>',\n");
-       fprintf(stderr, "              you need to blacklist proxmark for modem-manager - see wiki for more details:\n");
-       fprintf(stderr, "              http://code.google.com/p/proxmark3/wiki/Linux\n\n");
+       fprintf(stderr, "\nExample:\n\n\t %s "SERIAL_PORT_H" armsrc/obj/fullimage.elf\n", argv0);
+#ifdef __linux__
+       fprintf(stderr, "\nNote (Linux): if the flasher gets stuck at 'Waiting for Proxmark to reappear',\n");
+       fprintf(stderr, "       you may need to blacklist proxmark for modem-manager. v1.4.14 and later\n");
+       fprintf(stderr, "       include this configuration patch already. The change can be found at:\n");
+       fprintf(stderr, "       https://cgit.freedesktop.org/ModemManager/ModemManager/commit/?id=6e7ff47\n\n");
+#endif

 }
 
 #define MAX_FILES 4
 }
 
 #define MAX_FILES 4


@@ -126,16 +108,16 @@ int main(int argc, char **argv)
                }
        }
 
                }
        }
 

-  serial_port_name = argv[1];
-  
-  fprintf(stderr,"Waiting for Proxmark to appear on %s",serial_port_name);
-  do {
-    msleep(1000);
-    fprintf(stderr, ".");
-  } while (!OpenProxmark(0));
-  fprintf(stderr," Found.\n");
+       char* serial_port_name = argv[1];
+
+       fprintf(stderr,"Waiting for Proxmark to appear on %s", serial_port_name);
+       do {
+               msleep(1000);
+               fprintf(stderr, ".");
+       } while (!OpenProxmark(0, serial_port_name));
+       fprintf(stderr," Found.\n");

 
 

-       res = flash_start_flashing(can_write_bl,serial_port_name);
+       res = flash_start_flashing(can_write_bl, serial_port_name);

        if (res < 0)
                return -1;
 
        if (res < 0)
                return -1;
 


@@ -155,7 +137,7 @@ int main(int argc, char **argv)
        if (res < 0)
                return -1;
 
        if (res < 0)
                return -1;
 

-       CloseProxmark();
+       CloseProxmark(serial_port_name);

 
        fprintf(stderr, "All done.\n\n");
        fprintf(stderr, "Have a nice day!\n");
 
        fprintf(stderr, "All done.\n\n");
        fprintf(stderr, "Have a nice day!\n");