some coverity fixes plus fix fdx help (#328)

[proxmark3-svn] / client / util.c

diff --git a/client/util.c b/client/util.c
index 0a92f15a00d3b56e879453f0c461a4e80f1b6566..38dd3a12f450e245cdc35d9f7d23dcd17b6685d0 100644 (file)
--- a/client/util.c
+++ b/client/util.c
@@ -193,13 +193,14 @@ char *sprint_hex_ascii(const uint8_t *data, const size_t len) {
        static char buf[1024];
        char *tmp = buf;
        memset(buf, 0x00, 1024);
-       size_t max_len = (len > 1010) ? 1010 : len;
-
+       size_t max_len = (len > 255) ? 255 : len;
+       // max 255 bytes * 3 + 2 characters = 767 in buffer
        sprintf(tmp, "%s| ", sprint_hex(data, max_len) );
        
        size_t i = 0;
        size_t pos = (max_len * 3)+2;
-       while(i < max_len){
+       // add another 255 characters ascii = 1020 characters of buffer used
+       while(i < max_len) {
                char c = data[i];
                if ( (c < 32) || (c == 127))
                        c = '.';