fix gcc8 compiler warnings on string overflows (#905)

[proxmark3-svn] / client / cmdhf14b.c

diff --git a/client/cmdhf14b.c b/client/cmdhf14b.c
index 8a83df8f76f98a3ee6776acaa68f27a8d0244061..0c6ff4b37c826b47a17f0fc9d416794ce71d3490 100644 (file)
--- a/client/cmdhf14b.c
+++ b/client/cmdhf14b.c
@@ -108,9 +108,21 @@ int HF14BCmdRaw(bool reply, bool *crc, bool power, uint8_t *data, uint8_t *datal
                if (verbose) PrintAndLog("timeout while waiting for reply.");
                return 0;
        }
-       *datalen = resp.arg[0];
-       if (verbose) PrintAndLog("received %u octets", *datalen);
-       if (*datalen < 2) return 0;
+
+       int ret = resp.arg[0];
+       if (verbose) {
+               if (ret < 0) {
+                       PrintAndLog("tag didn't respond");
+               } else if (ret == 0) {
+                       PrintAndLog("received SOF only (maybe iCLASS/Picopass)");
+               } else {
+                       PrintAndLog("received %u octets", ret);
+               }
+       }
+
+       *datalen = ret;
+       
+       if (ret < 2) return 0;
 
        memcpy(data, resp.d.asBytes, *datalen);
        if (verbose) PrintAndLog("%s", sprint_hex(data, *datalen));
@@ -139,7 +151,7 @@ static int CmdHF14BCmdRaw (const char *Cmd) {
        uint8_t datalen = 0;
        unsigned int temp;
        int i = 0;
-       if (strlen(Cmd) < 3) {
+       if (strlen(Cmd) < 2) {
                        PrintAndLog("Usage: hf 14b raw [-r] [-c] [-p] [-s || -ss] <0A 0B 0C ... hex>");
                        PrintAndLog("       -r    do not read response");
                        PrintAndLog("       -c    calculate and append CRC");
@@ -225,8 +237,11 @@ static int CmdHF14BCmdRaw (const char *Cmd) {
 
                if (HF14BCmdRaw(true, &crc2, true, cmd2, &cmdLen, false) == 0) return switch_off_field_14b();
 
-               if (SRx && (cmdLen != 3 || !crc2) ) return switch_off_field_14b();
-               else if (cmd2[0] != 0x50 || cmdLen != 14 || !crc2) return switch_off_field_14b();
+               if (SRx) {
+                       if (cmdLen != 3 || !crc2) return switch_off_field_14b();
+               } else {
+                       if (cmd2[0] != 0x50 || cmdLen != 14 || !crc2) return switch_off_field_14b();
+               }
 
                uint8_t chipID = 0;
                if (SRx) {
@@ -251,7 +266,9 @@ static int CmdHF14BCmdRaw (const char *Cmd) {
                if (cmdLen != 3 || !crc2) return switch_off_field_14b();
                if (SRx && cmd2[0] != chipID) return switch_off_field_14b();
        }
+
        return HF14BCmdRaw(reply, &crc, power, data, &datalen, true);
+
 }
 
 
@@ -662,7 +679,6 @@ int CmdSriWrite(const char *Cmd) {
        uint8_t blockno = -1;
        uint8_t data[4] = {0x00};
        bool isSrix4k = true;
-       char str[20];
 
        if (strlen(Cmd) < 1 || cmdp == 'h' || cmdp == 'H') {
                PrintAndLog("Usage:  hf 14b write <1|2> <BLOCK> <DATA>");
@@ -708,7 +724,8 @@ int CmdSriWrite(const char *Cmd) {
        else
                PrintAndLog("[%s] Write block %02X [ %s ]", (isSrix4k)?"SRIX4K":"SRI512", blockno, sprint_hex(data, 4));
 
-       sprintf(str, "-c 09 %02x %02x%02x%02x%02x", blockno, data[0], data[1], data[2], data[3]);
+       char str[22];
+       sprintf(str, "-ss -c 09 %02x %02x%02x%02x%02x", blockno, data[0], data[1], data[2], data[3]);
 
        CmdHF14BCmdRaw(str);
        return 0;