avoid vast number of warnings with clang compiler

[proxmark3-svn] / common / lfdemod.c

diff --git a/common/lfdemod.c b/common/lfdemod.c
index 49838f5e2be22e694015a181a0e36438c74b4561..f81ac236ca4e6d1b37f79635ca82bbf10b67b357 100644 (file)
--- a/common/lfdemod.c
+++ b/common/lfdemod.c
@@ -548,7 +548,7 @@ int DetectNRZClock(uint8_t dest[], size_t size, int clock, size_t *clockStartIdx
 
        //get high and low peak
        int peak, low;
-       if (getHiLo(dest, loopCnt, &peak, &low, 85, 85) < 1) return 0;
+       if (getHiLo(dest, loopCnt, &peak, &low, 90, 90) < 1) return 0;
 
        int lowestTransition = DetectStrongNRZClk(dest, size-20, peak, low);
        size_t ii;
@@ -751,8 +751,8 @@ int DetectPSKClock(uint8_t dest[], size_t size, int clock, size_t *firstPhaseShi
        uint16_t fcs = countFC(dest, size, 0);
        *fc = fcs & 0xFF;
        if (g_debugMode==2) prnt("DEBUG PSK: FC: %d, FC2: %d",*fc, fcs>>8);
-       if ((fcs>>8) == 10 && *fc == 8) return -1;
-       if (*fc!=2 && *fc!=4 && *fc!=8) return -1;
+       if ((fcs>>8) == 10 && *fc == 8) return 0;
+       if (*fc!=2 && *fc!=4 && *fc!=8) return 0;
 
        //if we already have a valid clock quit
        size_t i=1;
@@ -958,6 +958,8 @@ uint8_t     detectFSKClk(uint8_t *BitStream, size_t size, uint8_t fcHigh, uint8_t fc
 
 // look for Sequence Terminator - should be pulses of clk*(1 or 2), clk*2, clk*(1.5 or 2), by idx we mean graph position index...
 bool findST(int *stStopLoc, int *stStartIdx, int lowToLowWaveLen[], int highToLowWaveLen[], int clk, int tol, int buffSize, size_t *i) {
+       if (buffSize < *i+4) return false;
+
        for (; *i < buffSize - 4; *i+=1) {
                *stStartIdx += lowToLowWaveLen[*i]; //caution part of this wave may be data and part may be ST....  to be accounted for in main function for now...
                if (lowToLowWaveLen[*i] >= clk*1-tol && lowToLowWaveLen[*i] <= (clk*2)+tol && highToLowWaveLen[*i] < clk+tol) {           //1 to 2 clocks depending on 2 bits prior
@@ -1559,7 +1561,7 @@ int pskRawDemod_ext(uint8_t dest[], size_t *size, int *clock, int *invert, int *
        uint16_t errCnt=0, errCnt2=0;
        
        *clock = DetectPSKClock(dest, *size, *clock, &firstFullWave, &curPhase, &fc);
-       if (*clock == 0) return -1;
+       if (*clock <= 0) return -1;
        //if clock detect found firstfullwave...
        uint16_t tol = fc/2;
        if (firstFullWave == 0) {