minor fixes

[proxmark3-svn] / client / util.c

diff --git a/client/util.c b/client/util.c
index 38dd3a12f450e245cdc35d9f7d23dcd17b6685d0..a1caafdbf9ec925561e905aa306785a5c453690d 100644 (file)
--- a/client/util.c
+++ b/client/util.c
@@ -322,7 +322,7 @@ char * printBits(size_t const size, void const * const ptr)
 
 //  -------------------------------------------------------------------------
 //  line     - param line
-//  bg, en   - symbol numbers in param line of beginning an ending parameter
+//  bg, en   - symbol numbers in param line of beginning and ending parameter
 //  paramnum - param number (from 0)
 //  -------------------------------------------------------------------------
 int param_getptr(const char *line, int *bg, int *en, int paramnum)
@@ -355,13 +355,28 @@ int param_getptr(const char *line, int *bg, int *en, int paramnum)
 }
 
 
-char param_getchar(const char *line, int paramnum)
+int param_getlength(const char *line, int paramnum)
 {
        int bg, en;
        
+       if (param_getptr(line, &bg, &en, paramnum)) return 0;
+
+       return en - bg + 1;
+}
+
+char param_getchar(const char *line, int paramnum) {
+       return param_getchar_indx(line, 0, paramnum);
+}
+
+char param_getchar_indx(const char *line, int indx, int paramnum) {
+       int bg, en;
+       
        if (param_getptr(line, &bg, &en, paramnum)) return 0x00;
 
-       return line[bg];
+       if (bg + indx > en)
+               return '\0';
+       
+       return line[bg + indx];
 }
 
 uint8_t param_get8(const char *line, int paramnum)
@@ -471,11 +486,64 @@ int param_gethex_ex(const char *line, int paramnum, uint8_t * data, int *hexcnt)
 
        return 0;
 }
-int param_getstr(const char *line, int paramnum, char * str)
+
+int param_gethex_to_eol(const char *line, int paramnum, uint8_t * data, int maxdatalen, int *datalen) {
+       int bg, en;
+       uint32_t temp;
+       char buf[5] = {0};
+
+       if (param_getptr(line, &bg, &en, paramnum)) return 1;
+
+       *datalen = 0;
+       
+       int indx = bg;
+       while (line[indx]) {
+               if (line[indx] == '\t' || line[indx] == ' ') 
+                       continue;
+               
+               if (isxdigit(line[indx])) {
+                       buf[strlen(buf) + 1] = 0x00;
+                       buf[strlen(buf)] = line[indx];
+               } else {
+                       // if we have symbols other than spaces and hex
+                       return 1;
+               }                               
+
+               if (*datalen >= maxdatalen) {
+                       // if we dont have space in buffer and have symbols to translate
+                       return 2;
+               }
+
+               if (strlen(buf) >= 2) {
+                       sscanf(buf, "%x", &temp);
+                       data[*datalen] = (uint8_t)(temp & 0xff);
+                       *buf = 0;
+                       (*datalen)++;
+               }
+               
+               indx++;
+       }
+
+       if (strlen(buf) > 0) 
+               //error when not completed hex bytes
+               return 3;
+               
+       return 0;
+}
+
+int param_getstr(const char *line, int paramnum, char * str, size_t buffersize)
 {
        int bg, en;
 
-       if (param_getptr(line, &bg, &en, paramnum)) return 0;
+       if (param_getptr(line, &bg, &en, paramnum)) {   
+               return 0;
+       }
+
+       // Prevent out of bounds errors
+       if (en - bg + 1 >= buffersize) {
+               printf("out of bounds error: want %d bytes have %zd bytes\n", en - bg + 1 + 1, buffersize);
+               return 0;
+       }
        
        memcpy(str, line + bg, en - bg + 1);
        str[en - bg + 1] = 0;
@@ -493,6 +561,7 @@ https://github.com/ApertureLabsLtd/RFIDler/blob/master/firmware/Pic32/RFIDler.X/
 int hextobinarray(char *target, char *source)
 {
     int length, i, count= 0;
+    char* start = source;
     char x;
 
     length = strlen(source);
@@ -508,8 +577,10 @@ int hextobinarray(char *target, char *source)
             x -= '0';
         else if (x >= 'A' && x <= 'F')
             x -= 'A' - 10;
-        else
+        else {
+               printf("Discovered unknown character %c %d at idx %d of %s\n", x, x, source - start, start);
             return 0;
+        }
         // output
         for(i= 0 ; i < 4 ; ++i, ++count)
             *(target++)= (x >> (3 - i)) & 1;
@@ -614,7 +685,28 @@ void clean_ascii(unsigned char *buf, size_t len) {
   }
 }
 
+// replace \r \n to \0
+void strcleanrn(char *buf, size_t len) {
+       strcreplace(buf, len, '\n', '\0');
+       strcreplace(buf, len, '\r', '\0');
+}
 
+// replace char in buffer
+void strcreplace(char *buf, size_t len, char from, char to) {
+  for (size_t i = 0; i < len; i++) {
+    if (buf[i] == from)
+      buf[i] = to;
+  }
+}
+
+char *strmcopy(char *buf) {
+       char * str = NULL;
+       if ((str = (char*) malloc(strlen(buf) + 1)) != NULL) {
+               memset(str, 0, strlen(buf) + 1);
+               strcpy(str, buf);
+       }       
+       return str;
+}
 
 
 // determine number of logical CPU cores (use for multithreaded functions)