FIX: ELOAD/ESAVE/CLOAD/CSAVE filename bufferoverflow, and filename generation if...

[proxmark3-svn] / armsrc / mifarecmd.c

diff --git a/armsrc/mifarecmd.c b/armsrc/mifarecmd.c
index 03e15b3b52e9ce8d29bd38bb33c87ad598b9d011..47c7fc127a4358b5f3c8df43c98e22b466570199 100644 (file)
--- a/armsrc/mifarecmd.c
+++ b/armsrc/mifarecmd.c
@@ -86,7 +86,6 @@ void MifareReadBlock(uint8_t arg0, uint8_t arg1, uint8_t arg2, uint8_t *datain)
        LEDsoff();\r
 }\r
 \r
        LEDsoff();\r
 }\r
 \r

-\r

 void MifareUC_Auth(uint8_t arg0, uint8_t *keybytes){\r
 \r
        bool turnOffField = (arg0 == 1);\r
 void MifareUC_Auth(uint8_t arg0, uint8_t *keybytes){\r
 \r
        bool turnOffField = (arg0 == 1);\r


@@ -106,17 +105,17 @@ void MifareUC_Auth(uint8_t arg0, uint8_t *keybytes){
                OnError(1);\r
                return;\r
        }\r
                OnError(1);\r
                return;\r
        }\r

-    \r
+\r

        if (turnOffField) {\r
                FpgaWriteConfWord(FPGA_MAJOR_MODE_OFF);\r
                LEDsoff();\r
        if (turnOffField) {\r
                FpgaWriteConfWord(FPGA_MAJOR_MODE_OFF);\r
                LEDsoff();\r

-       }       \r
+       }\r

        cmd_send(CMD_ACK,1,0,0,0,0);\r
 }\r
 \r
 // Arg0 = BlockNo,\r
 // Arg1 = UsePwd bool\r
        cmd_send(CMD_ACK,1,0,0,0,0);\r
 }\r
 \r
 // Arg0 = BlockNo,\r
 // Arg1 = UsePwd bool\r

-// datain = PWD bytes,  \r
+// datain = PWD bytes,\r

 void MifareUReadBlock(uint8_t arg0, uint8_t arg1, uint8_t *datain)\r
 {\r
        uint8_t blockNo = arg0;\r
 void MifareUReadBlock(uint8_t arg0, uint8_t arg1, uint8_t *datain)\r
 {\r
        uint8_t blockNo = arg0;\r


@@ -124,52 +123,52 @@ void MifareUReadBlock(uint8_t arg0, uint8_t arg1, uint8_t *datain)
        bool useKey = (arg1 == 1); //UL_C\r
        bool usePwd = (arg1 == 2); //UL_EV1/NTAG\r
 \r
        bool useKey = (arg1 == 1); //UL_C\r
        bool usePwd = (arg1 == 2); //UL_EV1/NTAG\r
 \r

-       LEDsoff();      \r
-       LED_A_ON();    \r
+       LEDsoff();\r
+       LED_A_ON();\r

        clear_trace();\r
        iso14443a_setup(FPGA_HF_ISO14443A_READER_LISTEN);\r
        clear_trace();\r
        iso14443a_setup(FPGA_HF_ISO14443A_READER_LISTEN);\r

-    \r
+\r

        int len = iso14443a_select_card(NULL, NULL, NULL);\r
        if(!len) {\r
                if (MF_DBGLEVEL >= MF_DBG_ERROR) Dbprintf("Can't select card (RC:%02X)",len);\r
                OnError(1);\r
                return;\r
        }\r
        int len = iso14443a_select_card(NULL, NULL, NULL);\r
        if(!len) {\r
                if (MF_DBGLEVEL >= MF_DBG_ERROR) Dbprintf("Can't select card (RC:%02X)",len);\r
                OnError(1);\r
                return;\r
        }\r

-       \r
+\r

        // UL-C authentication\r
        if ( useKey ) {\r
        // UL-C authentication\r
        if ( useKey ) {\r

-               uint8_t key[16] = {0x00};       \r
+               uint8_t key[16] = {0x00};\r

                memcpy(key, datain, sizeof(key) );\r
 \r
                if ( !mifare_ultra_auth(key) ) {\r
                        OnError(1);\r
                memcpy(key, datain, sizeof(key) );\r
 \r
                if ( !mifare_ultra_auth(key) ) {\r
                        OnError(1);\r

-                       return;                 \r
+                       return;\r

                }\r
        }\r
                }\r
        }\r

-       \r
+\r

        // UL-EV1 / NTAG authentication\r
        // UL-EV1 / NTAG authentication\r

-       if (usePwd) { \r
+       if ( usePwd ) {\r

                uint8_t pwd[4] = {0x00};\r
                memcpy(pwd, datain, 4);\r
                uint8_t pack[4] = {0,0,0,0};\r
                if (!mifare_ul_ev1_auth(pwd, pack)) {\r
                        OnError(1);\r
                uint8_t pwd[4] = {0x00};\r
                memcpy(pwd, datain, 4);\r
                uint8_t pack[4] = {0,0,0,0};\r
                if (!mifare_ul_ev1_auth(pwd, pack)) {\r
                        OnError(1);\r

-                       return;                 \r
+                       return;\r

                }\r
                }\r

-       }\r
-               \r
+       }       \r
+\r

        if( mifare_ultra_readblock(blockNo, dataout) ) {\r
                if (MF_DBGLEVEL >= MF_DBG_ERROR) Dbprintf("Read block error");\r
                OnError(2);\r
                return;\r
        }\r
        if( mifare_ultra_readblock(blockNo, dataout) ) {\r
                if (MF_DBGLEVEL >= MF_DBG_ERROR) Dbprintf("Read block error");\r
                OnError(2);\r
                return;\r
        }\r

-        \r
+\r

        if( mifare_ultra_halt() ) {\r
                if (MF_DBGLEVEL >= MF_DBG_ERROR) Dbprintf("Halt error");\r
                OnError(3);\r
                return;\r
        }\r
        if( mifare_ultra_halt() ) {\r
                if (MF_DBGLEVEL >= MF_DBG_ERROR) Dbprintf("Halt error");\r
                OnError(3);\r
                return;\r
        }\r

-               \r
+\r

     cmd_send(CMD_ACK,1,0,0,dataout,16);\r
        FpgaWriteConfWord(FPGA_MAJOR_MODE_OFF);\r
        LEDsoff();\r
     cmd_send(CMD_ACK,1,0,0,dataout,16);\r
        FpgaWriteConfWord(FPGA_MAJOR_MODE_OFF);\r
        LEDsoff();\r


@@ -251,7 +250,6 @@ void MifareUReadCard(uint8_t arg0, uint16_t arg1, uint8_t arg2, uint8_t *datain)
 {\r
        // free eventually allocated BigBuf memory\r
        BigBuf_free();\r
 {\r
        // free eventually allocated BigBuf memory\r
        BigBuf_free();\r

-       // clear trace\r

        clear_trace();\r
 \r
        // params\r
        clear_trace();\r
 \r
        // params\r


@@ -268,7 +266,7 @@ void MifareUReadCard(uint8_t arg0, uint16_t arg1, uint8_t arg2, uint8_t *datain)
        }\r
 \r
        LEDsoff();\r
        }\r
 \r
        LEDsoff();\r

-       LED_A_ON(); \r
+       LED_A_ON();\r

        iso14443a_setup(FPGA_HF_ISO14443A_READER_LISTEN);\r
 \r
        int len = iso14443a_select_card(NULL, NULL, NULL);\r
        iso14443a_setup(FPGA_HF_ISO14443A_READER_LISTEN);\r
 \r
        int len = iso14443a_select_card(NULL, NULL, NULL);\r


@@ -277,20 +275,20 @@ void MifareUReadCard(uint8_t arg0, uint16_t arg1, uint8_t arg2, uint8_t *datain)
                OnError(1);\r
                return;\r
        }\r
                OnError(1);\r
                return;\r
        }\r

-       \r
-        // UL-C authentication\r
+\r
+       // UL-C authentication\r

        if ( useKey ) {\r
        if ( useKey ) {\r

-               uint8_t key[16] = {0x00};       \r
+               uint8_t key[16] = {0x00};\r

                memcpy(key, datain, sizeof(key) );\r
 \r
                if ( !mifare_ultra_auth(key) ) {\r
                        OnError(1);\r
                memcpy(key, datain, sizeof(key) );\r
 \r
                if ( !mifare_ultra_auth(key) ) {\r
                        OnError(1);\r

-                       return;                 \r
+                       return;\r

                }\r
        }\r
 \r
        // UL-EV1 / NTAG authentication\r
                }\r
        }\r
 \r
        // UL-EV1 / NTAG authentication\r

-       if (usePwd) { \r
+       if (usePwd) {\r

                uint8_t pwd[4] = {0x00};\r
                memcpy(pwd, datain, sizeof(pwd));\r
                uint8_t pack[4] = {0,0,0,0};\r
                uint8_t pwd[4] = {0x00};\r
                memcpy(pwd, datain, sizeof(pwd));\r
                uint8_t pack[4] = {0,0,0,0};\r


@@ -300,20 +298,20 @@ void MifareUReadCard(uint8_t arg0, uint16_t arg1, uint8_t arg2, uint8_t *datain)
                        return;                 \r
                }\r
        }\r
                        return;                 \r
                }\r
        }\r

-       \r
+\r

        for (int i = 0; i < blocks; i++){\r
                if ((i*4) + 4 > CARD_MEMORY_SIZE) {\r
                        Dbprintf("Data exceeds buffer!!");\r
                        break;\r
                }\r
        for (int i = 0; i < blocks; i++){\r
                if ((i*4) + 4 > CARD_MEMORY_SIZE) {\r
                        Dbprintf("Data exceeds buffer!!");\r
                        break;\r
                }\r

-       \r
+\r

                len = mifare_ultra_readblock(blockNo + i, dataout + 4 * i);\r
                \r
                if (len) {\r
                        if (MF_DBGLEVEL >= MF_DBG_ERROR) Dbprintf("Read block %d error",i);\r
                        // if no blocks read - error out\r
                        if (i==0){\r
                len = mifare_ultra_readblock(blockNo + i, dataout + 4 * i);\r
                \r
                if (len) {\r
                        if (MF_DBGLEVEL >= MF_DBG_ERROR) Dbprintf("Read block %d error",i);\r
                        // if no blocks read - error out\r
                        if (i==0){\r

-                       OnError(2);\r
+                               OnError(2);\r

                        return;\r
                        } else {\r
                                //stop at last successful read block and return what we got\r
                        return;\r
                        } else {\r
                                //stop at last successful read block and return what we got\r


@@ -323,14 +321,14 @@ void MifareUReadCard(uint8_t arg0, uint16_t arg1, uint8_t arg2, uint8_t *datain)
                        countblocks++;\r
                }\r
        }\r
                        countblocks++;\r
                }\r
        }\r

-               \r
+\r

        len = mifare_ultra_halt();\r
        if (len) {\r
                if (MF_DBGLEVEL >= MF_DBG_ERROR) Dbprintf("Halt error");\r
                OnError(3);\r
                return;\r
        }\r
        len = mifare_ultra_halt();\r
        if (len) {\r
                if (MF_DBGLEVEL >= MF_DBG_ERROR) Dbprintf("Halt error");\r
                OnError(3);\r
                return;\r
        }\r

-       \r
+\r

        if (MF_DBGLEVEL >= MF_DBG_EXTENDED) Dbprintf("Blocks read %d", countblocks);\r
 \r
        countblocks *= 4;\r
        if (MF_DBGLEVEL >= MF_DBG_EXTENDED) Dbprintf("Blocks read %d", countblocks);\r
 \r
        countblocks *= 4;\r


@@ -413,15 +411,15 @@ void MifareWriteBlock(uint8_t arg0, uint8_t arg1, uint8_t arg2, uint8_t *datain)
 \r
 void MifareUWriteBlock(uint8_t arg0, uint8_t *datain)\r
 {\r
 \r
 void MifareUWriteBlock(uint8_t arg0, uint8_t *datain)\r
 {\r

-    uint8_t blockNo = arg0;\r
+       uint8_t blockNo = arg0;\r

        byte_t blockdata[16] = {0x00};\r
 \r
        byte_t blockdata[16] = {0x00};\r
 \r

-    memcpy(blockdata, datain, 16);\r
-        \r
+       memcpy(blockdata, datain, 16);\r
+\r

        uint8_t uid[10] = {0x00};\r
 \r
        LED_A_ON(); LED_B_OFF(); LED_C_OFF();\r
        uint8_t uid[10] = {0x00};\r
 \r
        LED_A_ON(); LED_B_OFF(); LED_C_OFF();\r

-               \r
+\r

        clear_trace();\r
        iso14443a_setup(FPGA_HF_ISO14443A_READER_LISTEN);\r
 \r
        clear_trace();\r
        iso14443a_setup(FPGA_HF_ISO14443A_READER_LISTEN);\r
 \r


@@ -441,7 +439,7 @@ void MifareUWriteBlock(uint8_t arg0, uint8_t *datain)
                OnError(0);\r
                return;\r
        };\r
                OnError(0);\r
                return;\r
        };\r

-               \r
+\r

        if (MF_DBGLEVEL >= 2)   DbpString("WRITE BLOCK FINISHED");\r
 \r
        cmd_send(CMD_ACK,1,0,0,0,0);\r
        if (MF_DBGLEVEL >= 2)   DbpString("WRITE BLOCK FINISHED");\r
 \r
        cmd_send(CMD_ACK,1,0,0,0,0);\r


@@ -461,8 +459,8 @@ void MifareUWriteBlock_Special(uint8_t arg0, uint8_t arg1, uint8_t *datain)
        bool useKey = (arg1 == 1); //UL_C\r
        bool usePwd = (arg1 == 2); //UL_EV1/NTAG\r
        byte_t blockdata[4] = {0x00};\r
        bool useKey = (arg1 == 1); //UL_C\r
        bool usePwd = (arg1 == 2); //UL_EV1/NTAG\r
        byte_t blockdata[4] = {0x00};\r

-       \r
-       memcpy(blockdata, datain, 4);\r
+\r
+       memcpy(blockdata, datain,4);\r

        \r
        LEDsoff();\r
        LED_A_ON();\r
        \r
        LEDsoff();\r
        LED_A_ON();\r


@@ -1337,4 +1335,4 @@ void Mifare_DES_Auth2(uint32_t arg0, uint8_t *datain){
        cmd_send(CMD_ACK, isOK, 0, 0, dataout, sizeof(dataout));\r
        FpgaWriteConfWord(FPGA_MAJOR_MODE_OFF);\r
        LEDsoff();\r
        cmd_send(CMD_ACK, isOK, 0, 0, dataout, sizeof(dataout));\r
        FpgaWriteConfWord(FPGA_MAJOR_MODE_OFF);\r
        LEDsoff();\r

-}\r
+}
\ No newline at end of file