Fix typo and gcc-7 warnings (#401)

* Fix typo in hf mf csave help
* Fix gcc 7 warning: '~' on an expression of type bool [-Wbool-operation], use logical ! not instead of ~
* Fix gcc 7 warning: ‘memset’ used with length equal to number of elements without multiplication by element size [-Wmemset-elt-size]
* Fix gcc 7 warning: warning: duplicate ‘const’ declaration specifier [-Wduplicate-decl-specifier]

diff --git a/client/cmdhfmf.c b/client/cmdhfmf.c
index 5999d20e7022376a5d247151b93dcf2863d63b64..aafbce2afa12990873e7422daf4fc65f56ebc073 100644 (file)
--- a/client/cmdhfmf.c
+++ b/client/cmdhfmf.c
@@ -2193,13 +2193,13 @@ int CmdHF14AMfCSave(const char *Cmd) {
        if (param_getchar(Cmd, 0) == 'h') {\r
                PrintAndLog("It saves `magic Chinese` card dump into the file `filename.eml` or `cardID.eml`");\r
                PrintAndLog("or into emulator memory (option `e`). 4K card: (option `4`)");\r
        if (param_getchar(Cmd, 0) == 'h') {\r
                PrintAndLog("It saves `magic Chinese` card dump into the file `filename.eml` or `cardID.eml`");\r
                PrintAndLog("or into emulator memory (option `e`). 4K card: (option `4`)");\r

-               PrintAndLog("Usage:  hf mf esave [file name w/o `.eml`][e][4]");\r
-               PrintAndLog("Sample: hf mf esave ");\r
-               PrintAndLog("        hf mf esave filename");\r
-               PrintAndLog("        hf mf esave e");\r
-               PrintAndLog("        hf mf esave 4");\r
-               PrintAndLog("        hf mf esave filename 4");\r
-               PrintAndLog("        hf mf esave e 4");\r
+               PrintAndLog("Usage:  hf mf csave [file name w/o `.eml`][e][4]");\r
+               PrintAndLog("Sample: hf mf csave ");\r
+               PrintAndLog("        hf mf csave filename");\r
+               PrintAndLog("        hf mf csave e");\r
+               PrintAndLog("        hf mf csave 4");\r
+               PrintAndLog("        hf mf csave filename 4");\r
+               PrintAndLog("        hf mf csave e 4");\r

                return 0;\r
        }\r
 \r
                return 0;\r
        }\r
 \r

diff --git a/client/cmdlfem4x.c b/client/cmdlfem4x.c
index 013c2f3fb427be478c318ff365b44d9e4f45692f..f5dfee35556134133479f0bb49328db686a983de 100644 (file)
--- a/client/cmdlfem4x.c
+++ b/client/cmdlfem4x.c
@@ -606,7 +606,7 @@ int EM4x50Read(const char *Cmd, bool verbose)
        char tmp2[20];
        int phaseoff;
        high = low = 0;
        char tmp2[20];
        int phaseoff;
        high = low = 0;

-       memset(tmpbuff, 0, MAX_GRAPH_TRACE_LEN / 64);
+       memset(tmpbuff, 0, sizeof(tmpbuff));

 
        // get user entry if any
        sscanf(Cmd, "%i %i", &clk, &invert);
 
        // get user entry if any
        sscanf(Cmd, "%i %i", &clk, &invert);

diff --git a/client/hardnested/hardnested_bf_core.c b/client/hardnested/hardnested_bf_core.c
index 5e81c2ba80c157ffac8492426d4040133c2c0a43..3c0c044ff5b7932ffb0418502abe0d16634f153b 100644 (file)
--- a/client/hardnested/hardnested_bf_core.c
+++ b/client/hardnested/hardnested_bf_core.c
@@ -342,7 +342,7 @@ const uint64_t CRACK_STATES_BITSLICED(uint32_t cuid, uint8_t *best_first_bytes,
                        // }
 #endif
             // add the even state bits
                        // }
 #endif
             // add the even state bits

-                       const bitslice_t const *restrict bitsliced_even_state = bitsliced_even_states[block_idx];
+                       const bitslice_t *restrict bitsliced_even_state = bitsliced_even_states[block_idx];

                        for(uint32_t state_idx = 1; state_idx < STATE_SIZE; state_idx += 2) {
                                state_p[state_idx] = bitsliced_even_state[state_idx/2];
                        }
                        for(uint32_t state_idx = 1; state_idx < STATE_SIZE; state_idx += 2) {
                                state_p[state_idx] = bitsliced_even_state[state_idx/2];
                        }

diff --git a/client/loclass/cipher.c b/client/loclass/cipher.c
index a701da31934164630e4df7f80605149a449c3dbd..57bc831fe1f97dda82c3c8fa9a940f77721ec0ea 100644 (file)
--- a/client/loclass/cipher.c
+++ b/client/loclass/cipher.c
@@ -114,9 +114,9 @@ uint8_t _select(bool x, bool y, uint8_t r)
        bool r6 = r >> 1 & 0x1;
        bool r7 = r & 0x1;
 
        bool r6 = r >> 1 & 0x1;
        bool r7 = r & 0x1;
 

-       bool z0 = (r0 & r2) ^ (r1 & ~r3) ^ (r2 | r4);
+       bool z0 = (r0 & r2) ^ (r1 & !r3) ^ (r2 | r4);

        bool z1 = (r0 | r2) ^ ( r5 | r7) ^ r1 ^ r6 ^ x ^ y;
        bool z1 = (r0 | r2) ^ ( r5 | r7) ^ r1 ^ r6 ^ x ^ y;

-       bool z2 = (r3 & ~r5) ^ (r4 & r6 ) ^ r7 ^ x;
+       bool z2 = (r3 & !r5) ^ (r4 & r6 ) ^ r7 ^ x;

 
        // The three bitz z0.. z1 are packed into a uint8_t:
        // 00000ZZZ
 
        // The three bitz z0.. z1 are packed into a uint8_t:
        // 00000ZZZ