From: marshmellow42 <marshmellowrf@gmail.com>
Date: Sun, 14 Feb 2016 18:41:25 +0000 (-0500)
Subject: resource leak and malloc(x) cannot be negative
X-Git-Tag: v2.3.0~7^2~5
X-Git-Url: http://git.zerfleddert.de/cgi-bin/gitweb.cgi/proxmark3-svn/commitdiff_plain/d23411ef619c87b488fddff87cff3c1ffde1ac12

resource leak and malloc(x) cannot be negative

thanks iceman1001
---

diff --git a/client/loclass/elite_crack.c b/client/loclass/elite_crack.c
index c824eaa1..5dd8bf6d 100644
--- a/client/loclass/elite_crack.c
+++ b/client/loclass/elite_crack.c
@@ -563,15 +563,23 @@ int bruteforceFile(const char *filename, uint16_t keytable[])
 	long fsize = ftell(f);
 	fseek(f, 0, SEEK_SET);
 
+	if (fsize < 0) {
+		prnlog("Error, when getting fsize");
+		fclose(f);
+		return 1;
+	}
+
 	uint8_t *dump = malloc(fsize);
 	size_t bytes_read = fread(dump, 1, fsize, f);
 
 	fclose(f);
-    if (bytes_read < fsize)
-    {
-        prnlog("Error, could only read %d bytes (should be %d)",bytes_read, fsize );
-    }
-	return bruteforceDump(dump,fsize,keytable);
+	if (bytes_read < fsize) {
+		prnlog("Error, could only read %d bytes (should be %d)",bytes_read, fsize );
+	}
+
+	uint8_t res = bruteforceDump(dump,fsize,keytable);
+	free(dump);
+	return res;
 }
 /**
  *