From 27eabcdccb0179e8ab003e496a46fb1621f08701 Mon Sep 17 00:00:00 2001
From: Martin Holst Swende <martin@swende.se>
Date: Mon, 2 Mar 2015 21:05:44 +0100
Subject: [PATCH] Added brackets around crc field in protocol listings

---
 client/cmdhf.c | 63 ++++++++++++++++++++++++++++----------------------
 1 file changed, 36 insertions(+), 27 deletions(-)

diff --git a/client/cmdhf.c b/client/cmdhf.c
index d279c9e6..074a37e2 100644
--- a/client/cmdhf.c
+++ b/client/cmdhf.c
@@ -288,6 +288,34 @@ uint16_t printTraceLine(uint16_t tracepos, uint16_t traceLen, uint8_t *trace, ui
 	uint8_t *parityBytes = trace + tracepos;
 	tracepos += parity_len;
 
+	//Check the CRC status
+	uint8_t crcStatus = 2;
+
+	if (data_len > 2) {
+		uint8_t b1, b2;
+		if(protocol == ICLASS)
+		{
+			crcStatus = iclass_CRC_check(isResponse, frame, data_len);
+
+		}else if (protocol == ISO_14443B)
+		{
+			crcStatus = iso14443B_CRC_check(isResponse, frame, data_len);
+		}
+		else if (protocol == ISO_14443A){//Iso 14443a
+
+			ComputeCrc14443(CRC_14443_A, frame, data_len-2, &b1, &b2);
+
+			if (b1 != frame[data_len-2] || b2 != frame[data_len-1]) {
+				if(!(isResponse & (data_len < 6)))
+				{
+						crcStatus = 0;
+				}
+			}
+		}
+	}
+	//0 CRC-command, CRC not ok
+	//1 CRC-command, CRC ok
+	//2 Not crc-command
 
 	//--- Draw the data column
 	//char line[16][110];
@@ -301,7 +329,6 @@ uint16_t printTraceLine(uint16_t tracepos, uint16_t traceLen, uint8_t *trace, ui
 		for (k=0 ; k<8 ; k++) {
 			oddparity ^= (((frame[j] & 0xFF) >> k) & 0x01);
 		}
-
 		uint8_t parityBits = parityBytes[j>>3];
 		if (isResponse && (oddparity != ((parityBits >> (7-(j&0x0007))) & 0x01))) {
 			snprintf(line[j/16]+(( j % 16) * 4),110, "%02x! ", frame[j]);
@@ -309,6 +336,14 @@ uint16_t printTraceLine(uint16_t tracepos, uint16_t traceLen, uint8_t *trace, ui
 		} else {
 			snprintf(line[j/16]+(( j % 16) * 4),110, "%02x  ", frame[j]);
 		}
+
+	}
+	if(crcStatus == 1)
+	{//CRC-command
+		char *pos1 = line[(data_len-2)/16]+(((data_len-2) % 16) * 4)-1;
+		(*pos1) = '[';
+		char *pos2 = line[(data_len)/16]+(((data_len) % 16) * 4)-2;
+		(*pos2) = ']';
 	}
 	if(data_len == 0)
 	{
@@ -317,33 +352,7 @@ uint16_t printTraceLine(uint16_t tracepos, uint16_t traceLen, uint8_t *trace, ui
 		}
 	}
 	//--- Draw the CRC column
-	uint8_t crcStatus = 2;
-
-	if (data_len > 2) {
-		uint8_t b1, b2;
-		if(protocol == ICLASS)
-		{
-			crcStatus = iclass_CRC_check(isResponse, frame, data_len);
-
-		}else if (protocol == ISO_14443B)
-		{
-			crcStatus = iso14443B_CRC_check(isResponse, frame, data_len);
-		}
-		else if (protocol == ISO_14443A){//Iso 14443a
-
-			ComputeCrc14443(CRC_14443_A, frame, data_len-2, &b1, &b2);
 
-			if (b1 != frame[data_len-2] || b2 != frame[data_len-1]) {
-				if(!(isResponse & (data_len < 6)))
-				{
-						crcStatus = 0;
-				}
-			}
-		}
-	}
-	//0 CRC-command, CRC not ok
-	//1 CRC-command, CRC ok
-	//2 Not crc-command
 	char *crc = (crcStatus == 0 ? "!crc" : (crcStatus == 1 ? " ok " : "    "));
 
 	EndOfTransmissionTimestamp = timestamp + duration;
-- 
2.39.2