From e59481c119ded9068958d080e678ddd5c7fcdd48 Mon Sep 17 00:00:00 2001 From: Fl0-0 Date: Sun, 13 Jan 2019 16:53:09 +0100 Subject: [PATCH 1/1] Fix CmdSmartUpgrade GCC8 strncpy specified bound depends on the length of the source argument warning (#755) --- client/cmdsmartcard.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/client/cmdsmartcard.c b/client/cmdsmartcard.c index 80cbec46..8f3d8d2e 100644 --- a/client/cmdsmartcard.c +++ b/client/cmdsmartcard.c @@ -581,7 +581,7 @@ int CmdSmartUpgrade(const char *Cmd) { return 1; } - char sha512filename[FILE_PATH_SIZE]; + char sha512filename[FILE_PATH_SIZE] = {'\0'}; char *bin_extension = filename; char *dot_position = NULL; while ((dot_position = strchr(bin_extension, '.')) != NULL) { @@ -592,7 +592,7 @@ int CmdSmartUpgrade(const char *Cmd) { || !strcmp(bin_extension, "bin") #endif ) { - strncpy(sha512filename, filename, strlen(filename) - strlen("bin")); + memcpy(sha512filename, filename, strlen(filename) - strlen("bin")); strcat(sha512filename, "sha512.txt"); } else { PrintAndLogEx(FAILED, "Filename extension of Firmware Upgrade File must be .BIN"); -- 2.39.2