better corruption check by calculating the number of fill bytes

[rsbs2] / firmware.c

diff --git a/firmware.c b/firmware.c
index 605611112fbff47ec5d18ac41a4c313b3da84884..aeef48c59a0071abd85baebde44f62363fca307f 100644 (file)
--- a/firmware.c
+++ b/firmware.c
@@ -345,22 +345,17 @@ int check_crc(unsigned char *fw, int len)
        return ret;
 }
 
-int check_image(unsigned char *fw, int len)
+void check_image(unsigned char *fw, int len)
 {
        struct file_entry *fent;
        char *last_name = NULL;
 
+       /* get_next_file will abort on error */
        fent = get_next_file(fw, len);
        while (fent != NULL) {
                last_name = fent->name;
                fent = get_next_file(NULL, 0);
        }
-
-       if (strcmp(last_name, "pdata")) {
-               return 1;
-       }
-
-       return 0;
 }
 
 int main(int argc, char **argv)
@@ -451,15 +446,12 @@ int main(int argc, char **argv)
                exit(1);
        }
 
-       if (check_image(fw, statbuf.st_size-4) != 0) {
-               fprintf(stderr, "corrupt firmware image found (pdata is not last entry), aborting!\n");
-               exit(1);
-       }
+       check_image(fw, statbuf.st_size - 4);
 
        if (patch_fw) {
                struct propaction *cpaction = paction;
 
-               change_properties(fw, statbuf.st_size, paction);
+               change_properties(fw, statbuf.st_size - 4, paction);
 
                printf("\nProperty change results:\n");
                while(cpaction != NULL) {
@@ -483,12 +475,12 @@ int main(int argc, char **argv)
        }
 
        if (patch_bd) {
-               handle_boarddescription(fw, statbuf.st_size -4, 1);
+               handle_boarddescription(fw, statbuf.st_size - 4, 1);
        }
 
        if (showall) {
                show_properties(fw, statbuf.st_size - 4);
-               handle_boarddescription(fw, statbuf.st_size -4, 0);
+               handle_boarddescription(fw, statbuf.st_size - 4, 0);
        }
 
        if (extract) {
@@ -501,10 +493,7 @@ int main(int argc, char **argv)
                        *((unsigned int*)(fw + statbuf.st_size - 4)) = crc;
                }
 
-               if (check_image(fw, statbuf.st_size-4) != 0) {
-                       fprintf(stderr, "corrupt firmware image found (pdata is not last entry), aborting!\n");
-                       exit(1);
-               }
+               check_image(fw, statbuf.st_size-4);
 
                if (check_crc(fw, statbuf.st_size) == 0) {
                        char *newfile;