From: gitknilch Date: Sat, 6 Apr 2013 19:39:31 +0000 (+0200) Subject: remove some hardcoded strings X-Git-Url: https://git.zerfleddert.de/cgi-bin/gitweb.cgi/FreeShisen/commitdiff_plain/aa2f597b741eacca2929c0e31ee6e9fe77151d2c remove some hardcoded strings Change-Id: Ib77caf338d57d0d1763535b8f45567f768dc1c38 Signed-off-by: gitknilch --- diff --git a/res/values/strings.xml b/res/values/strings.xml index 2bca4a5..55dd087 100644 --- a/res/values/strings.xml +++ b/res/values/strings.xml @@ -41,5 +41,9 @@ Get the source code: https://code.google.com/p/freeshisen/ 9:99:99 Really clear best times? This will clear all saved times. Hit "OK" if you really want to do this. + Preferences changed! + Changes in Preferences will only have an effect if a new game is started. Abort current game and start a new one? + Hiscore! + You\'ve made the highscore list! \ No newline at end of file diff --git a/src/de/cwde/freeshisen/ShisenShoActivity.java b/src/de/cwde/freeshisen/ShisenShoActivity.java index 0134ad7..483c6f1 100644 --- a/src/de/cwde/freeshisen/ShisenShoActivity.java +++ b/src/de/cwde/freeshisen/ShisenShoActivity.java @@ -125,7 +125,7 @@ public class ShisenShoActivity extends Activity { public void onOptionsChanged() { new AlertDialog.Builder(this) - .setTitle("Preferences changed!") // FIXME: hardcoded string + .setTitle(R.string.prefchange_confirm_title) .setCancelable(true) .setIcon(R.drawable.icon) .setPositiveButton(android.R.string.yes, @@ -136,10 +136,8 @@ public class ShisenShoActivity extends Activity { } }) .setNegativeButton(android.R.string.no, null) - .setMessage("Changes in Preferences will only have an effect if" + - " a new game is started. Abort current game and start" + - " a new one?") // FIXME: hardcoded string - .create() - .show(); + .setMessage(R.string.prefchange_confirm_text) + .create() + .show(); } } diff --git a/src/de/cwde/freeshisen/ShisenShoView.java b/src/de/cwde/freeshisen/ShisenShoView.java index bf4ad9f..6a38ffc 100644 --- a/src/de/cwde/freeshisen/ShisenShoView.java +++ b/src/de/cwde/freeshisen/ShisenShoView.java @@ -549,11 +549,12 @@ class ShisenShoView extends SurfaceView implements SurfaceHolder.Callback { if (time.compareTo(besttime2) < 0) { // score! new AlertDialog.Builder(app.activity) - .setTitle("Hiscore!") + .setTitle(R.string.hiscore_title) .setCancelable(true) .setIcon(R.drawable.icon) - .setPositiveButton(app.getString(android.R.string.ok), null) - .setMessage("You've made the highscore list!").create() // FIXME: hardcoded string + .setPositiveButton(android.R.string.ok, null) + .setMessage(R.string.hiscore_text) + .create() .show(); SharedPreferences.Editor editor = sp.edit();