From: Michael Gernoth Date: Sun, 6 Sep 2020 10:23:01 +0000 (+0200) Subject: Revert "Add missing break in switch" X-Git-Url: https://git.zerfleddert.de/cgi-bin/gitweb.cgi/hmcfgusb/commitdiff_plain/e9b66bd166d33ade31b5b89179fbafa84bcf0541?hp=2f47f304d1ffbed3869066b0cb335b7bf32a9e8d Revert "Add missing break in switch" and add comment that there should not be a break at this point. This reverts commit ee8d07d894fa10e47b4441a4db473496c701cb0f. --- diff --git a/hmland.c b/hmland.c index 8651957..fd17e85 100644 --- a/hmland.c +++ b/hmland.c @@ -437,7 +437,7 @@ static int hmlan_parse_one(uint8_t *cmd, int last, void *data) parse_part_in(&inpos, (last-(inpos-cmd)), &outpos, (sizeof(out)-(outpos-out)), 0); parse_part_in(&inpos, (last-(inpos-cmd)), &outpos, (sizeof(out)-(outpos-out)), 0); parse_part_in(&inpos, (last-(inpos-cmd)), &outpos, (sizeof(out)-(outpos-out)), FLAG_LENGTH_BYTE); - break; + // Fallthrough to default expected, no break here default: parse_part_in(&inpos, (last-(inpos-cmd)), &outpos, (sizeof(out)-(outpos-out)), FLAG_IGNORE_COMMAS); break;