From: Michael Gernoth Date: Sat, 21 May 2011 15:32:04 +0000 (+0200) Subject: only allow a reload, when the delay has really changed X-Git-Url: https://git.zerfleddert.de/cgi-bin/gitweb.cgi/ms2-fixes/commitdiff_plain/01b288b5fa86b3ae488db6d7c73272f2a2fe7c3f?ds=sidebyside only allow a reload, when the delay has really changed --- diff --git a/MS2Debounce/src/de/rmdir/ms2debounce/MS2Debounce.java b/MS2Debounce/src/de/rmdir/ms2debounce/MS2Debounce.java index abdabfc..7cc7e1d 100644 --- a/MS2Debounce/src/de/rmdir/ms2debounce/MS2Debounce.java +++ b/MS2Debounce/src/de/rmdir/ms2debounce/MS2Debounce.java @@ -41,17 +41,19 @@ public class MS2Debounce extends Activity private void updateUI() { disableUI(); + // Calling these is expensive, so cache the result... boolean loaded = module.isLoaded(); boolean safe_to_load = module.is_safe_to_load(); + int debounce_delay = module.getDelay(); TextView text = (TextView)findViewById(R.id.text); - text.setText("Current status:\n\nModule loaded: " + loaded + "\ndebounce_delay: " + module.getDelay() + "ms\nsafe_to_load: " + safe_to_load); + text.setText("Current status:\n\nModule loaded: " + loaded + "\ndebounce_delay: " + debounce_delay + "ms\nsafe_to_load: " + safe_to_load); //EditText textDelay = (EditText)findViewById(R.id.debounce_delay); //textDelay.setText(module.getSavedDelay()); Button reload = (Button)findViewById(R.id.reload); - if (loaded) { + if (loaded && module.getSavedDelay() != debounce_delay) { reload.setEnabled(true); } else { reload.setEnabled(false);