From: Michael Gernoth Date: Fri, 20 May 2011 22:54:34 +0000 (+0200) Subject: make sure that a crashing module can't lead to a reboot-loop X-Git-Url: https://git.zerfleddert.de/cgi-bin/gitweb.cgi/ms2-fixes/commitdiff_plain/d3e7b10cfe80db608785e841e1ea7c9ea3cb6e65?ds=inline;hp=6f39998e0958bb620e24626d7e2febe45546cbbf make sure that a crashing module can't lead to a reboot-loop --- diff --git a/MS2Debounce/src/de/rmdir/ms2debounce/DebounceModuleHelper.java b/MS2Debounce/src/de/rmdir/ms2debounce/DebounceModuleHelper.java index 93fd221..8dda57a 100644 --- a/MS2Debounce/src/de/rmdir/ms2debounce/DebounceModuleHelper.java +++ b/MS2Debounce/src/de/rmdir/ms2debounce/DebounceModuleHelper.java @@ -30,7 +30,12 @@ public class DebounceModuleHelper extractModule(); - // FIXME: Read settings from database... + SharedPreferences settings = ctx.getSharedPreferences(PREFS_NAME, Context.MODE_PRIVATE); + SharedPreferences.Editor editor = settings.edit(); + if (is_safe_to_load()) { + editor.putBoolean("safe_to_load", false); + editor.commit(); + } try { Process insmod = Runtime.getRuntime().exec(new String[]{"su","-c","/system/bin/insmod " + debounce_ko + " debounce_delay=" + delay}); @@ -44,12 +49,8 @@ public class DebounceModuleHelper } /* Module was obviously loaded, so it is safe to load on boot */ - if (!is_safe_to_load()) { - SharedPreferences settings = ctx.getSharedPreferences(PREFS_NAME, Context.MODE_PRIVATE); - SharedPreferences.Editor editor = settings.edit(); - editor.putBoolean("safe_to_load", true); - editor.commit(); - } + editor.putBoolean("safe_to_load", true); + editor.commit(); } public synchronized void unloadModule() {