FIX: coverity scan found some bugs in EMV code. These are the fixes to:

[proxmark3-svn] / client / proxmark3.c

diff --git a/client/proxmark3.c b/client/proxmark3.c
index 2bac7078def40191fd728feee5aec22eaf63b53a..b49b4d0511da8a4572f8281b3d0890c964ae4444 100644 (file)
--- a/client/proxmark3.c
+++ b/client/proxmark3.c
@@ -71,7 +71,7 @@ byte_t* prx = rx;
        // printf("██████╔╝██╔████╔██║ ████╔╝\n");
        // printf("██╔═══╝ ██║╚██╔╝██║   ══█║    iceman@icesql.net\n");
        // printf("██║     ██║ ╚═╝ ██║ ████╔╝ https://github.com/iceman1001/proxmark3\n");
        // printf("██████╔╝██╔████╔██║ ████╔╝\n");
        // printf("██╔═══╝ ██║╚██╔╝██║   ══█║    iceman@icesql.net\n");
        // printf("██║     ██║ ╚═╝ ██║ ████╔╝ https://github.com/iceman1001/proxmark3\n");

-       // printf("╚═╝     ╚═╝     ╚═╝ ╚═══╝v1.6.4\n");
+       // printf("╚═╝     ╚═╝     ╚═╝ ╚═══╝v1.6.8\n");

 // }
 
 
 // }
 
 


@@ -98,13 +98,13 @@ static void *uart_receiver(void *targ) {
                prx = rx;
 
                if (txcmd_pending) {
                prx = rx;
 
                if (txcmd_pending) {

-                       if ( !uart_send(sp, (byte_t*) &txcmd, sizeof(UsbCommand))) {
+                       bool res = uart_send(sp, (byte_t*) &txcmd, sizeof(UsbCommand));
+                       if (!res) {

                                PrintAndLog("Sending bytes to proxmark failed");
                        }
                        txcmd_pending = false;
                }
        }
                                PrintAndLog("Sending bytes to proxmark failed");
                        }
                        txcmd_pending = false;
                }
        }

-

        pthread_exit(NULL);
        return NULL;
 }
        pthread_exit(NULL);
        return NULL;
 }


@@ -167,9 +167,10 @@ static void *main_loop(void *targ) {
                // this one should pick up all non-null cmd...
                // why is there a 
                if (cmd) {
                // this one should pick up all non-null cmd...
                // why is there a 
                if (cmd) {

-
-                       while(cmd[strlen(cmd) - 1] == ' ')
-                               cmd[strlen(cmd) - 1] = 0x00;
+                       if (strlen(cmd) > 0) {
+                               while(cmd[strlen(cmd) - 1] == ' ')
+                                       cmd[strlen(cmd) - 1] = 0x00;
+                       }

 
                        if (cmd[0] != 0x00) {
                                int ret = CommandReceived(cmd);
 
                        if (cmd[0] != 0x00) {
                                int ret = CommandReceived(cmd);