FIX: coverity scan found some bugs in EMV code. These are the fixes to:

[proxmark3-svn] / client / loclass / cipherutils.c

diff --git a/client/loclass/cipherutils.c b/client/loclass/cipherutils.c
index 8c6a278a31e64a99448506d71e552d6b736aa6ed..427d3a254a05da2a1cafd26233d20f959db3bd8d 100644 (file)
--- a/client/loclass/cipherutils.c
+++ b/client/loclass/cipherutils.c
@@ -171,6 +171,7 @@ void printarr(char * name, uint8_t* arr, int len)
        }
        cx += snprintf(output+cx,outsize-cx,"};");
        prnlog(output);
+       free(output);
 }
 
 void printvar(char * name, uint8_t* arr, int len)
@@ -188,6 +189,7 @@ void printvar(char * name, uint8_t* arr, int len)
        }
 
        prnlog(output);
+       free(output);
 }
 
 void printarr_human_readable(char * title, uint8_t* arr, int len)
@@ -207,13 +209,14 @@ void printarr_human_readable(char * title, uint8_t* arr, int len)
                cx += snprintf(output+cx,outsize-cx, "%02x ",*(arr+i));
        }
        prnlog(output);
+       free(output);
 }
 
 //-----------------------------
 // Code for testing below
 //-----------------------------
 
-
+#ifndef ON_DEVICE
 int testBitStream()
 {
        uint8_t input [] = {0xDE,0xAD,0xBE,0xEF,0xDE,0xAD,0xBE,0xEF};
@@ -277,7 +280,6 @@ int testReversedBitstream()
        return 0;
 }
 
-
 int testCipherUtils(void)
 {
        prnlog("[+] Testing some internals...");
@@ -286,3 +288,4 @@ int testCipherUtils(void)
        retval |= testReversedBitstream();
        return retval;
 }
+#endif