FIX: Coverity scan fixes, hard to keep track of stringlengths while reading and...

[proxmark3-svn] / client / proxmark3.c

diff --git a/client/proxmark3.c b/client/proxmark3.c
index 907f5e7f79925cff59149124be406535a554c8d1..70e09adacc15aba8534debd9f1443cbb45475442 100644 (file)
--- a/client/proxmark3.c
+++ b/client/proxmark3.c
@@ -127,8 +127,8 @@ static void *main_loop(void *targ) {
        while(1)  {
 
                // If there is a script file
        while(1)  {
 
                // If there is a script file

-               if (script_file)
-               {
+               if (script_file) {
+                       

                        if (!fgets(script_cmd_buf, sizeof(script_cmd_buf), script_file)) {
                                fclose(script_file);
                                script_file = NULL;
                        if (!fgets(script_cmd_buf, sizeof(script_cmd_buf), script_file)) {
                                fclose(script_file);
                                script_file = NULL;


@@ -142,9 +142,10 @@ static void *main_loop(void *targ) {
                                
                                if (nl)
                                        *nl = '\0';
                                
                                if (nl)
                                        *nl = '\0';

-
-                               if ((cmd = (char*) malloc(strlen(script_cmd_buf) + 1)) != NULL) {
-                                       memset(cmd, 0, strlen(script_cmd_buf));
+                               
+                               int newlen = strlen(script_cmd_buf);
+                               if ((cmd = (char*) malloc( newlen + 1)) != NULL) {
+                                       memset(cmd, 0x00, newlen);

                                        strcpy(cmd, script_cmd_buf);
                                        printf("%s\n", cmd);
                                }
                                        strcpy(cmd, script_cmd_buf);
                                        printf("%s\n", cmd);
                                }


@@ -170,8 +171,14 @@ static void *main_loop(void *targ) {
                        printf("\n");
                        break;
                }
                        printf("\n");
                        break;
                }

+               free(cmd);

        }
        }

-  
+
+       if (script_file) {
+               fclose(script_file);
+               script_file = NULL;
+       }
+       

        write_history(".history");
 
        free(cmd);
        write_history(".history");
 
        free(cmd);


@@ -181,11 +188,6 @@ static void *main_loop(void *targ) {
                pthread_join(reader_thread, NULL);
        }
 
                pthread_join(reader_thread, NULL);
        }
 

-       if (script_file) {
-               fclose(script_file);
-               script_file = NULL;
-       }
-

        ExitGraphics();
        pthread_exit(NULL);
        return NULL;
        ExitGraphics();
        pthread_exit(NULL);
        return NULL;