FIX: Coverity scan fixes, hard to keep track of stringlengths while reading and...

[proxmark3-svn] / client / nonce2key / crypto1.c

diff --git a/client/nonce2key/crypto1.c b/client/nonce2key/crypto1.c
index f6779a189415e37d3867d5e4816b5d1727882e32..268d55a046378291cce7f2a40ca41ab59610b0d7 100644 (file)
--- a/client/nonce2key/crypto1.c
+++ b/client/nonce2key/crypto1.c
@@ -23,9 +23,13 @@
 struct Crypto1State * crypto1_create(uint64_t key)
 {
        struct Crypto1State *s = malloc(sizeof(*s));
-       int i;
+       if ( !s ) return NULL;
 
-       for(i = 47;s && i > 0; i -= 2) {
+       s->odd = s->even = 0;
+       
+       int i;
+       //for(i = 47;s && i > 0; i -= 2) {
+       for(i = 47; i > 0; i -= 2) {
                s->odd  = s->odd  << 1 | BIT(key, (i - 1) ^ 7);
                s->even = s->even << 1 | BIT(key, i ^ 7);
        }