cmdhf14b.c: fixing a crash in the crc computation when missing data (e.g. with 'hf...

[proxmark3-svn] / client / cmddata.c

diff --git a/client/cmddata.c b/client/cmddata.c
index 92e587abfc6c75321fee59f0cb4fb414390fbe59..265b0ed740414696b531a5fcec76044c45c39865 100644 (file)
--- a/client/cmddata.c
+++ b/client/cmddata.c
@@ -12,7 +12,7 @@
 #include <stdlib.h>
 #include <string.h>
 #include <limits.h>
 #include <stdlib.h>
 #include <string.h>
 #include <limits.h>

-#include "proxusb.h"
+#include "proxmark3.h"

 #include "data.h"
 #include "ui.h"
 #include "graph.h"
 #include "data.h"
 #include "ui.h"
 #include "graph.h"


@@ -153,22 +153,19 @@ int CmdAutoCorr(const char *Cmd)
 int CmdBitsamples(const char *Cmd)
 {
   int cnt = 0;
 int CmdBitsamples(const char *Cmd)
 {
   int cnt = 0;

-  int n = 3072;
+  uint8_t got[12288];
+  
+  GetFromBigBuf(got,sizeof(got),0);
+  WaitForResponse(CMD_ACK,NULL);

 
 

-  for (int i = 0; i < n; i += 12) {
-    UsbCommand c = {CMD_DOWNLOAD_RAW_ADC_SAMPLES_125K, {i, 0, 0}};
-    SendCommand(&c);
-    WaitForResponse(CMD_DOWNLOADED_RAW_ADC_SAMPLES_125K);
-
-    for (int j = 0; j < 48; j++) {
+    for (int j = 0; j < sizeof(got); j++) {

       for (int k = 0; k < 8; k++) {
       for (int k = 0; k < 8; k++) {

-        if(sample_buf[j] & (1 << (7 - k))) {
+        if(got[j] & (1 << (7 - k))) {

           GraphBuffer[cnt++] = 1;
         } else {
           GraphBuffer[cnt++] = 0;
         }
       }
           GraphBuffer[cnt++] = 1;
         } else {
           GraphBuffer[cnt++] = 0;
         }
       }

-    }

   }
   GraphTraceLen = cnt;
   RepaintGraphWindow();
   }
   GraphTraceLen = cnt;
   RepaintGraphWindow();


@@ -388,53 +385,51 @@ int CmdFSKdemod(const char *Cmd)
 int CmdGrid(const char *Cmd)
 {
   sscanf(Cmd, "%i %i", &PlotGridX, &PlotGridY);
 int CmdGrid(const char *Cmd)
 {
   sscanf(Cmd, "%i %i", &PlotGridX, &PlotGridY);

+  PlotGridXdefault= PlotGridX;
+  PlotGridYdefault= PlotGridY;

   RepaintGraphWindow();
   return 0;
 }
 
 int CmdHexsamples(const char *Cmd)
 {
   RepaintGraphWindow();
   return 0;
 }
 
 int CmdHexsamples(const char *Cmd)
 {

-  int n;
+  int i, j;

   int requested = 0;
   int offset = 0;
   int requested = 0;
   int offset = 0;

+  char string_buf[25];
+  char* string_ptr = string_buf;
+  uint8_t got[40000];
+ 

   sscanf(Cmd, "%i %i", &requested, &offset);
   sscanf(Cmd, "%i %i", &requested, &offset);

-  if (offset % 4 != 0) {
-    PrintAndLog("Offset must be a multiple of 4");
-    return 0;
-  }
-  offset = offset/4;                
-
-  int delivered = 0;

 
 

+  /* if no args send something */

   if (requested == 0) {
   if (requested == 0) {

-    n = 12;
-    requested = 12;
-  } else {
-    n = requested/4;
-  }
-
-  for (int i = offset; i < n+offset; i += 12) {
-    UsbCommand c = {CMD_DOWNLOAD_RAW_ADC_SAMPLES_125K, {i, 0, 0}};
-    SendCommand(&c);
-    WaitForResponse(CMD_DOWNLOADED_RAW_ADC_SAMPLES_125K);
-    for (int j = 0; j < 48; j += 8) {
-      PrintAndLog("%02x %02x %02x %02x %02x %02x %02x %02x",
-        sample_buf[j+0],
-        sample_buf[j+1],
-        sample_buf[j+2],
-        sample_buf[j+3],
-        sample_buf[j+4],
-        sample_buf[j+5],
-        sample_buf[j+6],
-        sample_buf[j+7],
-        sample_buf[j+8]
-      );
-      delivered += 8;
-      if (delivered >= requested)
-        break;
+    requested = 8;
+  }
+  if (offset + requested > sizeof(got)) {
+    PrintAndLog("Tried to read past end of buffer, <bytes> + <offset> > 40000");
+    return 0;
+  } 
+
+  GetFromBigBuf(got,requested,offset);
+  WaitForResponse(CMD_ACK,NULL);
+
+  i = 0;
+  for (j = 0; j < requested; j++) {
+    i++;
+    string_ptr += sprintf(string_ptr, "%02x ", got[j]);
+    if (i == 8) {
+      *(string_ptr - 1) = '\0';    // remove the trailing space
+      PrintAndLog("%s", string_buf);
+      string_buf[0] = '\0';
+      string_ptr = string_buf;
+      i = 0;

     }
     }

-    if (delivered >= requested)
-      break;
+    if (j == requested - 1 && string_buf[0] != '\0') { // print any remaining bytes
+      *(string_ptr - 1) = '\0';
+      PrintAndLog("%s", string_buf);
+      string_buf[0] = '\0';
+    }  

   }
   return 0;
 }
   }
   return 0;
 }


@@ -464,31 +459,30 @@ int CmdSamples(const char *Cmd)
 {
   int cnt = 0;
   int n;
 {
   int cnt = 0;
   int n;

+  uint8_t got[40000];

 
   n = strtol(Cmd, NULL, 0);
 
   n = strtol(Cmd, NULL, 0);

-  if (n == 0) n = 128;
-  if (n > 16000) n = 16000;
-
+  if (n == 0) n = 512;
+  if (n > sizeof(got)) n = sizeof(got);
+  

   PrintAndLog("Reading %d samples\n", n);
   PrintAndLog("Reading %d samples\n", n);

-  for (int i = 0; i < n; i += 12) {
-    UsbCommand c = {CMD_DOWNLOAD_RAW_ADC_SAMPLES_125K, {i, 0, 0}};
-    SendCommand(&c);
-    WaitForResponse(CMD_DOWNLOADED_RAW_ADC_SAMPLES_125K);
-    for (int j = 0; j < 48; j++) {
-      GraphBuffer[cnt++] = ((int)sample_buf[j]) - 128;
-    }
+  GetFromBigBuf(got,n,0);
+  WaitForResponse(CMD_ACK,NULL);
+  for (int j = 0; j < n; j++) {
+    GraphBuffer[cnt++] = ((int)got[j]) - 128;

   }
   }

+  

   PrintAndLog("Done!\n");
   PrintAndLog("Done!\n");

-  GraphTraceLen = n*4;
+  GraphTraceLen = n;

   RepaintGraphWindow();
   return 0;
 }
 
 int CmdLoad(const char *Cmd)
 {
   RepaintGraphWindow();
   return 0;
 }
 
 int CmdLoad(const char *Cmd)
 {

-  FILE *f = fopen(Cmd + 1, "r");
+  FILE *f = fopen(Cmd, "r");

   if (!f) {
   if (!f) {

-    PrintAndLog("couldn't open '%s'", Cmd + 1);
+    PrintAndLog("couldn't open '%s'", Cmd);

     return 0;
   }
 
     return 0;
   }
 


@@ -534,7 +528,7 @@ int CmdManchesterDemod(const char *Cmd)
   int i, j, invert= 0;
   int bit;
   int clock;
   int i, j, invert= 0;
   int bit;
   int clock;

-  int lastval;
+  int lastval = 0;

   int low = 0;
   int high = 0;
   int hithigh, hitlow, first;
   int low = 0;
   int high = 0;
   int hithigh, hitlow, first;


@@ -544,7 +538,7 @@ int CmdManchesterDemod(const char *Cmd)
   int warnings = 0;
 
   /* check if we're inverting output */
   int warnings = 0;
 
   /* check if we're inverting output */

-  if (*(Cmd + 1) == 'i')
+  if (*Cmd == 'i')

   {
     PrintAndLog("Inverting output");
     invert = 1;
   {
     PrintAndLog("Inverting output");
     invert = 1;


@@ -561,7 +555,7 @@ int CmdManchesterDemod(const char *Cmd)
 
   /* But it does not work if compiling on WIndows: therefore we just allocate a */
   /* large array */
 
   /* But it does not work if compiling on WIndows: therefore we just allocate a */
   /* large array */

-  int BitStream[MAX_GRAPH_TRACE_LEN];
+  uint8_t BitStream[MAX_GRAPH_TRACE_LEN];

 
   /* Detect high and lows */
   for (i = 0; i < GraphTraceLen; i++)
 
   /* Detect high and lows */
   for (i = 0; i < GraphTraceLen; i++)


@@ -818,7 +812,7 @@ int CmdThreshold(const char *Cmd)
     if (GraphBuffer[i] >= threshold)
       GraphBuffer[i] = 1;
     else
     if (GraphBuffer[i] >= threshold)
       GraphBuffer[i] = 1;
     else

-      GraphBuffer[i] =- 1;
+      GraphBuffer[i] = -1;

   }
   RepaintGraphWindow();
   return 0;
   }
   RepaintGraphWindow();
   return 0;


@@ -866,7 +860,7 @@ static command_t CommandTable[] =
   {"detectclock",   CmdDetectClockRate, 1, "Detect clock rate"},
   {"fskdemod",      CmdFSKdemod,        1, "Demodulate graph window as a HID FSK"},
   {"grid",          CmdGrid,            1, "<x> <y> -- overlay grid on graph window, use zero value to turn off either"},
   {"detectclock",   CmdDetectClockRate, 1, "Detect clock rate"},
   {"fskdemod",      CmdFSKdemod,        1, "Demodulate graph window as a HID FSK"},
   {"grid",          CmdGrid,            1, "<x> <y> -- overlay grid on graph window, use zero value to turn off either"},

-  {"hexsamples",    CmdHexsamples,      0, "<blocks> [<offset>] -- Dump big buffer as hex bytes"},  
+  {"hexsamples",    CmdHexsamples,      0, "<bytes> [<offset>] -- Dump big buffer as hex bytes"},  

   {"hide",          CmdHide,            1, "Hide graph window"},
   {"hpf",           CmdHpf,             1, "Remove DC offset from trace"},
   {"load",          CmdLoad,            1, "<filename> -- Load trace (to graph window"},
   {"hide",          CmdHide,            1, "Hide graph window"},
   {"hpf",           CmdHpf,             1, "Remove DC offset from trace"},
   {"load",          CmdLoad,            1, "<filename> -- Load trace (to graph window"},


@@ -874,8 +868,8 @@ static command_t CommandTable[] =
   {"mandemod",      CmdManchesterDemod, 1, "[i] [clock rate] -- Manchester demodulate binary stream (option 'i' to invert output)"},
   {"manmod",        CmdManchesterMod,   1, "[clock rate] -- Manchester modulate a binary stream"},
   {"norm",          CmdNorm,            1, "Normalize max/min to +/-500"},
   {"mandemod",      CmdManchesterDemod, 1, "[i] [clock rate] -- Manchester demodulate binary stream (option 'i' to invert output)"},
   {"manmod",        CmdManchesterMod,   1, "[clock rate] -- Manchester modulate a binary stream"},
   {"norm",          CmdNorm,            1, "Normalize max/min to +/-500"},

-  {"plot",          CmdPlot,            1, "Show graph window"},
-  {"samples",       CmdSamples,         0, "[128 - 16000] -- Get raw samples for graph window"},
+  {"plot",          CmdPlot,            1, "Show graph window (hit 'h' in window for keystroke help)"},
+  {"samples",       CmdSamples,         0, "[512 - 40000] -- Get raw samples for graph window"},

   {"save",          CmdSave,            1, "<filename> -- Save trace (from graph window)"},
   {"scale",         CmdScale,           1, "<int> -- Set cursor display scale"},
   {"threshold",     CmdThreshold,       1, "<threshold> -- Maximize/minimize every value in the graph window depending on threshold"},
   {"save",          CmdSave,            1, "<filename> -- Save trace (from graph window)"},
   {"scale",         CmdScale,           1, "<int> -- Set cursor display scale"},
   {"threshold",     CmdThreshold,       1, "<threshold> -- Maximize/minimize every value in the graph window depending on threshold"},