CHG: minor code cleaning in 'hf 14a reader'

[proxmark3-svn] / client / nonce2key / crapto1.c

diff --git a/client/nonce2key/crapto1.c b/client/nonce2key/crapto1.c
index 65e5d4b262d718e4e6a89cbb4baeb91655adacb5..b5532396e603b52a7ae2cf55eb30bcf9fae6082b 100644 (file)
--- a/client/nonce2key/crapto1.c
+++ b/client/nonce2key/crapto1.c
@@ -383,7 +383,7 @@ uint32_t lfsr_rollback_word(struct Crypto1State *s, uint32_t in, int fb)
 /** nonce_distance\r
  * x,y valid tag nonces, then prng_successor(x, nonce_distance(x, y)) = y\r
  */\r
-static uint16_t *dist = 0;\r
+static uint16_t *dist;\r
 int nonce_distance(uint32_t from, uint32_t to)\r
 {\r
        uint16_t x, i;\r
@@ -391,7 +391,7 @@ int nonce_distance(uint32_t from, uint32_t to)
                dist = malloc(2 << 16);\r
                if(!dist)\r
                        return -1;\r
-               for (x = i = 1; i; ++i) {\r
+               for (x = 1, i = 1; i; ++i) {\r
                        dist[(x & 0xff) << 8 | x >> 8] = i;\r
                        x = x >> 1 | (x ^ x >> 2 ^ x >> 3 ^ x >> 5) << 15;\r
                }\r
@@ -541,24 +541,19 @@ struct Crypto1State* lfsr_common_prefix_ex(uint32_t pfx, uint8_t ks[8])
                goto out;\r
        }\r
 \r
-       // for(o = odd; *o + 1; ++o)\r
-               // for(e = even; *e + 1; ++e)\r
-                       // for(top = 0; top < 64; ++top) {\r
-                               // *o += 1 << 21;\r
-                               // *e += (!(top & 7) + 1) << 21;\r
-                               // s = check_pfx_parity_ex(pfx, *o, *e, s);\r
-                       // }\r
-       for(o = odd; *o != -1; ++o)\r
-               for(e = even; *e != -1; ++e)\r
+       for(o = odd; *o + 1; ++o)\r
+               for(e = even; *e + 1; ++e)\r
                        for(top = 0; top < 64; ++top) {\r
-                               *o = (*o & 0x1fffff) | (top << 21);\r
-                               *e = (*e & 0x1fffff) | (top >> 3) << 21;\r
+                               *o += 1 << 21;\r
+                               *e += (!(top & 7) + 1) << 21;\r
                                s = check_pfx_parity_ex(pfx, *o, *e, s);\r
                        }\r
 \r
-       s->odd = s->even = -1;  \r
+       // in this version, -1 signifies end of states \r
+       s->odd = s->even = -1;\r
+\r
 out:\r
        free(odd);\r
        free(even);\r
        return statelist;\r
-}\r
+}
\ No newline at end of file