fix #532. looks at length of parameters.

[proxmark3-svn] / client / loclass / cipher.c

diff --git a/client/loclass/cipher.c b/client/loclass/cipher.c
index d3b1e7997beb0971319e3a17d3b3d9db1e5102e6..3b146b109b520fc05eec44c4d06aaffdfdee2205 100644 (file)
--- a/client/loclass/cipher.c
+++ b/client/loclass/cipher.c
@@ -22,7 +22,7 @@
  *
  * This is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 2 as published
  *
  * This is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 2 as published

- * by the Free Software Foundation.
+ * by the Free Software Foundation, or, at your option, any later version. 

  *
  * This file is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  *
  * This file is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of


@@ -33,20 +33,19 @@
  * along with loclass.  If not, see <http://www.gnu.org/licenses/>.
  * 
  * 
  * along with loclass.  If not, see <http://www.gnu.org/licenses/>.
  * 
  * 

- * 

  ****************************************************************************/
 
 
 #include "cipher.h"
 #include "cipherutils.h"
  ****************************************************************************/
 
 
 #include "cipher.h"
 #include "cipherutils.h"

-#include <stdio.h>

 #include <stdlib.h>
 #include <string.h>
 #include <stdbool.h>
 #include <stdint.h>
 #include <stdlib.h>
 #include <string.h>
 #include <stdbool.h>
 #include <stdint.h>

-#include <time.h>
+#ifndef ON_DEVICE

 #include "fileutils.h"
 #include "fileutils.h"

-uint8_t keytable[] = { 0,0,0,0,0,0,0,0};
+#endif
+

 
 /**
 * Definition 1 (Cipher state). A cipher state of iClass s is an element of F 40/2
 
 /**
 * Definition 1 (Cipher state). A cipher state of iClass s is an element of F 40/2


@@ -114,9 +113,9 @@ uint8_t _select(bool x, bool y, uint8_t r)
        bool r6 = r >> 1 & 0x1;
        bool r7 = r & 0x1;
 
        bool r6 = r >> 1 & 0x1;
        bool r7 = r & 0x1;
 

-       bool z0 = (r0 & r2) ^ (r1 & ~r3) ^ (r2 | r4);
+       bool z0 = (r0 & r2) ^ (r1 & !r3) ^ (r2 | r4);

        bool z1 = (r0 | r2) ^ ( r5 | r7) ^ r1 ^ r6 ^ x ^ y;
        bool z1 = (r0 | r2) ^ ( r5 | r7) ^ r1 ^ r6 ^ x ^ y;

-       bool z2 = (r3 & ~r5) ^ (r4 & r6 ) ^ r7 ^ x;
+       bool z2 = (r3 & !r5) ^ (r4 & r6 ) ^ r7 ^ x;

 
        // The three bitz z0.. z1 are packed into a uint8_t:
        // 00000ZZZ
 
        // The three bitz z0.. z1 are packed into a uint8_t:
        // 00000ZZZ


@@ -221,27 +220,48 @@ void MAC(uint8_t* k, BitstreamIn input, BitstreamOut out)
        output(k,initState,&input_32_zeroes,&out);
 }
 
        output(k,initState,&input_32_zeroes,&out);
 }
 

-void doMAC(uint8_t *cc_nr_p, int length, uint8_t *div_key_p, uint8_t mac[4])
+void doMAC(uint8_t *cc_nr_p, uint8_t *div_key_p, uint8_t mac[4])
+{
+       uint8_t cc_nr[13] = { 0 };
+       uint8_t div_key[8];
+       //cc_nr=(uint8_t*)malloc(length+1);
+
+       memcpy(cc_nr, cc_nr_p, 12);
+       memcpy(div_key, div_key_p, 8);
+
+       reverse_arraybytes(cc_nr,12);
+       BitstreamIn bitstream = {cc_nr, 12 * 8, 0};
+       uint8_t dest []= {0,0,0,0,0,0,0,0};
+       BitstreamOut out = { dest, sizeof(dest)*8, 0 };
+       MAC(div_key,bitstream, out);
+       //The output MAC must also be reversed
+       reverse_arraybytes(dest, sizeof(dest));
+       memcpy(mac, dest, 4);
+       //free(cc_nr);
+       return;
+}
+void doMAC_N(uint8_t *address_data_p, uint8_t address_data_size, uint8_t *div_key_p, uint8_t mac[4])

 {
 {

-    uint8_t *cc_nr;
-    uint8_t div_key[8];
-    cc_nr=(uint8_t*)malloc(length+1);
-    memcpy(cc_nr,cc_nr_p,length);
-    memcpy(div_key,div_key_p,8);
-
-    reverse_arraybytes(cc_nr,length);
-    BitstreamIn bitstream = {cc_nr,length * 8,0};
-    uint8_t dest []= {0,0,0,0,0,0,0,0};
-    BitstreamOut out = { dest, sizeof(dest)*8, 0 };
-    MAC(div_key,bitstream, out);
-    //The output MAC must also be reversed
-    reverse_arraybytes(dest, sizeof(dest));
-    memcpy(mac, dest, 4);
-    //printf("Calculated_MAC\t%02x%02x%02x%02x\n", dest[0],dest[1],dest[2],dest[3]);
-    free(cc_nr);
-    return;
+       uint8_t *address_data;
+       uint8_t div_key[8];
+       address_data = (uint8_t*) malloc(address_data_size);
+
+       memcpy(address_data, address_data_p, address_data_size);
+       memcpy(div_key, div_key_p, 8);
+
+       reverse_arraybytes(address_data, address_data_size);
+       BitstreamIn bitstream = {address_data, address_data_size * 8, 0};
+       uint8_t dest []= {0,0,0,0,0,0,0,0};
+       BitstreamOut out = { dest, sizeof(dest)*8, 0 };
+       MAC(div_key, bitstream, out);
+       //The output MAC must also be reversed
+       reverse_arraybytes(dest, sizeof(dest));
+       memcpy(mac, dest, 4);
+       free(address_data);
+       return;

 }
 
 }
 

+#ifndef ON_DEVICE

 int testMAC()
 {
        prnlog("[+] Testing MAC calculation...");
 int testMAC()
 {
        prnlog("[+] Testing MAC calculation...");


@@ -253,7 +273,7 @@ int testMAC()
        uint8_t correct_MAC[4] = {0x1d,0x49,0xC9,0xDA};
 
        uint8_t calculated_mac[4] = {0};
        uint8_t correct_MAC[4] = {0x1d,0x49,0xC9,0xDA};
 
        uint8_t calculated_mac[4] = {0};

-    doMAC(cc_nr, 12,div_key, calculated_mac);
+       doMAC(cc_nr,div_key, calculated_mac);

 
        if(memcmp(calculated_mac, correct_MAC,4) == 0)
        {
 
        if(memcmp(calculated_mac, correct_MAC,4) == 0)
        {


@@ -269,3 +289,4 @@ int testMAC()
 
        return 0;
 }
 
        return 0;
 }

+#endif