BUGS: more Coverity scan fixes.

[proxmark3-svn] / client / util.c

diff --git a/client/util.c b/client/util.c
index 5bb98fd77d40fa6cd73af5e4676b76209591f1b7..1c8081bf2370f342437ab2b16276cd5824dea2dd 100644 (file)
--- a/client/util.c
+++ b/client/util.c
@@ -108,23 +108,25 @@ void print_hex(const uint8_t * data, const size_t len)
        printf("\n");
 }
 
-char * sprint_hex(const uint8_t * data, const size_t len) {
+char *sprint_hex(const uint8_t *data, const size_t len) {
        
        int maxLen = ( len > 1024/3) ? 1024/3 : len;
        static char buf[1024];
-       char * tmp = buf;
+       memset(buf, 0x00, 1024);
+       char *tmp = buf;
        size_t i;
 
        for (i=0; i < maxLen; ++i, tmp += 3)
-               sprintf(tmp, "%02x ", data[i]);
+               sprintf(tmp, "%02X ", data[i]);
 
        return buf;
 }
 
 char *sprint_bin_break(const uint8_t *data, const size_t len, const uint8_t breaks) {
        
-       int maxLen = ( len > 1024) ? 1024 : len;
+       int maxLen = ( len > 1020) ? 1020 : len;
        static char buf[1024];
+       memset(buf, 0x00, 1024);
        char *tmp = buf;
 
        for (size_t i=0; i < maxLen; ++i){