Coverity Scan 133850, need to ask @jason about this one.

[proxmark3-svn] / client / reveng / poly.c

diff --git a/client/reveng/poly.c b/client/reveng/poly.c
index 0d41e5029448c147238ac74d97a5584a8efa404f..64e4a2db76b883f15a927875f9939e4e9edee7ee 100644 (file)
--- a/client/reveng/poly.c
+++ b/client/reveng/poly.c
@@ -1,9 +1,9 @@
 /* poly.c
 /* poly.c

- * Greg Cook, 29/Jul/2015
+ * Greg Cook, 24/Feb/2016

  */
 
 /* CRC RevEng, an arbitrary-precision CRC calculator and algorithm finder
  */
 
 /* CRC RevEng, an arbitrary-precision CRC calculator and algorithm finder

- * Copyright (C) 2010, 2011, 2012, 2013, 2014, 2015  Gregory Cook
+ * Copyright (C) 2010, 2011, 2012, 2013, 2014, 2015, 2016  Gregory Cook

  *
  * This file is part of CRC RevEng.
  *
  *
  * This file is part of CRC RevEng.
  *


@@ -140,7 +140,7 @@ filtop(FILE *input, unsigned long length, int flags, int bperhx) {
        bmp_t accu = BMP_C(0);
        bmp_t mask = bperhx == BMP_BIT ? ~BMP_C(0) : (BMP_C(1) << bperhx) - BMP_C(1);
        unsigned long iter = 0UL, idx;
        bmp_t accu = BMP_C(0);
        bmp_t mask = bperhx == BMP_BIT ? ~BMP_C(0) : (BMP_C(1) << bperhx) - BMP_C(1);
        unsigned long iter = 0UL, idx;

-       int cmask = ~(~0 << CHAR_BIT), c;
+       int cmask = (1 << CHAR_BIT) - 1, c;

        int count = 0, ofs;
        poly_t poly = PZERO;
        if(bperhx == 0) return(poly);
        int count = 0, ofs;
        poly_t poly = PZERO;
        if(bperhx == 0) return(poly);


@@ -205,7 +205,7 @@ strtop(const char *string, int flags, int bperhx) {
        bmp_t accu;
        bmp_t mask = bperhx == BMP_BIT ? ~BMP_C(0) : (BMP_C(1) << bperhx) - BMP_C(1);
        int pass, count, ofs;
        bmp_t accu;
        bmp_t mask = bperhx == BMP_BIT ? ~BMP_C(0) : (BMP_C(1) << bperhx) - BMP_C(1);
        int pass, count, ofs;

-       int cmask = ~(~0 << CHAR_BIT), c;
+       int cmask = (1 << CHAR_BIT) - 1 , c;

        const char *s;
 
        poly_t poly = PZERO;
        const char *s;
 
        poly_t poly = PZERO;