fix #532. looks at length of parameters.

[proxmark3-svn] / client / emv / apduinfo.c

diff --git a/client/emv/apduinfo.c b/client/emv/apduinfo.c
index e2e51d9db79c49a3b4db38f92efb27ac9148d4ce..ec7a64a199ef1a35b1a89df959846c0210c9e969 100644 (file)
--- a/client/emv/apduinfo.c
+++ b/client/emv/apduinfo.c
@@ -257,6 +257,7 @@ const APDUCode APDUCodeTable[] = {
        {"9FXX",        APDUCODE_TYPE_NONE,             "Command successfully executed; 'xx' bytes of data are available and can be requested using GET RESPONSE."},
        {"9xXX",        APDUCODE_TYPE_NONE,             "Application related status, (ISO 7816-3)"}
 };
+const size_t APDUCodeTableLen = sizeof(APDUCodeTable)/sizeof(APDUCode);
 
 int CodeCmp(const char *code1, const char *code2) {
        int xsymb = 0;
@@ -276,29 +277,42 @@ int CodeCmp(const char *code1, const char *code2) {
        return -1;
 }
 
-APDUCode *GetAPDUCode(uint8_t sw1, uint8_t sw2) {
-       char buf[4] = {0};
+const APDUCode* const GetAPDUCode(uint8_t sw1, uint8_t sw2) {
+       char buf[5] = {0};
+       int res;
+       int mineq = 100;
+       int mineqindx = 0;
        
-       sprintf(&buf[0], "%02X ", sw1);
-       sprintf(&buf[2], "%02X ", sw2);
+       sprintf(&buf[0], "%02X", sw1);
+       sprintf(&buf[2], "%02X", sw2);
        
+       for (int i = 0; i < APDUCodeTableLen; i++) {
+               res = CodeCmp(APDUCodeTable[i].ID, buf);
                
-       int tableLen = sizeof(APDUCodeTable)/sizeof(APDUCode);
-       for (int i = 0; i < tableLen; i++) {
-               if (CodeCmp(APDUCodeTable[i].ID, buf) == 0) { // TODO make not so equal comparation... XXXX - not works...
+               // equal
+               if (res == 0) { 
                        return &APDUCodeTable[i];
                }
+               
+               // with some  'X'
+               if (res > 0 && mineq > res) {
+                       mineq = res;
+                       mineqindx = i;
+               }
        }
 
+       // if we have not equal, but with some 'X'
+       if (mineqindx < 100) {
+               return &APDUCodeTable[mineqindx];
+       }
+       
        return NULL;
 }
 
-const char *GetAPDUCodeDescription(uint8_t sw1, uint8_t sw2) {
-       APDUCode *cd = GetAPDUCode(sw1, sw2);
+const char* GetAPDUCodeDescription(uint8_t sw1, uint8_t sw2) {
+       const APDUCode *cd = GetAPDUCode(sw1, sw2);
        if (cd)
                return cd->Description;
        else
                return APDUCodeTable[0].Description; //empty string
 }
-
-