X-Git-Url: https://git.zerfleddert.de/cgi-bin/gitweb.cgi/proxmark3-svn/blobdiff_plain/c71c5ee1567c08b9819b3e9733ccb81e875bfca3..25d52dd261bc454dafeedc31c9b3d62b8832b23a:/client/cmdhf.c

diff --git a/client/cmdhf.c b/client/cmdhf.c
index 025a83d4..95d4f53a 100644
--- a/client/cmdhf.c
+++ b/client/cmdhf.c
@@ -371,13 +371,25 @@ void annotateIso14443b(char *exp, size_t size, uint8_t* cmd, uint8_t cmdsize) {
 // 0 = write
 // Quite simpel tag
 void annotateLegic(char *exp, size_t size, uint8_t* cmd, uint8_t cmdsize){
-	switch(cmd[0]) {
-		case LEGIC_HSK						:snprintf(exp, size, "HANDSHAKE");break;
-		case LEGIC_READ						:snprintf(exp, size, "READ");break;
-		case LEGIC_WRITE					:snprintf(exp, size, "WRITE");break;
-		default								:snprintf(exp,size,"?"); break;
-	}		
+	
+	if ( cmdsize > 1) {
+		
+		uint8_t cmdBit = (cmd[0] & 1);
+		uint8_t address = (cmd[1] << 7) | cmd[0] >> 1;
+		
+		if (cmdBit == LEGIC_READ)
+			snprintf(exp, size, "READ Byte(%d)", address);
+		else if (cmdBit == LEGIC_WRITE )
+			snprintf(exp, size, "WRITE Byte(%d)", address);
+		else 
+			snprintf(exp, size, "?");
+				
+	} else {		
+		if ( cmd[0] == LEGIC_HSK_22 ) snprintf(exp, size, "MIM22");
+		if ( cmd[0] == LEGIC_HSK_256 ) snprintf(exp, size, "MIN256/1024");
+	}
 }
+
 /**
  * @brief iso14443A_CRC_check Checks CRC in command or response
  * @param isResponse
@@ -491,6 +503,9 @@ uint8_t iclass_CRC_check(bool isResponse, uint8_t* data, uint8_t len)
 
 uint8_t legic_CRC_check(bool isResponse, uint8_t* data, uint8_t len){
 	if (len > 2) return 2;
+	
+	uint8_t calccrc = CRC8Legic(data, len);
+	
 	return 0;
 	// crc_init(&legic_crc, 4, 0x19 >> 1, 0x5, 0);
 	// crc_clear(&legic_crc);
@@ -637,7 +652,6 @@ uint16_t printTraceLine(uint16_t tracepos, uint16_t traceLen, uint8_t *trace, ui
 		uint8_t parityBits = parityBytes[j>>3];
 		if (protocol != ISO_14443B && protocol != ISO_7816_4 &&  (isResponse || protocol == ISO_14443A)  && (oddparity != ((parityBits >> (7-(j&0x0007))) & 0x01))) {
 			snprintf(line[j/16]+(( j % 16) * 4),110, "%02x! ", frame[j]);
-
 		} else {
 			snprintf(line[j/16]+(( j % 16) * 4),110, "%02x  ", frame[j]);
 		}
@@ -654,17 +668,15 @@ uint16_t printTraceLine(uint16_t tracepos, uint16_t traceLen, uint8_t *trace, ui
 		}
 	}
 
-	if(data_len == 0 )
+	if (data_len == 0 )
 		sprintf(line[0],"<empty trace - possible error>");
 
-
 	//--- Draw the CRC column
 	char *crc = (crcStatus == 0 ? "!crc" : (crcStatus == 1 ? " ok " : "    "));
 
 	EndOfTransmissionTimestamp = timestamp + duration;
 
-	if(!isResponse)
-	{
+	if (!isResponse)	{
 		switch(protocol) {
 			case ICLASS:		annotateIclass(explanation,sizeof(explanation),frame,data_len); break;
 			case ISO_14443A:	annotateIso14443a(explanation,sizeof(explanation),frame,data_len); break;
@@ -680,7 +692,7 @@ uint16_t printTraceLine(uint16_t tracepos, uint16_t traceLen, uint8_t *trace, ui
 	int num_lines = MIN((data_len - 1)/16 + 1, 16);
 	for (int j = 0; j < num_lines ; j++) {
 		if (j == 0) {
-			PrintAndLog(" %10d | %10d | %s |%-64s | %s| %s",
+			PrintAndLog(" %10u | %10u | %s |%-64s | %s| %s",
 				(timestamp - first_timestamp),
 				(EndOfTransmissionTimestamp - first_timestamp),
 				(isResponse ? "Tag" : "Rdr"),
@@ -699,7 +711,7 @@ uint16_t printTraceLine(uint16_t tracepos, uint16_t traceLen, uint8_t *trace, ui
 	
 	if (showWaitCycles && !isResponse && next_record_is_response(tracepos, trace)) {
 		uint32_t next_timestamp = *((uint32_t *)(trace + tracepos));
-			PrintAndLog(" %10d | %10d | %s |fdt (Frame Delay Time): %d",
+			PrintAndLog(" %10u | %10u | %s |fdt (Frame Delay Time): %d",
 				(EndOfTransmissionTimestamp - first_timestamp),
 				(next_timestamp - first_timestamp),
 				"   ",