fix hw status (and USB comm in general) (#434)

* don't ignore ReadLine() errors (Windows)
* lock CmdBuffer with Mutex
* refactor WaitForResponseTimeoutW

diff --git a/client/cmdmain.c b/client/cmdmain.c
index db88b3ac8ec90ccf653db04e938cb7857878aa8c..739d68e1cbc0beb609f0d858dae78a3ad1438b95 100644 (file)
--- a/client/cmdmain.c
+++ b/client/cmdmain.c
@@ -8,6 +8,9 @@
 // Main command parser entry point
 //-----------------------------------------------------------------------------
 
 // Main command parser entry point
 //-----------------------------------------------------------------------------
 

+#include "cmdmain.h"
+
+#include <pthread.h>

 #include <stdio.h>
 #include <stdlib.h>
 #include <unistd.h>
 #include <stdio.h>
 #include <stdlib.h>
 #include <unistd.h>


@@ -21,7 +24,6 @@
 #include "cmddata.h"
 #include "cmdhw.h"
 #include "cmdlf.h"
 #include "cmddata.h"
 #include "cmdhw.h"
 #include "cmdlf.h"

-#include "cmdmain.h"

 #include "util.h"
 #include "util_posix.h"
 #include "cmdscript.h"
 #include "util.h"
 #include "util_posix.h"
 #include "cmdscript.h"


@@ -41,6 +43,8 @@ static UsbCommand cmdBuffer[CMD_BUFFER_SIZE];
 static int cmd_head;//Starts as 0
 //Points to the position of the last unread command
 static int cmd_tail;//Starts as 0
 static int cmd_head;//Starts as 0
 //Points to the position of the last unread command
 static int cmd_tail;//Starts as 0

+// to lock cmdBuffer operations from different threads
+static pthread_mutex_t cmdBufferMutex = PTHREAD_MUTEX_INITIALIZER;

 
 static command_t CommandTable[] = 
 {
 
 static command_t CommandTable[] = 
 {


@@ -86,7 +90,9 @@ int CmdRev(const char *Cmd)
 void clearCommandBuffer()
 {
     //This is a very simple operation
 void clearCommandBuffer()
 {
     //This is a very simple operation

+       pthread_mutex_lock(&cmdBufferMutex);

     cmd_tail = cmd_head;
     cmd_tail = cmd_head;

+       pthread_mutex_unlock(&cmdBufferMutex);

 }
 
 /**
 }
 
 /**


@@ -95,6 +101,7 @@ void clearCommandBuffer()
  */
 void storeCommand(UsbCommand *command)
 {
  */
 void storeCommand(UsbCommand *command)
 {

+       pthread_mutex_lock(&cmdBufferMutex);

     if( ( cmd_head+1) % CMD_BUFFER_SIZE == cmd_tail)
     {
         //If these two are equal, we're about to overwrite in the
     if( ( cmd_head+1) % CMD_BUFFER_SIZE == cmd_tail)
     {
         //If these two are equal, we're about to overwrite in the


@@ -106,6 +113,7 @@ void storeCommand(UsbCommand *command)
     memcpy(destination, command, sizeof(UsbCommand));
 
     cmd_head = (cmd_head +1) % CMD_BUFFER_SIZE; //increment head and wrap
     memcpy(destination, command, sizeof(UsbCommand));
 
     cmd_head = (cmd_head +1) % CMD_BUFFER_SIZE; //increment head and wrap

+       pthread_mutex_unlock(&cmdBufferMutex);

 }
 
 
 }
 
 


@@ -116,8 +124,10 @@ void storeCommand(UsbCommand *command)
  */
 int getCommand(UsbCommand* response)
 {
  */
 int getCommand(UsbCommand* response)
 {

+       pthread_mutex_lock(&cmdBufferMutex);

     //If head == tail, there's nothing to read, or if we just got initialized
     if(cmd_head == cmd_tail){
     //If head == tail, there's nothing to read, or if we just got initialized
     if(cmd_head == cmd_tail){

+               pthread_mutex_unlock(&cmdBufferMutex);

         return 0;
     }
     //Pick out the next unread command
         return 0;
     }
     //Pick out the next unread command


@@ -125,7 +135,7 @@ int getCommand(UsbCommand* response)
     memcpy(response, last_unread, sizeof(UsbCommand));
     //Increment tail - this is a circular buffer, so modulo buffer size
     cmd_tail = (cmd_tail +1 ) % CMD_BUFFER_SIZE;
     memcpy(response, last_unread, sizeof(UsbCommand));
     //Increment tail - this is a circular buffer, so modulo buffer size
     cmd_tail = (cmd_tail +1 ) % CMD_BUFFER_SIZE;

-
+       pthread_mutex_unlock(&cmdBufferMutex);

     return 1;
 }
 
     return 1;
 }
 


@@ -147,22 +157,28 @@ bool WaitForResponseTimeoutW(uint32_t cmd, UsbCommand* response, size_t ms_timeo
                response = &resp;
        }
 
                response = &resp;
        }
 

+       uint64_t start_time = msclock();
+       

        // Wait until the command is received
        // Wait until the command is received

-       for(size_t dm_seconds=0; dm_seconds < ms_timeout/10; dm_seconds++) {
+       while (true) {

                while(getCommand(response)) {
                        if(response->cmd == cmd){
                                return true;
                        }
                }
                while(getCommand(response)) {
                        if(response->cmd == cmd){
                                return true;
                        }
                }

-               msleep(10); // XXX ugh
-               if (dm_seconds == 200 && show_warning) { // Two seconds elapsed
+               if (msclock() - start_time > ms_timeout) {
+                       break;
+               }
+               if (msclock() - start_time > 2000 && show_warning) {

                        PrintAndLog("Waiting for a response from the proxmark...");
                        PrintAndLog("Don't forget to cancel its operation first by pressing on the button");
                        PrintAndLog("Waiting for a response from the proxmark...");
                        PrintAndLog("Don't forget to cancel its operation first by pressing on the button");

+                       break;

                }
        }
        return false;
 }
 
                }
        }
        return false;
 }
 

+

 bool WaitForResponseTimeout(uint32_t cmd, UsbCommand* response, size_t ms_timeout) {
        return WaitForResponseTimeoutW(cmd, response, ms_timeout, true);
 }
 bool WaitForResponseTimeout(uint32_t cmd, UsbCommand* response, size_t ms_timeout) {
        return WaitForResponseTimeoutW(cmd, response, ms_timeout, true);
 }

diff --git a/client/proxmark3.c b/client/proxmark3.c
index d0e68b6121a32086d8109badf8f768a28c154eee..f7a87f6d27ae86a491362eab5b522c9fae8eb519 100644 (file)
--- a/client/proxmark3.c
+++ b/client/proxmark3.c
@@ -73,12 +73,11 @@ static void *uart_receiver(void *targ) {
 
        while (arg->run) {
                rxlen = 0;
 
        while (arg->run) {
                rxlen = 0;

-               if (uart_receive(sp, prx, sizeof(UsbCommand) - (prx-rx), &rxlen)) {
+               if (uart_receive(sp, prx, sizeof(UsbCommand) - (prx-rx), &rxlen) && rxlen) {

                        prx += rxlen;
                        if (prx-rx < sizeof(UsbCommand)) {
                                continue;
                        }
                        prx += rxlen;
                        if (prx-rx < sizeof(UsbCommand)) {
                                continue;
                        }

-                       

                        UsbCommandReceived((UsbCommand*)rx);
                }
                prx = rx;
                        UsbCommandReceived((UsbCommand*)rx);
                }
                prx = rx;

diff --git a/uart/uart_win32.c b/uart/uart_win32.c
index af521ead183741637b9a56fb203c8607bd878971..121b2b51f433c417c217886ec5f606c6a51a00b2 100644 (file)
--- a/uart/uart_win32.c
+++ b/uart/uart_win32.c
@@ -107,15 +107,13 @@ void uart_close(const serial_port sp) {
   free(sp);
 }
 
   free(sp);
 }
 

-bool uart_receive(const serial_port sp, byte_t* pbtRx, size_t pszMaxRxLen, size_t* pszRxLen) {
-  ReadFile(((serial_port_windows*)sp)->hPort,pbtRx,pszMaxRxLen,(LPDWORD)pszRxLen,NULL);
-  return (*pszRxLen != 0);
+bool uart_receive(const serial_port sp, byte_t *pbtRx, size_t pszMaxRxLen, size_t *pszRxLen) {
+  return ReadFile(((serial_port_windows*)sp)->hPort, pbtRx, pszMaxRxLen, (LPDWORD)pszRxLen, NULL);

 }
 
 bool uart_send(const serial_port sp, const byte_t* pbtTx, const size_t szTxLen) {
   DWORD dwTxLen = 0;
 }
 
 bool uart_send(const serial_port sp, const byte_t* pbtTx, const size_t szTxLen) {
   DWORD dwTxLen = 0;

-  return WriteFile(((serial_port_windows*)sp)->hPort,pbtTx,szTxLen,&dwTxLen,NULL);
-  return (dwTxLen != 0);
+  return WriteFile(((serial_port_windows*)sp)->hPort, pbtTx, szTxLen, &dwTxLen, NULL);

 }
 
 bool uart_set_speed(serial_port sp, const uint32_t uiPortSpeed) {
 }
 
 bool uart_set_speed(serial_port sp, const uint32_t uiPortSpeed) {