From: roel@libnfc.org <roel@libnfc.org@ef4ab9da-24cd-11de-8aaa-f3a34680c41f>
Date: Fri, 11 Oct 2013 08:37:08 +0000 (+0000)
Subject: with the declaration of 'uint8_t destination[8]', 'destination' is already a pointer... 
X-Git-Tag: v1.0.0~46
X-Git-Url: https://git.zerfleddert.de/cgi-bin/gitweb.cgi/proxmark3-svn/commitdiff_plain/05f23c593cc5bc1d3bb9084605f38c8f08c39163?hp=51defdd4a2bb20022acaf7b94d67c3ab0d86fb96

with the declaration of 'uint8_t destination[8]', 'destination' is already a pointer, don't try to get the address of it by using '&destination', then you will get a pointer to a pointer.
---

diff --git a/client/scripting.c b/client/scripting.c
index 47f54819..43474b98 100644
--- a/client/scripting.c
+++ b/client/scripting.c
@@ -150,12 +150,13 @@ static int l_nonce2key(lua_State *L){
 
     //Push the retval on the stack
     lua_pushinteger(L,retval);
+  
     //Push the key onto the stack
-	uint8_t dest_key[8];
-	num_to_bytes(key,sizeof(dest_key),&dest_key);
+    uint8_t dest_key[8];
+    num_to_bytes(key,sizeof(dest_key),dest_key);
 
-	//printf("Pushing to lua stack: %012"llx"\n",key);
-	lua_pushlstring(L,(const char *) &dest_key,sizeof(dest_key));
+    //printf("Pushing to lua stack: %012"llx"\n",key);
+    lua_pushlstring(L,(const char *) dest_key,sizeof(dest_key));
 
     return 2; //Two return values
 }
@@ -176,15 +177,18 @@ static int l_foobar(lua_State *L)
     printf("foobar called with %d arguments" , n);
     lua_settop(L, 0);
     printf("Arguments discarded, stack now contains %d elements", lua_gettop(L));
-    UsbCommand response =  {CMD_MIFARE_READBL, {1337, 1338, 1339}};
-	printf("Now returning a uint64_t as a string");
-	uint64_t x = 0xDEADBEEF;
-	uint8_t destination[8];
-	num_to_bytes(x,sizeof(x),&destination);
-	lua_pushlstring(L,(const char *)&x,sizeof(x));
-	lua_pushlstring(L,(const char *)&destination,sizeof(destination));
-
-	return 2;
+  
+    // todo: this is not used, where was it intended for?
+    // UsbCommand response =  {CMD_MIFARE_READBL, {1337, 1338, 1339}};
+  
+    printf("Now returning a uint64_t as a string");
+    uint64_t x = 0xDEADBEEF;
+    uint8_t destination[8];
+    num_to_bytes(x,sizeof(x),destination);
+    lua_pushlstring(L,(const char *)&x,sizeof(x));
+    lua_pushlstring(L,(const char *)destination,sizeof(destination));
+
+    return 2;
 }