From: Alexis Green Date: Wed, 3 Aug 2016 05:44:36 +0000 (-0700) Subject: FIX: CoverityScan 123358 and 133864 - Unchecked return value X-Git-Url: https://git.zerfleddert.de/cgi-bin/gitweb.cgi/proxmark3-svn/commitdiff_plain/987c59849ef113c8111e7b3a7067b87a6837c882 FIX: CoverityScan 123358 and 133864 - Unchecked return value --- diff --git a/client/cmdhflegic.c b/client/cmdhflegic.c index 91682581..4ad60e3b 100644 --- a/client/cmdhflegic.c +++ b/client/cmdhflegic.c @@ -579,7 +579,10 @@ int CmdLegicCalcCrc8(const char *Cmd){ // peek at length of the input string so we can // figure out how many elements to malloc in "data" bg=en=0; - param_getptr(Cmd, &bg, &en, cmdp+1); + if (param_getptr(Cmd, &bg, &en, cmdp+1)) { + errors = true; + break; + } len = (en - bg + 1); // check that user entered even number of characters @@ -599,7 +602,10 @@ int CmdLegicCalcCrc8(const char *Cmd){ break; } - param_gethex(Cmd, cmdp+1, data, len); + if (param_gethex(Cmd, cmdp+1, data, len)) { + errors = true; + break; + } len >>= 1; cmdp += 2;