From 63c236144bee1fb2a077f0b833945c94cb29865a Mon Sep 17 00:00:00 2001 From: iceman1001 Date: Wed, 13 Jan 2016 14:53:32 +0100 Subject: [PATCH] FIX: Coverity, out-of-bounds read, 124 is less than (0x10*8)+2 (130) FIX: Coverity, dead-code, bitcomparison always false. Copy-paste error? but 0x0F can never be equal 0x10.. I guessing its 0x01. @pwpivi have to correct me if its wrong. --- client/cmdhftopaz.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/client/cmdhftopaz.c b/client/cmdhftopaz.c index aab1d248..466af7c0 100644 --- a/client/cmdhftopaz.c +++ b/client/cmdhftopaz.c @@ -257,7 +257,7 @@ int CmdHFTopazReader(const char *Cmd) { uint8_t atqa[2]; uint8_t rid_response[8]; uint8_t *uid_echo = &rid_response[2]; - uint8_t rall_response[124]; + uint8_t rall_response[130]; status = topaz_select(atqa, rid_response); @@ -286,7 +286,7 @@ int CmdHFTopazReader(const char *Cmd) { PrintAndLog("HR0 : %02x (%sa Topaz tag (%scapable of carrying a NDEF message), %s memory map)", rid_response[0], (rid_response[0] & 0xF0) == 0x10 ? "" : "not ", (rid_response[0] & 0xF0) == 0x10 ? "" : "not ", - (rid_response[0] & 0x0F) == 0x10 ? "static" : "dynamic"); + (rid_response[0] & 0x0F) == 0x01 ? "static" : "dynamic"); PrintAndLog("HR1 : %02x", rid_response[1]); status = topaz_rall(uid_echo, rall_response); -- 2.39.2