From 6b1111d7b88efe0c22d793e08c501d37a9635e9c Mon Sep 17 00:00:00 2001 From: iceman1001 Date: Wed, 13 Jan 2016 13:22:25 +0100 Subject: [PATCH 1/1] FIX: Coverity, resource leak, and variable can't be negative, --- client/loclass/elite_crack.c | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/client/loclass/elite_crack.c b/client/loclass/elite_crack.c index c824eaa1..2329e597 100644 --- a/client/loclass/elite_crack.c +++ b/client/loclass/elite_crack.c @@ -563,6 +563,12 @@ int bruteforceFile(const char *filename, uint16_t keytable[]) long fsize = ftell(f); fseek(f, 0, SEEK_SET); + if (fsize < 0) { + prnlog("Error, when getting filesize"); + fclose(f); + return 1; + } + uint8_t *dump = malloc(fsize); size_t bytes_read = fread(dump, 1, fsize, f); @@ -571,7 +577,10 @@ int bruteforceFile(const char *filename, uint16_t keytable[]) { prnlog("Error, could only read %d bytes (should be %d)",bytes_read, fsize ); } - return bruteforceDump(dump,fsize,keytable); + + uint8_t res = bruteforceDump(dump,fsize,keytable); + free(dump); + return res; } /** * -- 2.39.2