From 7a616c0d70d3018c6bf81095f7432543a38ad3c9 Mon Sep 17 00:00:00 2001 From: marshmellow42 Date: Sun, 14 Feb 2016 12:06:29 -0500 Subject: [PATCH] =?utf8?q?FIX,=20Coverity,=20Argument=20can't=20be=20negat?= =?utf8?q?ive.=20CID#=20212322,=20ftell(f)=20can=20=E2=80=A6?= MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit …be negative. Not allowed in malloc... from @iceman1001 --- client/cmdhficlass.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/client/cmdhficlass.c b/client/cmdhficlass.c index 59b0ddc3..a169e827 100644 --- a/client/cmdhficlass.c +++ b/client/cmdhficlass.c @@ -283,8 +283,12 @@ int CmdHFiClassELoad(const char *Cmd) { long fsize = ftell(f); fseek(f, 0, SEEK_SET); - uint8_t *dump = malloc(fsize); + if (fsize < 0) { + PrintAndLog("Error, when getting filesize"); + return 1; + } + uint8_t *dump = malloc(fsize); size_t bytes_read = fread(dump, 1, fsize, f); fclose(f); -- 2.39.5