From a0655c45bd7092c302145ea306b7b58662e6c9f5 Mon Sep 17 00:00:00 2001 From: "martin.holst@gmail.com" Date: Fri, 24 May 2013 21:05:45 +0000 Subject: [PATCH 1/1] Added 'core'-api, also added some error handling in scripts --- client/Makefile | 5 +++-- client/cmdscript.c | 40 +++++++++++++++++++++++++++++++--------- client/cmdscript.h | 4 ++-- 3 files changed, 36 insertions(+), 13 deletions(-) diff --git a/client/Makefile b/client/Makefile index 35f31167..5b6f4e83 100644 --- a/client/Makefile +++ b/client/Makefile @@ -42,8 +42,7 @@ endif CORESRCS = uart.c \ util.c \ - sleep.c - + sleep.c \ CMDSRCS = nonce2key/crapto1.c\ nonce2key/crypto1.c\ @@ -74,9 +73,11 @@ CMDSRCS = nonce2key/crapto1.c\ cmdmain.c \ cmdlft55xx.c \ cmdlfpcf7931.c\ + scripting.c\ cmdscript.c\ + COREOBJS = $(CORESRCS:%.c=$(OBJDIR)/%.o) CMDOBJS = $(CMDSRCS:%.c=$(OBJDIR)/%.o) diff --git a/client/cmdscript.c b/client/cmdscript.c index fde6d62d..f9bbe56e 100644 --- a/client/cmdscript.c +++ b/client/cmdscript.c @@ -1,11 +1,11 @@ //----------------------------------------------------------------------------- -// Copyright (C) 2010 iZsh +// Copyright (C) 2013 m h swende // // This code is licensed to you under the terms of the GNU GPL, version 2 or, // at your option, any later version. See the LICENSE.txt file for the text of // the license. //----------------------------------------------------------------------------- -// Data and Graph commands +// Some lua scripting glue to proxmark core. //----------------------------------------------------------------------------- #include @@ -16,6 +16,7 @@ #include #include "proxmark3.h" +#include "scripting.h" #include "data.h" #include "ui.h" #include "graph.h" @@ -29,7 +30,6 @@ #include - static int CmdHelp(const char *Cmd); static int CmdList(const char *Cmd); static int CmdRun(const char *Cmd); @@ -37,8 +37,8 @@ static int CmdRun(const char *Cmd); command_t CommandTable[] = { {"help", CmdHelp, 1, "This help"}, - {"list", CmdList, 1, " -- List available scripts"}, - {"run", CmdRun, 1, "Execute a script"}, + {"list", CmdList, 1, "List available scripts"}, + {"run", CmdRun, 1, " -- Execute a script"}, {NULL, NULL, 0, NULL} }; @@ -135,10 +135,9 @@ static int l_CmdHF14AMfCSave(lua_State *L){ return CmdHF14AMfCSave(luaL_checkstr -static void set_libraries(lua_State *L) +static void set_cmdlibraries(lua_State *L) { static const luaL_Reg hfmf_lib[] = { - //{"help", l_CmdHelp}, {"dbg", l_CmdHF14AMfDbg}, {"rdbl", l_CmdHF14AMfRdBl}, {"rdsc", l_CmdHF14AMfRdSc}, @@ -205,7 +204,12 @@ int CmdRun(const char *Cmd) // load Lua libraries luaL_openlibs(lua_state); - set_libraries(lua_state); + + //Sets the pm3 core libraries, that go a bit 'under the hood' + set_pm3_libraries(lua_state); + + //Sets the 'command line' libraries, basically just the commandline stuff + set_cmdlibraries(lua_state); char cmd_name[32]; int len = 0; memset(cmd_name, 0, 32); @@ -216,7 +220,25 @@ int CmdRun(const char *Cmd) printf("Executing file '%s'\n---------------------------\n" , cmd_name); // run the Lua script - luaL_dofile(lua_state, buf); + + int error = luaL_loadfile(lua_state, buf); + if(!error) + { + error = lua_pcall(lua_state, 0, LUA_MULTRET, 0); // once again, returns non-0 on error, + } + if(error) // if non-0, then an error + { + // the top of the stack should be the error string + if (!lua_isstring(lua_state, lua_gettop(lua_state))) + printf( "Error - but no error (?!)"); + + // get the top of the stack as the error and pop it off + const char * str = lua_tostring(lua_state, lua_gettop(lua_state)); + lua_pop(lua_state, 1); + printf(str); + } + + //luaL_dofile(lua_state, buf); // close the Lua state lua_close(lua_state); printf("-----------------Finished\n"); diff --git a/client/cmdscript.h b/client/cmdscript.h index 87a5a053..7bd7e9f8 100644 --- a/client/cmdscript.h +++ b/client/cmdscript.h @@ -1,11 +1,11 @@ //----------------------------------------------------------------------------- -// Copyright (C) 2010 iZsh +// Copyright (C) 2013 m h swende // // This code is licensed to you under the terms of the GNU GPL, version 2 or, // at your option, any later version. See the LICENSE.txt file for the text of // the license. //----------------------------------------------------------------------------- -// Data and Graph commands +// Some lua scripting glue to proxmark core. //----------------------------------------------------------------------------- -- 2.39.5