X-Git-Url: https://git.zerfleddert.de/cgi-bin/gitweb.cgi/rsbs2/blobdiff_plain/ae50f4d4b8167088d5bac42cdc07407ab96c4bb4..2fd81eb058a54dbeb196c9cea47c1f2e15f6cd51:/bmc/chassis.c

diff --git a/bmc/chassis.c b/bmc/chassis.c
index 2259d86..29541f2 100644
--- a/bmc/chassis.c
+++ b/bmc/chassis.c
@@ -31,7 +31,6 @@ static void chassis_set_pins(uint8_t pins, uint8_t state);
 void chassis_init()
 {
 	chassis_set_pins((1<<POWER_PIN) | (1<<RESET_PIN), 0);
-	CDDR |= ((1<<POWER_PIN) | (1<<RESET_PIN));
 
 	/* About 1ms */
 	OCR0 = ((F_CPU/64)/1000) - 1;
@@ -41,16 +40,27 @@ void chassis_init()
 
 }
 
+/* gracefully transition between tri-state and active */
 static void chassis_set_pins(uint8_t pins, uint8_t state)
 {
-#ifdef ACTIVE_LOW
-	state = !state;
-#endif
-
 	if(state) {
+		/* active */
+#ifndef ACTIVE_LOW
+		/* Pull UPs for a short moment... */
 		CPORT |= pins;
+#endif
+		CDDR |= pins;
+#ifdef ACTIVE_LOW
+		CPORT &= ~pins;
+#endif
 	} else {
+#ifdef ACTIVE_LOW
+		CPORT &= ~pins; /* NoOp... */
+#endif
+		CDDR &= ~pins;
+#ifndef ACTIVE_LOW
 		CPORT &= ~pins;
+#endif
 	}
 }