X-Git-Url: https://git.zerfleddert.de/cgi-bin/gitweb.cgi/upsgraph/blobdiff_plain/58c56c832af936147946c4b2e30eb3e1f90ee51d..6c1071ee6b37201ba1e39703a198c35d219fc647:/upsgraph.pl

diff --git a/upsgraph.pl b/upsgraph.pl
index 9ed59ba..812de11 100755
--- a/upsgraph.pl
+++ b/upsgraph.pl
@@ -9,29 +9,22 @@ use Net::SNMP;
 use RRDs;
 use Data::Dumper;
 
-$UPSGRAPH::host = "";
-$UPSGRAPH::rrdfile = "";
 $UPSGRAPH::outdir = "";
-$UPSGRAPH::community = "public";
 $UPSGRAPH::step = 60;
 $UPSGRAPH::keep = (370*24*60*60)/$UPSGRAPH::step;
-@UPSGRAPH::fields = ();
-$UPSGRAPH::vars = {};
+$UPSGRAPH::hosts = ();
 
 do $ARGV[0] or die "can't read config: $!";
 
-my $host = $UPSGRAPH::host;
-my $rrdfile = $UPSGRAPH::rrdfile;
 my $outdir = $UPSGRAPH::outdir;
-my $community = $UPSGRAPH::community;
 my $step = $UPSGRAPH::step;
 my $keep = $UPSGRAPH::keep;
-my @fields = @UPSGRAPH::fields;
-my $vars = $UPSGRAPH::vars;
+my $hosts = $UPSGRAPH::hosts;
 
 sub rrdcreate(@) {
 	my $newrrd = shift;
 	my $field = shift;
+	my $vars = shift;
 	my $start = shift;
 
 	my @cmd = ("${newrrd}", "--step=${step}");
@@ -53,83 +46,49 @@ sub rrdcreate(@) {
 	}
 }
 
-if ($> == 0) {
-	if (@ARGV != 2) {
-		print STDERR "Running as root, please provide UID as 2th argument!\n";
-		exit(1);
-	}
-
-	print "Running as root, switching to ".$ARGV[1]."\n";
-	$< = $> = $ARGV[1];
-}
-
-if (-e "${rrdfile}") {
-	print "Reading old ${rrdfile} to preserve data...\n";
-
-	my $rrdinfo = RRDs::info("${rrdfile}");
-	if (RRDs::error) {
-		print "Error while getting info: " . RRDs::error . "\n";
-		exit 1;
-	}
-
-	(my $start, my $ostep, my $names, my $data) =
-		RRDs::fetch("${rrdfile}",
-				"-s " . (time() - ($rrdinfo->{'rra[0].rows'} * $rrdinfo->{'step'})),
-				"AVERAGE");
+sub fetch_snmp(@) {
+	my $address = shift;
+	my $community = shift;
+	my $oid = shift;
 
-	if (RRDs::error) {
-		print "Error while fetching data: " . RRDs::error . "\n";
-		exit 1;
-	}
+	(my $session, my $error) = Net::SNMP->session(Hostname => $address,
+			Community => $community);
 
-	foreach my $field (@$names) {
-		if (! -e "${rrdfile}.${field}") {
-			rrdcreate("${rrdfile}.${field}","${field}",(${start}-${ostep}));
-		}
-	}
+	die "session error: $error" unless ($session);
 
-	my $pos = $start;
-	foreach my $line (@$data) {
-		foreach my $field (@$names) {
-			my $val = shift (@$line);
-			next if (!defined($val));
+	$session->translate(0);
 
-			RRDs::update("${rrdfile}.${field}", "${pos}:${val}");
-			if (RRDs::error) {
-				print "Can't insert data: " . RRDs::error . "\n";
-				exit 1;
-			}
+	my $val = $session->get_request($oid);
 
-		}
+	$session->close;
 
-		$pos += $ostep;
+	$val;
+}
 
-		if ((($pos-$start)/$ostep) == $#$data) {
-			last;
-		}
+if ($> == 0) {
+	if (@ARGV != 2) {
+		print STDERR "Running as root, please provide UID as 2th argument!\n";
+		exit(1);
 	}
 
-	rename("${rrdfile}", "${rrdfile}.old") or die "Can't rename old file: $!\n";
+	print "Running as root, switching to ".$ARGV[1]."\n";
+	$< = $> = $ARGV[1];
 }
 
-foreach my $field (@fields) {
-	if (! -e "${rrdfile}.${field}") {
-		print "Creating ${rrdfile}.${field}...\n";
-		rrdcreate("${rrdfile}.${field}","${field}");
-	}
+foreach my $host (@$hosts) {
+	my $rrdfile = $host->{'rrdfile'};
 
-	my $rrdinfo = RRDs::info("${rrdfile}.${field}");
-	if (RRDs::error) {
-		print "Error while getting info: " . RRDs::error . "\n";
-		exit 1;
-	}
+	if (-e "${rrdfile}") {
+		print "Reading old ${rrdfile} to preserve data...\n";
 
-	if ($rrdinfo->{'rra[0].rows'} != $keep) {
-		print "Resizing ${rrdfile}.${field} from " . $rrdinfo->{'rra[0].rows'} .
-			" to ${keep} samples.\n";
+		my $rrdinfo = RRDs::info("${rrdfile}");
+		if (RRDs::error) {
+			print "Error while getting info: " . RRDs::error . "\n";
+			exit 1;
+		}
 
 		(my $start, my $ostep, my $names, my $data) =
-			RRDs::fetch("${rrdfile}.${field}",
+			RRDs::fetch("${rrdfile}",
 					"-s " . (time() - ($rrdinfo->{'rra[0].rows'} * $rrdinfo->{'step'})),
 					"AVERAGE");
 
@@ -138,24 +97,29 @@ foreach my $field (@fields) {
 			exit 1;
 		}
 
-		rrdcreate("${rrdfile}.${field}.new", "${field}", (${start}-${ostep}));
-
-		print "Preserving data since " . localtime($start) . "\n";
+		foreach my $field (@$names) {
+			if (! -e "${rrdfile}.${field}") {
+				rrdcreate("${rrdfile}.${field}",
+					"${field}",
+					$host->{'vars'},
+					(${start}-${ostep}));
+			}
+		}
 
 		my $pos = $start;
 		foreach my $line (@$data) {
-			my $vline = "${pos}";
-
-			foreach my $val (@$line) {
+			foreach my $field (@$names) {
+				my $val = shift (@$line);
 				$val = 'U' if (!defined($val));
-				$vline .= ":${val}";
-			}
-			RRDs::update("${rrdfile}.${field}.new", $vline) or die "Can't insert data\n";
 
-			if (RRDs::error) {
-				print "Error while updating: " . RRDs::error . "\n";
-				exit 1;
+				RRDs::update("${rrdfile}.${field}", "${pos}:${val}");
+				if (RRDs::error) {
+					print "Can't insert data: " . RRDs::error . "\n";
+					exit 1;
+				}
+
 			}
+
 			$pos += $ostep;
 
 			if ((($pos-$start)/$ostep) == $#$data) {
@@ -163,135 +127,192 @@ foreach my $field (@fields) {
 			}
 		}
 
-		rename("${rrdfile}.${field}", "${rrdfile}.${field}.old") or die "Can't rename old file: $!\n";
-		rename("${rrdfile}.${field}.new", "${rrdfile}.${field}") or die "Can't rename new file: $!\n";
+		rename("${rrdfile}", "${rrdfile}.old") or die "Can't rename old file: $!\n";
+	}
 
-		$rrdinfo = RRDs::info("${rrdfile}.${field}");
+	foreach my $field (@{$host->{'fields'}}) {
+		if (! -e "${rrdfile}.${field}") {
+			print "Creating ${rrdfile}.${field}...\n";
+			rrdcreate("${rrdfile}.${field}",
+				"${field}",
+				$host->{'vars'});
+		}
+
+		my $rrdinfo = RRDs::info("${rrdfile}.${field}");
 		if (RRDs::error) {
 			print "Error while getting info: " . RRDs::error . "\n";
 			exit 1;
 		}
 
 		if ($rrdinfo->{'rra[0].rows'} != $keep) {
-			print "Failed!\n";
-			exit 1;
-		}
-	}
-}
+			print "Resizing ${rrdfile}.${field} from " . $rrdinfo->{'rra[0].rows'} .
+				" to ${keep} samples.\n";
 
-my $child = fork();
+			(my $start, my $ostep, my $names, my $data) =
+				RRDs::fetch("${rrdfile}.${field}",
+						"-s " . (time() - ($rrdinfo->{'rra[0].rows'} * $rrdinfo->{'step'})),
+						"AVERAGE");
 
-die "fork failed!" if (!defined($child));
+			if (RRDs::error) {
+				print "Error while fetching data: " . RRDs::error . "\n";
+				exit 1;
+			}
 
-exit 0 if ($child != 0);
+			rrdcreate("${rrdfile}.${field}.new",
+				"${field}",
+				$host->{'vars'},
+				(${start}-${ostep}));
 
-while(1) {
-	($session,$error) = Net::SNMP->session(Hostname => $host,
-			Community => $community);
+			print "Preserving data since " . localtime($start) . "\n";
 
-	die "session error: $error" unless ($session);
+			my $pos = $start;
+			foreach my $line (@$data) {
+				my $vline = "${pos}";
 
-	$session->translate(0);
+				foreach my $val (@$line) {
+					$val = 'U' if (!defined($val));
+					$vline .= ":${val}";
+				}
+				RRDs::update("${rrdfile}.${field}.new", $vline) or die "Can't insert data\n";
 
-	foreach my $var (@fields) {
-		delete $vars->{$var}->{'value'};
+				if (RRDs::error) {
+					print "Error while updating: " . RRDs::error . "\n";
+					exit 1;
+				}
+				$pos += $ostep;
 
-		my $result = $session->get_request($vars->{$var}->{'oid'});
-		next unless (defined $result);
+				if ((($pos-$start)/$ostep) == $#$data) {
+					last;
+				}
+			}
 
-		$vars->{$var}->{'value'} = $result->{$vars->{$var}->{'oid'}};
-		if (defined($vars->{$var}->{'factor'})) {
-			$vars->{$var}->{'value'} *= $vars->{$var}->{'factor'};
-		}
-	}
+			rename("${rrdfile}.${field}", "${rrdfile}.${field}.old") or die "Can't rename old file: $!\n";
+			rename("${rrdfile}.${field}.new", "${rrdfile}.${field}") or die "Can't rename new file: $!\n";
 
-	$session->close;
+			$rrdinfo = RRDs::info("${rrdfile}.${field}");
+			if (RRDs::error) {
+				print "Error while getting info: " . RRDs::error . "\n";
+				exit 1;
+			}
 
-	foreach my $var (@fields) {
-		if (!(defined($vars->{$var}->{'value'}))) {
-			$vars->{$var}->{'value'} = 'U';
+			if ($rrdinfo->{'rra[0].rows'} != $keep) {
+				print "Failed!\n";
+				exit 1;
+			}
 		}
-		RRDs::update("${rrdfile}.${var}", "N:" . $vars->{$var}->{'value'});
-	}
-	if (RRDs::error) {
-		print "Error while updating: " . RRDs::error . "\n";
 	}
+}
+
+my $child = fork();
 
+die "fork failed!" if (!defined($child));
+
+exit 0 if ($child != 0);
+
+while(1) {
 	open(HTML, ">${outdir}/index.html.new");
 
 	print HTML '<html><head><meta http-equiv="refresh" content="60"/><meta http-equiv="cache-control" content="no-cache"/><meta http-equiv="pragma" content="no-cache"/><meta http_equiv="expires" content="Sat, 26 Jul 1997 05:00:00 GMT"/><title>USV status</title></head>';
 	print HTML '<body bgcolor="#ffffff">';
 
-	foreach my $var (@fields) {
-		my @graphdef = ("-t", $vars->{$var}->{'name'}, "DEF:${var}=${rrdfile}.${var}:${var}:AVERAGE", "LINE1:${var}#FF0000");
-		(my $averages, my $width, my $height) =
-			RRDs::graph("${outdir}/${var}.png.new",
-			"-w", "720", @graphdef);
+	foreach my $host (@$hosts) {
+		my $vars = $host->{'vars'};
+		my $rrdfile = $host->{'rrdfile'};
+		my $hostname = $host->{'name'};
+
+		foreach my $var (@{$host->{'fields'}}) {
+			delete $vars->{$var}->{'value'};
 
+			my $result = fetch_snmp($host->{'address'}, $host->{'community'}, $vars->{$var}->{'oid'});
+			next unless (defined $result);
+
+			$vars->{$var}->{'value'} = $result->{$vars->{$var}->{'oid'}};
+			if (defined($vars->{$var}->{'factor'})) {
+				$vars->{$var}->{'value'} *= $vars->{$var}->{'factor'};
+			}
+		}
+
+		foreach my $var (@{$host->{'fields'}}) {
+			if (!(defined($vars->{$var}->{'value'}))) {
+				$vars->{$var}->{'value'} = 'U';
+			}
+			RRDs::update("${rrdfile}.${var}", "N:" . $vars->{$var}->{'value'});
+		}
 		if (RRDs::error) {
-			print "Error while graphing: " . RRDs::error . "\n";
-		} else {
-			rename("${outdir}/${var}.png.new", "${outdir}/${var}.png");
+			print "Error while updating: " . RRDs::error . "\n";
 		}
 
-		print HTML "<a href=\"${var}.html\"><img src=\"${var}.png\" width=\"${width}\" height=\"${height}\" border=\"0\"></a>";
+		foreach my $var (@{$host->{'fields'}}) {
+			my @graphdef = ("-t", $hostname." - ".$vars->{$var}->{'name'}, "DEF:${var}=${rrdfile}.${var}:${var}:AVERAGE", "LINE1:${var}#FF0000");
+			(my $averages, my $width, my $height) =
+				RRDs::graph("${outdir}/${hostname}.${var}.png.new",
+						"-w", "720", @graphdef);
 
-		open (HTML2, ">${outdir}/${var}.html.new");
-		print HTML2 "<html><head><title>" . $vars->{$var}->{'name'} . "</title></head>";
-		print HTML2 '<body bgcolor="#ffffff">';
+			if (RRDs::error) {
+				print "Error while graphing: " . RRDs::error . "\n";
+			} else {
+				rename("${outdir}/${hostname}.${var}.png.new", "${outdir}/${hostname}.${var}.png");
+			}
 
+			print HTML "<a href=\"${hostname}.${var}.html\"><img src=\"${hostname}.${var}.png\" width=\"${width}\" height=\"${height}\" border=\"0\"></a>";
 
-		push @graphdef, "VDEF:min=${var},MINIMUM";
-		push @graphdef, "GPRINT:min:Minimum\\: %.2lf";
+			open (HTML2, ">${outdir}/${hostname}.${var}.html.new");
+			print HTML2 "<html><head><title>" . $vars->{$var}->{'name'} . "</title></head>";
+			print HTML2 '<body bgcolor="#ffffff">';
 
-		push @graphdef, "VDEF:avg=${var},AVERAGE";
-		push @graphdef, "GPRINT:avg:Average\\: %.2lf";
 
-		push @graphdef, "VDEF:max=${var},MAXIMUM";
-		push @graphdef, "GPRINT:max:Maximum\\: %.2lf";
+			push @graphdef, "VDEF:min=${var},MINIMUM";
+			push @graphdef, "GPRINT:min:Minimum\\: %.2lf";
 
-		push @graphdef, "VDEF:cur=${var},LAST";
-		push @graphdef, "GPRINT:cur:Current\\: %.2lf";
+			push @graphdef, "VDEF:avg=${var},AVERAGE";
+			push @graphdef, "GPRINT:avg:Average\\: %.2lf";
 
-		($averages, $width, $height) =
-			RRDs::graph("${outdir}/${var}.long.png.new",
-			"-w", "1008", @graphdef);
+			push @graphdef, "VDEF:max=${var},MAXIMUM";
+			push @graphdef, "GPRINT:max:Maximum\\: %.2lf";
 
-		if (RRDs::error) {
-			print "Error while graphing: " . RRDs::error . "\n";
-		} else {
-			rename("${outdir}/${var}.long.png.new", "${outdir}/${var}.long.png");
-		}
+			push @graphdef, "VDEF:cur=${var},LAST";
+			push @graphdef, "GPRINT:cur:Current\\: %.2lf";
 
-		print HTML2 "<img src=\"${var}.long.png\" width=\"${width}\" height=\"${height}\"><br>";
+			($averages, $width, $height) =
+				RRDs::graph("${outdir}/${hostname}.${var}.long.png.new",
+						"-w", "1008", @graphdef);
 
-		($averages, $width, $height) =
-			RRDs::graph("${outdir}/${var}.week.png.new",
-			"-w", "1008", "-e", "now", "-s", "end-1w", @graphdef);
+			if (RRDs::error) {
+				print "Error while graphing: " . RRDs::error . "\n";
+			} else {
+				rename("${outdir}/${hostname}.${var}.long.png.new", "${outdir}/${hostname}.${var}.long.png");
+			}
 
-		if (RRDs::error) {
-			print "Error while graphing: " . RRDs::error . "\n";
-		} else {
-			rename("${outdir}/${var}.week.png.new", "${outdir}/${var}.week.png");
-		}
+			print HTML2 "<img src=\"${hostname}.${var}.long.png\" width=\"${width}\" height=\"${height}\"><br>";
+
+			($averages, $width, $height) =
+				RRDs::graph("${outdir}/${hostname}.${var}.week.png.new",
+						"-w", "1008", "-e", "now", "-s", "end-1w", @graphdef);
+
+			if (RRDs::error) {
+				print "Error while graphing: " . RRDs::error . "\n";
+			} else {
+				rename("${outdir}/${hostname}.${var}.week.png.new", "${outdir}/${hostname}.${var}.week.png");
+			}
 
-		print HTML2 "<img src=\"${var}.week.png\" width=\"${width}\" height=\"${height}\"><br>";
+			print HTML2 "<img src=\"${hostname}.${var}.week.png\" width=\"${width}\" height=\"${height}\"><br>";
 
-		($averages, $width, $height) =
-			RRDs::graph("${outdir}/${var}.year.png.new",
-			"-w", "1008", "-e", "now", "-s", "end-1y", @graphdef);
+			($averages, $width, $height) =
+				RRDs::graph("${outdir}/${hostname}.${var}.year.png.new",
+						"-w", "1008", "-e", "now", "-s", "end-1y", @graphdef);
 
-		if (RRDs::error) {
-			print "Error while graphing: " . RRDs::error . "\n";
-		} else {
-			rename("${outdir}/${var}.year.png.new", "${outdir}/${var}.year.png");
-		}
+			if (RRDs::error) {
+				print "Error while graphing: " . RRDs::error . "\n";
+			} else {
+				rename("${outdir}/${hostname}.${var}.year.png.new", "${outdir}/${hostname}.${var}.year.png");
+			}
 
-		print HTML2 "<img src=\"${var}.year.png\" width=\"${width}\" height=\"${height}\"><br>";
+			print HTML2 "<img src=\"${hostname}.${var}.year.png\" width=\"${width}\" height=\"${height}\"><br>";
 
-		print HTML2 "</body></html>\n";
-		close(HTML2);
-		rename("${outdir}/${var}.html.new", "${outdir}/${var}.html");
+			print HTML2 "</body></html>\n";
+			close(HTML2);
+			rename("${outdir}/${hostname}.${var}.html.new", "${outdir}/${hostname}.${var}.html");
+		}
 	}
 
 	print HTML "</body></html>\n";