X-Git-Url: https://git.zerfleddert.de/cgi-bin/gitweb.cgi/upsgraph/blobdiff_plain/e0acc35a4f60d2641e71593713acfb32cafef751..1c46ea617272124eae806cd59532ae86822eaf4f:/upsgraph.pl diff --git a/upsgraph.pl b/upsgraph.pl index 9887d0c..0d19fb6 100755 --- a/upsgraph.pl +++ b/upsgraph.pl @@ -1,5 +1,9 @@ #!/usr/bin/perl -w +#Due to memory leak in Debian squeeze (Bug #545519) +my $use_rrds = 0; +my $rrd_result = 0; + if ((@ARGV != 1) && (@ARGV != 2)) { print STDERR "Syntax: ${0} configfile [uid]\n"; exit(1); @@ -7,6 +11,7 @@ if ((@ARGV != 1) && (@ARGV != 2)) { use Net::SNMP; use IO::Socket::INET; +use IO::Select; use RRDs; use File::Copy; use Data::Dumper; @@ -23,6 +28,43 @@ my $step = $UPSGRAPH::step; my $keep = $UPSGRAPH::keep; my $hosts = $UPSGRAPH::hosts; +sub rrd_update(@) { + my @args = @_; + + if ($use_rrds == 1) { + RRDs::update(@args); + $rrd_result = RRDs::error; + } else { + $rrd_result = system("rrdtool", "update", @args); + } +} + +sub rrd_graph(@) { + my @args = @_; + my @rrd_out = (); + + if ($use_rrds == 1) { + @rrd_out = RRDs::graph(@args); + $rrd_result = RRDs::error; + } else { + my $rrd_stdout; + + open(RRDFD, '-|', 'rrdtool', 'graph', @args); + while() { + chomp; + $rrd_stdout = $_; + } + close(RRDFD); + $rrd_result = $?; + if ($rrd_result == 0) { + push @rrd_out, 0; + push @rrd_out, split(/x/, $rrd_stdout); + } + } + + return @rrd_out; +} + sub rrdcreate(@) { my $newrrd = shift; my $field = shift; @@ -83,7 +125,13 @@ sub fetch_tcp(@) { return undef if (!$sock); - chomp(my $value = <$sock>); + my $select = IO::Select->new($sock); + + my $value = undef; + + if ($select->can_read(1)) { + chomp($value) if (sysread($sock, $value, 4096) > 0); + } close($sock); @@ -96,6 +144,39 @@ sub fetch_tcp(@) { $value; } +sub fetch_tcp_multi(@) { + my $address = shift; + my $port = shift; + my $delimiter = shift; + my %values; + + my $sock = IO::Socket::INET->new(PeerAddr => $address, + PeerPort => $port, + Proto => 'tcp', + Timeout => 1); + + return undef if (!$sock); + + my $select = IO::Select->new($sock); + + while($select->can_read(1)) { + if (sysread($sock, my $buf, 16384) > 0) { + $buf=~s/\r//g; + foreach my $line (split(/\n/, $buf)) { + (my $key, my $value) = split(/${delimiter}/, $line); + $value=~ s/\s//g; + $values{$key} = $value; + } + } else { + last; + } + } + + close($sock); + + %values; +} + if ($> == 0) { if (@ARGV != 2) { print STDERR "Running as root, please provide UID as 2th argument!\n"; @@ -292,6 +373,7 @@ while(1) { my $vars = $host->{'vars'}; my $rrdfile = $host->{'rrdfile'}; my $hostname = $host->{'name'}; + my %multi_values = (); foreach my $var (@{$host->{'fields'}}) { delete $vars->{$var}->{'value'}; @@ -304,6 +386,14 @@ while(1) { $result = fetch_snmp($host->{'address'}, $host->{'community'}, $vars->{$var}->{'oid'}); } elsif ($vars->{$var}->{'proto'} eq 'tcp') { $result = fetch_tcp($host->{'address'}, $vars->{$var}->{'port'}); + } elsif ($vars->{$var}->{'proto'} eq 'tcp_multi') { + if (defined($multi_values{$vars->{$var}->{'multi_id'}})) { + $result = $multi_values{$vars->{$var}->{'multi_id'}} + } else { + my %values = fetch_tcp_multi($host->{'address'}, $vars->{$var}->{'port'}, $vars->{$var}->{'multi_delimiter'}); + @multi_values{keys %values} = values %values; + $result = $multi_values{$vars->{$var}->{'multi_id'}}; + } } next unless (defined $result); @@ -318,10 +408,10 @@ while(1) { if (!(defined($vars->{$var}->{'value'}))) { $vars->{$var}->{'value'} = 'U'; } - RRDs::update("${rrdfile}.${var}", "N:" . $vars->{$var}->{'value'}); + rrd_update("${rrdfile}.${var}", "N:" . $vars->{$var}->{'value'}); } - if (RRDs::error) { - print "Error while updating: " . RRDs::error . "\n"; + if ($rrd_result) { + print "Error while updating: " . $rrd_result . "\n"; } foreach my $var (@{$host->{'fields'}}) { @@ -334,14 +424,14 @@ while(1) { $mtime=(stat("${outdir}/${hostname}.${var}.png.work"))[9]; (my $averages, my $width, my $height) = - RRDs::graph("${outdir}/${hostname}.${var}.png.work", + rrd_graph("${outdir}/${hostname}.${var}.png.work", "-w", "720", @graphdef); pop @graphdef; pop @graphdef; - if (RRDs::error) { - print "Error while graphing: " . RRDs::error . "\n"; + if ($rrd_result) { + print "Error while graphing: " . $rrd_result . "\n"; } else { my $newmtime=(stat("${outdir}/${hostname}.${var}.png.work"))[9]; if ((!defined($mtime)) || ($newmtime != $mtime)) { @@ -353,7 +443,7 @@ while(1) { print HTML "
\n"; open (HTML2, ">${outdir}/${hostname}.${var}.html.new"); - print HTML2 '' . $vars->{$var}->{'name'} . ''; + print HTML2 '' . $vars->{$var}->{'name'} . ''; print HTML2 ''; push @graphdef, "VDEF:min=${var},MINIMUM"; @@ -370,11 +460,11 @@ while(1) { $mtime=(stat("${outdir}/${hostname}.${var}.long.png.work"))[9]; ($averages, $width, $height) = - RRDs::graph("${outdir}/${hostname}.${var}.long.png.work", + rrd_graph("${outdir}/${hostname}.${var}.long.png.work", "-w", "1008", @graphdef); - if (RRDs::error) { - print "Error while graphing: " . RRDs::error . "\n"; + if ($rrd_result) { + print "Error while graphing: " . $rrd_result . "\n"; } else { my $newmtime=(stat("${outdir}/${hostname}.${var}.long.png.work"))[9]; if ((!defined($mtime)) || ($newmtime != $mtime)) { @@ -383,15 +473,15 @@ while(1) { } } - print HTML2 "
"; + print HTML2 "
\n"; $mtime=(stat("${outdir}/${hostname}.${var}.week.png.work"))[9]; ($averages, $width, $height) = - RRDs::graph("${outdir}/${hostname}.${var}.week.png.work", + rrd_graph("${outdir}/${hostname}.${var}.week.png.work", "-w", "1008", "-e", "now", "-s", "end-1w", @graphdef); - if (RRDs::error) { - print "Error while graphing: " . RRDs::error . "\n"; + if ($rrd_result) { + print "Error while graphing: " . $rrd_result . "\n"; } else { my $newmtime=(stat("${outdir}/${hostname}.${var}.week.png.work"))[9]; if ((!defined($mtime)) || ($newmtime != $mtime)) { @@ -400,15 +490,15 @@ while(1) { } } - print HTML2 "
"; + print HTML2 "
\n"; $mtime=(stat("${outdir}/${hostname}.${var}.year.png.work"))[9]; ($averages, $width, $height) = - RRDs::graph("${outdir}/${hostname}.${var}.year.png.work", + rrd_graph("${outdir}/${hostname}.${var}.year.png.work", "-w", "1008", "-e", "now", "-s", "end-1y", @graphdef); - if (RRDs::error) { - print "Error while graphing: " . RRDs::error . "\n"; + if ($rrd_result) { + print "Error while graphing: " . $rrd_result . "\n"; } else { my $newmtime=(stat("${outdir}/${hostname}.${var}.year.png.work"))[9]; if ((!defined($mtime)) || ($newmtime != $mtime)) { @@ -417,7 +507,7 @@ while(1) { } } - print HTML2 "
"; + print HTML2 "
\n"; print HTML2 "\n"; close(HTML2);