From e5da3876baf867c77cf76593d26d88c76c6c49ae Mon Sep 17 00:00:00 2001 From: Michael Gernoth Date: Sun, 20 Dec 2009 19:18:09 +0100 Subject: [PATCH] use RRDs perl module, keep samples a year --- upsgraph.pl | 171 +++++++++++++++++++++++++++++++++++++++++++++------- 1 file changed, 149 insertions(+), 22 deletions(-) diff --git a/upsgraph.pl b/upsgraph.pl index 5c94daf..19d8147 100755 --- a/upsgraph.pl +++ b/upsgraph.pl @@ -6,12 +6,15 @@ if ((@ARGV != 1) && (@ARGV != 2)) { } use Net::SNMP; +use RRDs; +use Data::Dumper; $UPSGRAPH::host = ""; $UPSGRAPH::rrdfile = ""; $UPSGRAPH::outdir = ""; $UPSGRAPH::community = "public"; $UPSGRAPH::step = 60; +$UPSGRAPH::keep = (370*24*60*60)/$UPSGRAPH::step; @UPSGRAPH::fields = (); $UPSGRAPH::vars = {}; @@ -22,12 +25,37 @@ my $rrdfile = $UPSGRAPH::rrdfile; my $outdir = $UPSGRAPH::outdir; my $community = $UPSGRAPH::community; my $step = $UPSGRAPH::step; +my $keep = $UPSGRAPH::keep; my @fields = @UPSGRAPH::fields; my $vars = $UPSGRAPH::vars; +sub rrdcreate(@) { + my $rrdfile = shift; + my $start = shift; + + my @cmd = ("${rrdfile}", "--step=${step}"); + + if (defined($start)) { + push @cmd, "--start=${start}"; + } + + foreach my $var (@fields) { + push @cmd, "DS:${var}:GAUGE:600:" . + $vars->{$var}->{'min'} . ":" . + $vars->{$var}->{'max'} . " "; + } + push @cmd, "RRA:AVERAGE:0.5:1:${keep}"; + + RRDs::create(@cmd); + if (RRDs::error) { + print "Error while creating: " . RRDs::error . "\n"; + exit 1; + } +} + if ($> == 0) { if (@ARGV != 2) { - print STDERR "Running as root, please provide UID as 4th argument!\n"; + print STDERR "Running as root, please provide UID as 2th argument!\n"; exit(1); } @@ -36,16 +64,68 @@ if ($> == 0) { } if (! -e "${rrdfile}") { - my $cmd = "rrdtool create \"${rrdfile}\" "; - foreach my $var (@fields) { - $cmd .= "DS:${var}:GAUGE:600:" . - $vars->{$var}->{'min'} . ":" . - $vars->{$var}->{'max'} . " "; + print "Creating ${rrdfile}...\n"; + rrdcreate("${rrdfile}"); +} + +my $rrdinfo = RRDs::info("${rrdfile}"); +if (RRDs::error) { + print "Error while getting info: " . RRDs::error . "\n"; + exit 1; +} + +if ($rrdinfo->{'rra[0].rows'} != $keep) { + print "Resizing ${rrdfile} from " . $rrdinfo->{'rra[0].rows'} . + " to ${keep} samples.\n"; + + (my $start, my $ostep, my $names, my $data) = + RRDs::fetch("${rrdfile}", + "-s " . (time() - ($rrdinfo->{'rra[0].rows'} * $rrdinfo->{'step'})), + "AVERAGE"); + + if (RRDs::error) { + print "Error while fetching data: " . RRDs::error . "\n"; + exit 1; } - $cmd .= "RRA:AVERAGE:0.5:1:10080 --step ${step}"; - print "Creating ${rrdfile}...\n"; - print `${cmd}`; + rrdcreate("${rrdfile}.new", (${start}-${ostep})); + + print "Preserving data since " . localtime($start) . "\n"; + + my $pos = $start; + foreach my $line (@$data) { + my $vline = "${pos}"; + + foreach my $val (@$line) { + $val = 'U' if (!defined($val)); + $vline .= ":${val}"; + } + RRDs::update("${rrdfile}.new", $vline) or die "Can't insert data\n"; + + if (RRDs::error) { + print "Error while updating: " . RRDs::error . "\n"; + exit 1; + } + $pos += $ostep; + + if ((($pos-$start)/$ostep) == $#$data) { + last; + } + } + + rename("${rrdfile}", "${rrdfile}.old") or die "Can't rename old file: $!\n"; + rename("${rrdfile}.new", "${rrdfile}") or die "Can't rename new file: $!\n"; + + $rrdinfo = RRDs::info("${rrdfile}"); + if (RRDs::error) { + print "Error while getting info: " . RRDs::error . "\n"; + exit 1; + } + + if ($rrdinfo->{'rra[0].rows'} != $keep) { + print "Failed!\n"; + exit 1; + } } my $child = fork(); @@ -76,15 +156,17 @@ while(1) { $session->close; - my $cmd = "rrdtool update \"${rrdfile}\" \"N"; + my $vline = "N"; foreach my $var (@fields) { if (!(defined($vars->{$var}->{'value'}))) { $vars->{$var}->{'value'} = 'U'; } - $cmd .= ":" . $vars->{$var}->{'value'}; + $vline .= ":" . $vars->{$var}->{'value'}; + } + RRDs::update("${rrdfile}", $vline); + if (RRDs::error) { + print "Error while updating: " . RRDs::error . "\n"; } - $cmd .= "\""; - print `${cmd}`; open(HTML, ">${outdir}/index.html.new"); @@ -92,17 +174,62 @@ while(1) { print HTML ''; foreach my $var (@fields) { - my $graphdef = "-t \"" . $vars->{$var}->{'name'} . "\" \"DEF:${var}=${rrdfile}:${var}:AVERAGE\" \"LINE1:${var}#FF0000\""; - my $cmd = "rrdtool graph \"${outdir}/${var}.png.new\" -w 720 ${graphdef}"; - my $size = `$cmd`; - rename("${outdir}/${var}.png.new", "${outdir}/${var}.png"); - (my $width, my $height) = split(/x/,$size); + my @graphdef = ("-t", $vars->{$var}->{'name'}, "DEF:${var}=${rrdfile}:${var}:AVERAGE", "LINE1:${var}#FF0000"); + (my $averages, my $width, my $height) = + RRDs::graph("${outdir}/${var}.png.new", + "-w", "720", @graphdef); + + if (RRDs::error) { + print "Error while graphing: " . RRDs::error . "\n"; + } else { + rename("${outdir}/${var}.png.new", "${outdir}/${var}.png"); + } + + print HTML ""; + + open (HTML2, ">${outdir}/${var}.html.new"); + print HTML2 "" . $vars->{$var}->{'name'} . ""; + print HTML2 ''; + + ($averages, $width, $height) = + RRDs::graph("${outdir}/${var}.long.png.new", + "-w", "1008", @graphdef); + + if (RRDs::error) { + print "Error while graphing: " . RRDs::error . "\n"; + } else { + rename("${outdir}/${var}.long.png.new", "${outdir}/${var}.long.png"); + } + + print HTML2 "
"; + + ($averages, $width, $height) = + RRDs::graph("${outdir}/${var}.week.png.new", + "-w", "1008", "-e", "now", "-s", "end-1w", @graphdef); + + if (RRDs::error) { + print "Error while graphing: " . RRDs::error . "\n"; + } else { + rename("${outdir}/${var}.week.png.new", "${outdir}/${var}.week.png"); + } + + print HTML2 "
"; + + ($averages, $width, $height) = + RRDs::graph("${outdir}/${var}.year.png.new", + "-w", "1008", "-e", "now", "-s", "end-1y", @graphdef); + + if (RRDs::error) { + print "Error while graphing: " . RRDs::error . "\n"; + } else { + rename("${outdir}/${var}.year.png.new", "${outdir}/${var}.year.png"); + } - my $cmd2 = "rrdtool graph \"${outdir}/${var}.long.png.new\" -w 1008 -e now -s end-1w ${graphdef}"; - my $size2 = `$cmd2`; - rename("${outdir}/${var}.long.png.new", "${outdir}/${var}.long.png"); + print HTML2 "
"; - print HTML ""; + print HTML2 "\n"; + close(HTML2); + rename("${outdir}/${var}.html.new", "${outdir}/${var}.html"); } print HTML "\n"; -- 2.39.5