fix typo in comment

[fhem-stuff] / culfw / culfw-asksin-fix.diff

diff --git a/culfw/culfw-asksin-fix.diff b/culfw/culfw-asksin-fix.diff
index 07a587f31afb0887c98906c901a196c1c0908822..38621e77dcd0f3bc08bcbcd80acb138fbfd0142b 100644 (file)
--- a/culfw/culfw-asksin-fix.diff
+++ b/culfw/culfw-asksin-fix.diff
@@ -2,8 +2,13 @@ Index: clib/rf_asksin.c
 ===================================================================
 --- clib/rf_asksin.c   (revision 373)
 +++ clib/rf_asksin.c   (working copy)
-@@ -11,13 +11,13 @@
+@@ -9,15 +9,18 @@
  
+ #include "rf_asksin.h"
+ 
++//we receive a new byte approximately every 8 ms...
++#define RX_TIMEOUT_MS 10
++
  uint8_t asksin_on = 0;
  
 -const uint8_t PROGMEM ASKSIN_CFG[50] = {
@@ -19,12 +24,12 @@ Index: clib/rf_asksin.c
       0x0B, 0x06,
       0x0D, 0x21,
       0x0E, 0x65,
-@@ -26,18 +26,21 @@
+@@ -26,18 +29,22 @@
       0x11, 0x93,
       0x12, 0x03,
       0x15, 0x34,
 -     0x17, 0x30, // always go into IDLE
-+     0x17, 0x3F, // always go into RX after TX, CCA, ELV uses 0x03
++     0x17, 0x3F, // always go into RX, CCA; ELV uses 0x03
       0x18, 0x18,
       0x19, 0x16,
       0x1B, 0x43,
@@ -39,12 +44,13 @@ Index: clib/rf_asksin.c
 +     0x3e, 0xc3
  };
  
-+static inline uint8_t read_cc1100_rxbytes();
++static inline uint8_t read_cc1100_rxbytes(void);
++static void rf_asksin_reset_rx(void);
 +
  void
  rf_asksin_init(void)
  {
-@@ -56,20 +59,30 @@
+@@ -56,20 +63,44 @@
    my_delay_us(100);
  
    // load configuration
@@ -67,7 +73,8 @@ Index: clib/rf_asksin.c
  }
  
 +// Workaround for CC1101 Errata 3
-+static inline uint8_t read_cc1100_rxbytes()
++static inline uint8_t
++read_cc1100_rxbytes(void)
 +{
 +  uint8_t rxbytes, rxbytes2;
 +  
@@ -77,15 +84,29 @@ Index: clib/rf_asksin.c
 +
 +  return rxbytes;
 +}
++
++static void
++rf_asksin_reset_rx(void)
++{
++  ccStrobe( CC1100_SFRX  );
++  ccStrobe( CC1100_SIDLE );
++  ccStrobe( CC1100_SNOP  );
++
++  while (read_cc1100_rxbytes() & 0x7f)
++    cc1100_readReg(CC1100_RXFIFO);
++
++  ccStrobe( CC1100_SRX   );
++}
 +
  void
  rf_asksin_task(void)
  {
-@@ -77,15 +90,27 @@
+@@ -77,18 +108,51 @@
    uint8_t dec[MAX_ASKSIN_MSG];
    uint8_t rssi;
    uint8_t l;
 +  uint8_t rxfifo_cnt;
++  uint16_t timeout;
  
    if(!asksin_on)
      return;
@@ -102,21 +123,46 @@ Index: clib/rf_asksin.c
 +    rxfifo_cnt &= 0x7f;
 +
      enc[0] = cc1100_readReg( CC1100_RXFIFO ) & 0x7f; // read len
++    rxfifo_cnt--;
  
-+    while ((enc[0] + 2) < (rxfifo_cnt - 1)) { // Wait for more data
-+      my_delay_ms(1);
-+      rxfifo_cnt = (read_cc1100_rxbytes() & 0x7f) + 1;
+-    if (enc[0]>=MAX_ASKSIN_MSG)
+-         enc[0] = MAX_ASKSIN_MSG-1;
+-    
++    if (enc[0] >= MAX_ASKSIN_MSG) {
++      // Something went horribly wrong, out of sync?
++      rf_asksin_reset_rx();
++      return;
++    }
++
++    if ((enc[0] + 2) > rxfifo_cnt) {
++      timeout = RX_TIMEOUT_MS * ((enc[0] + 2) - rxfifo_cnt);
++      while (timeout-- && ((enc[0] + 2) > rxfifo_cnt)) { // Wait for more data
++        my_delay_ms(1);
++        rxfifo_cnt = read_cc1100_rxbytes();
++
++        if (rxfifo_cnt & 0x80) { // Overflow
++          rf_asksin_reset_rx();
++          return;
++      }
++ 
++        rxfifo_cnt &= 0x7f;
++      }
++
++      if (!timeout) {
++        // Not enough data received, out of sync?
++        rf_asksin_reset_rx();
++        return;
++      }
 +    }
 +
-     if (enc[0]>=MAX_ASKSIN_MSG)
-          enc[0] = MAX_ASKSIN_MSG-1;
+     CC1100_ASSERT;
+     cc1100_sendbyte( CC1100_READ_BURST | CC1100_RXFIFO );
      
-@@ -97,13 +122,12 @@
+@@ -97,14 +161,19 @@
      }
      
      rssi = cc1100_sendbyte( 0 );
 -    
-+    l = cc1100_sendbyte( 0 );
 +
      CC1100_DEASSERT;
  
@@ -124,12 +170,20 @@ Index: clib/rf_asksin.c
 -    ccStrobe( CC1100_SIDLE );
 -    ccStrobe( CC1100_SNOP  );
 -    ccStrobe( CC1100_SRX   );
++    // We must not read the last byte from the RX fifo while RX is in progress (Errata 1)
++    while (((read_cc1100_rxbytes() & 0x7f) == 1) && (cc1100_readReg(CC1100_PKTSTATUS) & (1 << 3))) {
++      my_delay_ms(1);
++    }
+ 
++    l = cc1100_readReg(CC1100_RXFIFO);
++
 +    if (!(l & 0x80)) // CRC not ok
 +      continue;
- 
++
      dec[0] = enc[0];
      dec[1] = (~enc[1]) ^ 0x89;
-@@ -113,7 +137,6 @@
+     
+@@ -113,7 +182,6 @@
      
      dec[l] = enc[l] ^ dec[2];
      
@@ -137,7 +191,7 @@ Index: clib/rf_asksin.c
      if (tx_report & REP_BINTIME) {
        
        DC('a');
-@@ -131,26 +154,17 @@
+@@ -131,26 +199,17 @@
        
        DNL();
      }
@@ -173,7 +227,7 @@ Index: clib/rf_asksin.c
  }
  
  void
-@@ -173,20 +187,7 @@
+@@ -173,20 +232,7 @@
      my_delay_ms(3);             // 3ms: Found by trial and error
    }
  
@@ -194,7 +248,7 @@ Index: clib/rf_asksin.c
    enc[0] = dec[0];
    enc[1] = (~dec[1]) ^ 0x89;
  
-@@ -195,6 +196,15 @@
+@@ -195,6 +241,15 @@
    
    enc[l] = dec[l] ^ dec[2];
  
@@ -210,7 +264,7 @@ Index: clib/rf_asksin.c
    // send
    CC1100_ASSERT;
    cc1100_sendbyte(CC1100_WRITE_BURST | CC1100_TXFIFO);
-@@ -205,12 +215,17 @@
+@@ -205,12 +260,17 @@
  
    CC1100_DEASSERT;