]> git.zerfleddert.de Git - proxmark3-svn/commitdiff
Merge branch 'master' of https://github.com/Proxmark/proxmark3
authoriceman1001 <iceman@iuse.se>
Tue, 10 Feb 2015 20:53:16 +0000 (21:53 +0100)
committericeman1001 <iceman@iuse.se>
Tue, 10 Feb 2015 20:53:16 +0000 (21:53 +0100)
Conflicts:
armsrc/appmain.c
armsrc/iclass.c

17 files changed:
armsrc/BigBuf.c
armsrc/BigBuf.h
armsrc/appmain.c
armsrc/apps.h
armsrc/hitag2.c
armsrc/iclass.c
armsrc/iso14443.c
armsrc/iso14443a.c
armsrc/iso14443a.h
armsrc/mifarecmd.c
armsrc/mifaresniff.c
armsrc/util.c
client/cmdhf.c
client/cmdhf14b.c
client/cmdlft55xx.c
client/ui.c
driver/77-mm-usb-device-blacklist.rules

index 7f56e9a014290c1a4b60cbfbacfc49bc9b8da02d..0c666bce87992229fecaa2dafaeba508efb6035a 100644 (file)
@@ -26,10 +26,9 @@ static uint16_t BigBuf_hi = BIGBUF_SIZE;
 // pointer to the emulator memory.
 static uint8_t *emulator_memory = NULL;
 
-// trace related global variables
-// (only one left). ToDo: make this static as well?
-uint16_t traceLen = 0;
-
+// trace related variables
+static uint16_t traceLen = 0;
+int tracing = 1; //Last global one.. todo static?
 
 // get the address of BigBuf
 uint8_t *BigBuf_get_addr(void)
@@ -95,3 +94,133 @@ uint16_t BigBuf_max_traceLen(void)
 {
        return BigBuf_hi;
 }
+
+void clear_trace() {
+       uint8_t *trace = BigBuf_get_addr();
+       uint16_t max_traceLen = BigBuf_max_traceLen();
+       memset(trace, 0x44, max_traceLen);
+       traceLen = 0;
+}
+
+void set_tracing(bool enable) {
+       tracing = enable;
+}
+
+/**
+ * Get the number of bytes traced
+ * @return
+ */
+uint16_t BigBuf_get_traceLen(void)
+{
+       return traceLen;
+}
+
+/**
+  This is a function to store traces. All protocols can use this generic tracer-function.
+  The traces produced by calling this function can be fetched on the client-side
+  by 'hf list raw', alternatively 'hf list <proto>' for protocol-specific
+  annotation of commands/responses.
+
+**/
+bool RAMFUNC LogTrace(const uint8_t *btBytes, uint16_t iLen, uint32_t timestamp_start, uint32_t timestamp_end, uint8_t *parity, bool readerToTag)
+{
+       if (!tracing) return FALSE;
+
+       uint8_t *trace = BigBuf_get_addr();
+
+       uint16_t num_paritybytes = (iLen-1)/8 + 1;      // number of valid paritybytes in *parity
+       uint16_t duration = timestamp_end - timestamp_start;
+
+       // Return when trace is full
+       uint16_t max_traceLen = BigBuf_max_traceLen();
+
+       if (traceLen + sizeof(iLen) + sizeof(timestamp_start) + sizeof(duration) + num_paritybytes + iLen >= max_traceLen) {
+               tracing = FALSE;        // don't trace any more
+               return FALSE;
+       }
+       // Traceformat:
+       // 32 bits timestamp (little endian)
+       // 16 bits duration (little endian)
+       // 16 bits data length (little endian, Highest Bit used as readerToTag flag)
+       // y Bytes data
+       // x Bytes parity (one byte per 8 bytes data)
+
+       // timestamp (start)
+       trace[traceLen++] = ((timestamp_start >> 0) & 0xff);
+       trace[traceLen++] = ((timestamp_start >> 8) & 0xff);
+       trace[traceLen++] = ((timestamp_start >> 16) & 0xff);
+       trace[traceLen++] = ((timestamp_start >> 24) & 0xff);
+
+       // duration
+       trace[traceLen++] = ((duration >> 0) & 0xff);
+       trace[traceLen++] = ((duration >> 8) & 0xff);
+
+       // data length
+       trace[traceLen++] = ((iLen >> 0) & 0xff);
+       trace[traceLen++] = ((iLen >> 8) & 0xff);
+
+       // readerToTag flag
+       if (!readerToTag) {
+               trace[traceLen - 1] |= 0x80;
+       }
+
+       // data bytes
+       if (btBytes != NULL && iLen != 0) {
+               memcpy(trace + traceLen, btBytes, iLen);
+       }
+       traceLen += iLen;
+
+       // parity bytes
+       if (parity != NULL && iLen != 0) {
+               memcpy(trace + traceLen, parity, num_paritybytes);
+       }
+       traceLen += num_paritybytes;
+
+       if(traceLen +4 < max_traceLen)
+       {       //If it hadn't been cleared, for whatever reason..
+               memset(trace+traceLen,0x44, 4);
+       }
+
+       return TRUE;
+}
+int LogTraceHitag(const uint8_t * btBytes, int iBits, int iSamples, uint32_t dwParity, int readerToTag)
+{
+       /**
+         Todo, rewrite the logger to use the generic functionality instead. It should be noted, however,
+         that this logger takes number of bits as argument, not number of bytes.
+         **/
+
+       if (!tracing) return FALSE;
+
+       uint8_t *trace = BigBuf_get_addr();
+       uint16_t iLen = nbytes(iBits);
+       // Return when trace is full
+       if (traceLen + sizeof(rsamples) + sizeof(dwParity) + sizeof(iBits) + iLen > BigBuf_max_traceLen()) return FALSE;
+
+       //Hitag traces appear to use this traceformat:
+       // 32 bits timestamp (little endian,Highest Bit used as readerToTag flag)
+       // 32 bits parity
+       // 8 bits size (number of bits in the trace entry, not number of bytes)
+       // y Bytes data
+
+       rsamples += iSamples;
+       trace[traceLen++] = ((rsamples >> 0) & 0xff);
+       trace[traceLen++] = ((rsamples >> 8) & 0xff);
+       trace[traceLen++] = ((rsamples >> 16) & 0xff);
+       trace[traceLen++] = ((rsamples >> 24) & 0xff);
+
+       if (!readerToTag) {
+               trace[traceLen - 1] |= 0x80;
+       }
+
+       trace[traceLen++] = ((dwParity >> 0) & 0xff);
+       trace[traceLen++] = ((dwParity >> 8) & 0xff);
+       trace[traceLen++] = ((dwParity >> 16) & 0xff);
+       trace[traceLen++] = ((dwParity >> 24) & 0xff);
+       trace[traceLen++] = iBits;
+
+       memcpy(trace + traceLen, btBytes, iLen);
+       traceLen += iLen;
+
+       return TRUE;
+}
index 9d89a4f0f4af55a78776ec575258de2f072aa3d1..be558979ad4bd719eb1cc2c6548fa049b4cd9160 100644 (file)
@@ -29,6 +29,9 @@ extern uint8_t *BigBuf_malloc(uint16_t);
 extern void BigBuf_free(void);
 extern void BigBuf_free_keep_EM(void);
 
-extern uint16_t traceLen;
-
+uint16_t BigBuf_get_traceLen(void);
+void clear_trace();
+void set_tracing(bool enable);
+bool RAMFUNC LogTrace(const uint8_t *btBytes, uint16_t iLen, uint32_t timestamp_start, uint32_t timestamp_end, uint8_t *parity, bool readerToTag);
+int LogTraceHitag(const uint8_t * btBytes, int iBits, int iSamples, uint32_t dwParity, int bReader);
 #endif /* __BIGBUF_H */
index 31e17e880a5c12eed13aaa5d2d569090ba360654..f19840b8e13edfd9b6df80ceaa06cff2023b803d 100644 (file)
@@ -23,7 +23,7 @@
 #include "legicrf.h"
 #include "../include/hitag2.h"
 #include "lfsampling.h"
-
+#include "BigBuf.h"
 #ifdef WITH_LCD
  #include "LCD.h"
 #endif
@@ -936,10 +936,10 @@ void UsbPacketReceived(uint8_t *packet, int len)
                        uint8_t *BigBuf = BigBuf_get_addr();
                        for(size_t i=0; i<c->arg[1]; i += USB_CMD_DATA_SIZE) {
                                size_t len = MIN((c->arg[1] - i),USB_CMD_DATA_SIZE);
-                               cmd_send(CMD_DOWNLOADED_RAW_ADC_SAMPLES_125K,i,len,traceLen,BigBuf+c->arg[0]+i,len);
+                               cmd_send(CMD_DOWNLOADED_RAW_ADC_SAMPLES_125K,i,len,BigBuf_get_traceLen(),BigBuf+c->arg[0]+i,len);
                        }
                        // Trigger a finish downloading signal with an ACK frame
-                       cmd_send(CMD_ACK,1,0,traceLen,getSamplingConfig(),sizeof(sample_config));
+                       cmd_send(CMD_ACK,1,0,BigBuf_get_traceLen(),getSamplingConfig(),sizeof(sample_config));
                        LED_B_OFF();
                        break;
 
@@ -1015,7 +1015,7 @@ void UsbPacketReceived(uint8_t *packet, int len)
 void  __attribute__((noreturn)) AppMain(void)
 {
        SpinDelay(100);
-
+       clear_trace();
        if(common_area.magic != COMMON_AREA_MAGIC || common_area.version != 1) {
                /* Initialize common area */
                memset(&common_area, 0, sizeof(common_area));
index 22ec97b86843feeabb0df7baf45d5e401e197756..dc8a9c935f29a569f34de3877e010e7fdcba19ef 100644 (file)
@@ -157,8 +157,7 @@ void ReaderIso14443a(UsbCommand * c);
 bool RAMFUNC LogTrace(const uint8_t *btBytes, uint16_t len, uint32_t timestamp_start, uint32_t timestamp_end, uint8_t *parity, bool readerToTag);
 void GetParity(const uint8_t *pbtCmd, uint16_t len, uint8_t *parity);
 void iso14a_set_trigger(bool enable);
-void iso14a_clear_trace();
-void iso14a_set_tracing(bool enable);
+
 void RAMFUNC SniffMifare(uint8_t param);
 
 /// epa.h
index f9005c7176bcfe412526dca28e5a9bc221b89598..2d0645658c2dc2d2b68cf35f8f295308cf364925 100644 (file)
@@ -21,6 +21,7 @@
 #include "util.h"
 #include "../include/hitag2.h"
 #include "string.h"
+#include "BigBuf.h"
 
 static bool bQuiet;
 
@@ -30,32 +31,6 @@ static bool bPwd;
 static bool bSuccessful;
 
 
-static int LogTraceHitag(const uint8_t * btBytes, int iBits, int iSamples, uint32_t dwParity, int bReader)
-{
-  static uint16_t traceLen = 0;
-  uint8_t *trace = BigBuf_get_addr();
-
-  // Return when trace is full
-  if (traceLen + sizeof(rsamples) + sizeof(dwParity) + sizeof(iBits) + nbytes(iBits) > BigBuf_max_traceLen()) return FALSE;
-  
-  // Trace the random, i'm curious
-  rsamples += iSamples;
-  trace[traceLen++] = ((rsamples >> 0) & 0xff);
-  trace[traceLen++] = ((rsamples >> 8) & 0xff);
-  trace[traceLen++] = ((rsamples >> 16) & 0xff);
-  trace[traceLen++] = ((rsamples >> 24) & 0xff);
-  if (!bReader) {
-    trace[traceLen - 1] |= 0x80;
-  }
-  trace[traceLen++] = ((dwParity >> 0) & 0xff);
-  trace[traceLen++] = ((dwParity >> 8) & 0xff);
-  trace[traceLen++] = ((dwParity >> 16) & 0xff);
-  trace[traceLen++] = ((dwParity >> 24) & 0xff);
-  trace[traceLen++] = iBits;
-  memcpy(trace + traceLen, btBytes, nbytes(iBits));
-  traceLen += nbytes(iBits);
-  return TRUE;
-}
 
 struct hitag2_tag {
        uint32_t uid;
@@ -742,8 +717,8 @@ void SnoopHitag(uint32_t type) {
        memset(auth_table, 0x00, AUTH_TABLE_LENGTH);
 
        // Clean up trace and prepare it for storing frames
-       iso14a_set_tracing(TRUE);
-       iso14a_clear_trace();
+       set_tracing(TRUE);
+       clear_trace();
        
        DbpString("Starting Hitag2 snoop");
        LED_D_ON();
@@ -955,8 +930,8 @@ void SimulateHitagTag(bool tag_mem_supplied, byte_t* data) {
        memset(auth_table, 0x00, AUTH_TABLE_LENGTH);
 
        // Clean up trace and prepare it for storing frames
-       iso14a_set_tracing(TRUE);
-       iso14a_clear_trace();
+       set_tracing(TRUE);
+       clear_trace();
 
        DbpString("Starting Hitag2 simulation");
        LED_D_ON();
@@ -1142,8 +1117,8 @@ void ReaderHitag(hitag_function htf, hitag_data* htd) {
        bSuccessful = false;
   
        // Clean up trace and prepare it for storing frames
-       iso14a_set_tracing(TRUE);
-       iso14a_clear_trace();
+       set_tracing(TRUE);
+       clear_trace();
 
        DbpString("Starting Hitag reader family");
 
index c0edc1e08db6156c57060a94961efcf93f8d69d6..67130804910a13428772e31189182d3874d1c7af 100644 (file)
@@ -654,9 +654,8 @@ void RAMFUNC SnoopIClass(void)
     // The DMA buffer, used to stream samples from the FPGA
     uint8_t *dmaBuf = BigBuf_malloc(DMA_BUFFER_SIZE);
  
-    // reset traceLen to 0
-    iso14a_set_tracing(TRUE);
-    iso14a_clear_trace();
+       set_tracing(TRUE);
+       clear_trace();
     iso14a_set_trigger(FALSE);
 
     int lastRxCounter;
@@ -807,12 +806,12 @@ void RAMFUNC SnoopIClass(void)
     DbpString("COMMAND FINISHED");
 
     Dbprintf("%x %x %x", maxBehindBy, Uart.state, Uart.byteCnt);
-    Dbprintf("%x %x %x", Uart.byteCntMax, traceLen, (int)Uart.output[0]);
+       Dbprintf("%x %x %x", Uart.byteCntMax, BigBuf_get_traceLen(), (int)Uart.output[0]);
 
 done:
     AT91C_BASE_PDC_SSC->PDC_PTCR = AT91C_PDC_RXTDIS;
     Dbprintf("%x %x %x", maxBehindBy, Uart.state, Uart.byteCnt);
-    Dbprintf("%x %x %x", Uart.byteCntMax, traceLen, (int)Uart.output[0]);
+       Dbprintf("%x %x %x", Uart.byteCntMax, BigBuf_get_traceLen(), (int)Uart.output[0]);
     LED_A_OFF();
     LED_B_OFF();
     LED_C_OFF();
@@ -989,8 +988,8 @@ void SimulateIClass(uint32_t arg0, uint32_t arg1, uint32_t arg2, uint8_t *datain
        FpgaDownloadAndGo(FPGA_BITSTREAM_HF);
 
        // Enable and clear the trace
-       iso14a_set_tracing(TRUE);
-       iso14a_clear_trace();
+       set_tracing(TRUE);
+       clear_trace();
 
        uint8_t csn_crc[] = { 0x03, 0x1f, 0xec, 0x8a, 0xf7, 0xff, 0x12, 0xe0, 0x00, 0x00 };
        if(simType == 0) {
@@ -1490,8 +1489,8 @@ void setupIclassReader()
 {
     FpgaDownloadAndGo(FPGA_BITSTREAM_HF);
     // Reset trace buffer
-    iso14a_set_tracing(TRUE);
-    iso14a_clear_trace();
+       set_tracing(TRUE);
+       clear_trace();
 
     // Setup SSC
     FpgaSetupSsc();
@@ -1587,14 +1586,14 @@ void ReaderIClass(uint8_t arg0) {
     int read_status= 0;
     bool abort_after_read = arg0 & FLAG_ICLASS_READER_ONLY_ONCE;
        bool get_cc = arg0 & FLAG_ICLASS_READER_GET_CC;
-
+       set_tracing(TRUE);
     setupIclassReader();
 
     size_t datasize = 0;
     while(!BUTTON_PRESS())
     {
 
-               if(traceLen > BigBuf_max_traceLen()) {
+               if(!tracing) {
                        DbpString("Trace full");
                        break;
                }
@@ -1660,13 +1659,13 @@ void ReaderIClass_Replay(uint8_t arg0, uint8_t *MAC) {
        uint8_t resp[ICLASS_BUFFER_SIZE];
        
     setupIclassReader();
-
+       set_tracing(TRUE);
 
        while(!BUTTON_PRESS()) {
        
                WDT_HIT();
 
-               if(traceLen > BigBuf_max_traceLen()) {
+               if(!tracing) {
                        DbpString("Trace full");
                        break;
                }
index 48a32b1024db8ef59e024421c938715a0b4be246..d570bf2d000c6cc97e37f8dc9464f9fa0e09cad3 100644 (file)
 
 //static void GetSamplesFor14443(int weTx, int n);
 
-#define DEMOD_TRACE_SIZE 4096
+/*#define DEMOD_TRACE_SIZE 4096
 #define READER_TAG_BUFFER_SIZE 2048
 #define TAG_READER_BUFFER_SIZE 2048
 #define DEMOD_DMA_BUFFER_SIZE 1024
-
+*/
 //=============================================================================
 // An ISO 14443 Type B tag. We listen for commands from the reader, using
 // a UART kind of thing that's implemented in software. When we get a
 //-----------------------------------------------------------------------------
 static void CodeIso14443bAsTag(const uint8_t *cmd, int len)
 {
-    int i;
-
-    ToSendReset();
-
-    // Transmit a burst of ones, as the initial thing that lets the
-    // reader get phase sync. This (TR1) must be > 80/fs, per spec,
-    // but tag that I've tried (a Paypass) exceeds that by a fair bit,
-    // so I will too.
-    for(i = 0; i < 20; i++) {
-        ToSendStuffBit(1);
-        ToSendStuffBit(1);
-        ToSendStuffBit(1);
-        ToSendStuffBit(1);
-    }
-
-    // Send SOF.
-    for(i = 0; i < 10; i++) {
-        ToSendStuffBit(0);
-        ToSendStuffBit(0);
-        ToSendStuffBit(0);
-        ToSendStuffBit(0);
-    }
-    for(i = 0; i < 2; i++) {
-        ToSendStuffBit(1);
-        ToSendStuffBit(1);
-        ToSendStuffBit(1);
-        ToSendStuffBit(1);
-    }
-
-    for(i = 0; i < len; i++) {
-        int j;
-        uint8_t b = cmd[i];
-
-        // Start bit
-        ToSendStuffBit(0);
-        ToSendStuffBit(0);
-        ToSendStuffBit(0);
-        ToSendStuffBit(0);
-
-        // Data bits
-        for(j = 0; j < 8; j++) {
-            if(b & 1) {
-                ToSendStuffBit(1);
-                ToSendStuffBit(1);
-                ToSendStuffBit(1);
-                ToSendStuffBit(1);
-            } else {
-                ToSendStuffBit(0);
-                ToSendStuffBit(0);
-                ToSendStuffBit(0);
-                ToSendStuffBit(0);
-            }
-            b >>= 1;
-        }
-
-        // Stop bit
-        ToSendStuffBit(1);
-        ToSendStuffBit(1);
-        ToSendStuffBit(1);
-        ToSendStuffBit(1);
-    }
-
-    // Send SOF.
-    for(i = 0; i < 10; i++) {
-        ToSendStuffBit(0);
-        ToSendStuffBit(0);
-        ToSendStuffBit(0);
-        ToSendStuffBit(0);
-    }
-    for(i = 0; i < 10; i++) {
-        ToSendStuffBit(1);
-        ToSendStuffBit(1);
-        ToSendStuffBit(1);
-        ToSendStuffBit(1);
-    }
-
-    // Convert from last byte pos to length
-    ToSendMax++;
-
-    // Add a few more for slop
-    ToSendMax += 2;
+       int i;
+
+       ToSendReset();
+
+       // Transmit a burst of ones, as the initial thing that lets the
+       // reader get phase sync. This (TR1) must be > 80/fs, per spec,
+       // but tag that I've tried (a Paypass) exceeds that by a fair bit,
+       // so I will too.
+       for(i = 0; i < 20; i++) {
+               ToSendStuffBit(1);
+               ToSendStuffBit(1);
+               ToSendStuffBit(1);
+               ToSendStuffBit(1);
+       }
+
+       // Send SOF.
+       for(i = 0; i < 10; i++) {
+               ToSendStuffBit(0);
+               ToSendStuffBit(0);
+               ToSendStuffBit(0);
+               ToSendStuffBit(0);
+       }
+       for(i = 0; i < 2; i++) {
+               ToSendStuffBit(1);
+               ToSendStuffBit(1);
+               ToSendStuffBit(1);
+               ToSendStuffBit(1);
+       }
+
+       for(i = 0; i < len; i++) {
+               int j;
+               uint8_t b = cmd[i];
+
+               // Start bit
+               ToSendStuffBit(0);
+               ToSendStuffBit(0);
+               ToSendStuffBit(0);
+               ToSendStuffBit(0);
+
+               // Data bits
+               for(j = 0; j < 8; j++) {
+                       if(b & 1) {
+                               ToSendStuffBit(1);
+                               ToSendStuffBit(1);
+                               ToSendStuffBit(1);
+                               ToSendStuffBit(1);
+                       } else {
+                               ToSendStuffBit(0);
+                               ToSendStuffBit(0);
+                               ToSendStuffBit(0);
+                               ToSendStuffBit(0);
+                       }
+                       b >>= 1;
+               }
+
+               // Stop bit
+               ToSendStuffBit(1);
+               ToSendStuffBit(1);
+               ToSendStuffBit(1);
+               ToSendStuffBit(1);
+       }
+
+       // Send SOF.
+       for(i = 0; i < 10; i++) {
+               ToSendStuffBit(0);
+               ToSendStuffBit(0);
+               ToSendStuffBit(0);
+               ToSendStuffBit(0);
+       }
+       for(i = 0; i < 10; i++) {
+               ToSendStuffBit(1);
+               ToSendStuffBit(1);
+               ToSendStuffBit(1);
+               ToSendStuffBit(1);
+       }
+
+       // Convert from last byte pos to length
+       ToSendMax++;
+
+       // Add a few more for slop
+       ToSendMax += 2;
 }
 
 //-----------------------------------------------------------------------------
@@ -127,19 +127,19 @@ static void CodeIso14443bAsTag(const uint8_t *cmd, int len)
 // variables.
 //-----------------------------------------------------------------------------
 static struct {
-    enum {
-        STATE_UNSYNCD,
-        STATE_GOT_FALLING_EDGE_OF_SOF,
-        STATE_AWAITING_START_BIT,
-        STATE_RECEIVING_DATA,
-        STATE_ERROR_WAIT
-    }       state;
-    uint16_t    shiftReg;
-    int     bitCnt;
-    int     byteCnt;
-    int     byteCntMax;
-    int     posCnt;
-    uint8_t   *output;
+       enum {
+               STATE_UNSYNCD,
+               STATE_GOT_FALLING_EDGE_OF_SOF,
+               STATE_AWAITING_START_BIT,
+               STATE_RECEIVING_DATA,
+               STATE_ERROR_WAIT
+       }       state;
+       uint16_t    shiftReg;
+       int     bitCnt;
+       int     byteCnt;
+       int     byteCntMax;
+       int     posCnt;
+       uint8_t   *output;
 } Uart;
 
 /* Receive & handle a bit coming from the reader.
@@ -153,126 +153,126 @@ static struct {
  */
 static int Handle14443UartBit(int bit)
 {
-    switch(Uart.state) {
-        case STATE_UNSYNCD:
-               LED_A_OFF();
-            if(!bit) {
-                // we went low, so this could be the beginning
-                // of an SOF
-                Uart.state = STATE_GOT_FALLING_EDGE_OF_SOF;
-                Uart.posCnt = 0;
-                Uart.bitCnt = 0;
-            }
-            break;
-
-        case STATE_GOT_FALLING_EDGE_OF_SOF:
-            Uart.posCnt++;
-            if(Uart.posCnt == 2) {
-                if(bit) {
-                    if(Uart.bitCnt >= 10) {
-                        // we've seen enough consecutive
-                        // zeros that it's a valid SOF
-                        Uart.posCnt = 0;
-                        Uart.byteCnt = 0;
-                        Uart.state = STATE_AWAITING_START_BIT;
-                        LED_A_ON(); // Indicate we got a valid SOF
-                    } else {
-                        // didn't stay down long enough
-                        // before going high, error
-                        Uart.state = STATE_ERROR_WAIT;
-                    }
-                } else {
-                    // do nothing, keep waiting
-                }
-                Uart.bitCnt++;
-            }
-            if(Uart.posCnt >= 4) Uart.posCnt = 0;
-            if(Uart.bitCnt > 14) {
-                // Give up if we see too many zeros without
-                // a one, too.
-                Uart.state = STATE_ERROR_WAIT;
-            }
-            break;
-
-        case STATE_AWAITING_START_BIT:
-            Uart.posCnt++;
-            if(bit) {
-                if(Uart.posCnt > 25) {
-                    // stayed high for too long between
-                    // characters, error
-                    Uart.state = STATE_ERROR_WAIT;
-                }
-            } else {
-                // falling edge, this starts the data byte
-                Uart.posCnt = 0;
-                Uart.bitCnt = 0;
-                Uart.shiftReg = 0;
-                Uart.state = STATE_RECEIVING_DATA;
-                LED_A_ON(); // Indicate we're receiving
-            }
-            break;
-
-        case STATE_RECEIVING_DATA:
-            Uart.posCnt++;
-            if(Uart.posCnt == 2) {
-                // time to sample a bit
-                Uart.shiftReg >>= 1;
-                if(bit) {
-                    Uart.shiftReg |= 0x200;
-                }
-                Uart.bitCnt++;
-            }
-            if(Uart.posCnt >= 4) {
-                Uart.posCnt = 0;
-            }
-            if(Uart.bitCnt == 10) {
-                if((Uart.shiftReg & 0x200) && !(Uart.shiftReg & 0x001))
-                {
-                    // this is a data byte, with correct
-                    // start and stop bits
-                    Uart.output[Uart.byteCnt] = (Uart.shiftReg >> 1) & 0xff;
-                    Uart.byteCnt++;
-
-                    if(Uart.byteCnt >= Uart.byteCntMax) {
-                        // Buffer overflowed, give up
-                        Uart.posCnt = 0;
-                        Uart.state = STATE_ERROR_WAIT;
-                    } else {
-                        // so get the next byte now
-                        Uart.posCnt = 0;
-                        Uart.state = STATE_AWAITING_START_BIT;
-                    }
-                } else if(Uart.shiftReg == 0x000) {
-                    // this is an EOF byte
-                       LED_A_OFF(); // Finished receiving
-                    return TRUE;
-                } else {
-                    // this is an error
-                    Uart.posCnt = 0;
-                    Uart.state = STATE_ERROR_WAIT;
-                }
-            }
-            break;
-
-        case STATE_ERROR_WAIT:
-            // We're all screwed up, so wait a little while
-            // for whatever went wrong to finish, and then
-            // start over.
-            Uart.posCnt++;
-            if(Uart.posCnt > 10) {
-                Uart.state = STATE_UNSYNCD;
-            }
-            break;
-
-        default:
-            Uart.state = STATE_UNSYNCD;
-            break;
-    }
-
-    // This row make the error blew circular buffer in hf 14b snoop
-    //if (Uart.state == STATE_ERROR_WAIT) LED_A_OFF(); // Error
-
-    return FALSE;
+       switch(Uart.state) {
+               case STATE_UNSYNCD:
+                       LED_A_OFF();
+                       if(!bit) {
+                               // we went low, so this could be the beginning
+                               // of an SOF
+                               Uart.state = STATE_GOT_FALLING_EDGE_OF_SOF;
+                               Uart.posCnt = 0;
+                               Uart.bitCnt = 0;
+                       }
+                       break;
+
+               case STATE_GOT_FALLING_EDGE_OF_SOF:
+                       Uart.posCnt++;
+                       if(Uart.posCnt == 2) {
+                               if(bit) {
+                                       if(Uart.bitCnt >= 10) {
+                                               // we've seen enough consecutive
+                                               // zeros that it's a valid SOF
+                                               Uart.posCnt = 0;
+                                               Uart.byteCnt = 0;
+                                               Uart.state = STATE_AWAITING_START_BIT;
+                                               LED_A_ON(); // Indicate we got a valid SOF
+                                       } else {
+                                               // didn't stay down long enough
+                                               // before going high, error
+                                               Uart.state = STATE_ERROR_WAIT;
+                                       }
+                               } else {
+                                       // do nothing, keep waiting
+                               }
+                               Uart.bitCnt++;
+                       }
+                       if(Uart.posCnt >= 4) Uart.posCnt = 0;
+                       if(Uart.bitCnt > 14) {
+                               // Give up if we see too many zeros without
+                               // a one, too.
+                               Uart.state = STATE_ERROR_WAIT;
+                       }
+                       break;
+
+               case STATE_AWAITING_START_BIT:
+                       Uart.posCnt++;
+                       if(bit) {
+                               if(Uart.posCnt > 25) {
+                                       // stayed high for too long between
+                                       // characters, error
+                                       Uart.state = STATE_ERROR_WAIT;
+                               }
+                       } else {
+                               // falling edge, this starts the data byte
+                               Uart.posCnt = 0;
+                               Uart.bitCnt = 0;
+                               Uart.shiftReg = 0;
+                               Uart.state = STATE_RECEIVING_DATA;
+                               LED_A_ON(); // Indicate we're receiving
+                       }
+                       break;
+
+               case STATE_RECEIVING_DATA:
+                       Uart.posCnt++;
+                       if(Uart.posCnt == 2) {
+                               // time to sample a bit
+                               Uart.shiftReg >>= 1;
+                               if(bit) {
+                                       Uart.shiftReg |= 0x200;
+                               }
+                               Uart.bitCnt++;
+                       }
+                       if(Uart.posCnt >= 4) {
+                               Uart.posCnt = 0;
+                       }
+                       if(Uart.bitCnt == 10) {
+                               if((Uart.shiftReg & 0x200) && !(Uart.shiftReg & 0x001))
+                               {
+                                       // this is a data byte, with correct
+                                       // start and stop bits
+                                       Uart.output[Uart.byteCnt] = (Uart.shiftReg >> 1) & 0xff;
+                                       Uart.byteCnt++;
+
+                                       if(Uart.byteCnt >= Uart.byteCntMax) {
+                                               // Buffer overflowed, give up
+                                               Uart.posCnt = 0;
+                                               Uart.state = STATE_ERROR_WAIT;
+                                       } else {
+                                               // so get the next byte now
+                                               Uart.posCnt = 0;
+                                               Uart.state = STATE_AWAITING_START_BIT;
+                                       }
+                               } else if(Uart.shiftReg == 0x000) {
+                                       // this is an EOF byte
+                                       LED_A_OFF(); // Finished receiving
+                                       return TRUE;
+                               } else {
+                                       // this is an error
+                                       Uart.posCnt = 0;
+                                       Uart.state = STATE_ERROR_WAIT;
+                               }
+                       }
+                       break;
+
+               case STATE_ERROR_WAIT:
+                       // We're all screwed up, so wait a little while
+                       // for whatever went wrong to finish, and then
+                       // start over.
+                       Uart.posCnt++;
+                       if(Uart.posCnt > 10) {
+                               Uart.state = STATE_UNSYNCD;
+                       }
+                       break;
+
+               default:
+                       Uart.state = STATE_UNSYNCD;
+                       break;
+       }
+
+       // This row make the error blew circular buffer in hf 14b snoop
+       //if (Uart.state == STATE_ERROR_WAIT) LED_A_OFF(); // Error
+
+       return FALSE;
 }
 
 //-----------------------------------------------------------------------------
@@ -286,42 +286,42 @@ static int Handle14443UartBit(int bit)
 //-----------------------------------------------------------------------------
 static int GetIso14443CommandFromReader(uint8_t *received, int *len, int maxLen)
 {
-    uint8_t mask;
-    int i, bit;
-
-    // Set FPGA mode to "simulated ISO 14443 tag", no modulation (listen
-    // only, since we are receiving, not transmitting).
-    // Signal field is off with the appropriate LED
-    LED_D_OFF();
-    FpgaWriteConfWord(FPGA_MAJOR_MODE_HF_SIMULATOR | FPGA_HF_SIMULATOR_NO_MODULATION);
-
-
-    // Now run a `software UART' on the stream of incoming samples.
-    Uart.output = received;
-    Uart.byteCntMax = maxLen;
-    Uart.state = STATE_UNSYNCD;
-
-    for(;;) {
-        WDT_HIT();
-
-        if(BUTTON_PRESS()) return FALSE;
-
-        if(AT91C_BASE_SSC->SSC_SR & (AT91C_SSC_TXRDY)) {
-            AT91C_BASE_SSC->SSC_THR = 0x00;
-        }
-        if(AT91C_BASE_SSC->SSC_SR & (AT91C_SSC_RXRDY)) {
-            uint8_t b = (uint8_t)AT91C_BASE_SSC->SSC_RHR;
-
-            mask = 0x80;
-            for(i = 0; i < 8; i++, mask >>= 1) {
-                bit = (b & mask);
-                if(Handle14443UartBit(bit)) {
-                    *len = Uart.byteCnt;
-                    return TRUE;
-                }
-            }
-        }
-    }
+       uint8_t mask;
+       int i, bit;
+
+       // Set FPGA mode to "simulated ISO 14443 tag", no modulation (listen
+       // only, since we are receiving, not transmitting).
+       // Signal field is off with the appropriate LED
+       LED_D_OFF();
+       FpgaWriteConfWord(FPGA_MAJOR_MODE_HF_SIMULATOR | FPGA_HF_SIMULATOR_NO_MODULATION);
+
+
+       // Now run a `software UART' on the stream of incoming samples.
+       Uart.output = received;
+       Uart.byteCntMax = maxLen;
+       Uart.state = STATE_UNSYNCD;
+
+       for(;;) {
+               WDT_HIT();
+
+               if(BUTTON_PRESS()) return FALSE;
+
+               if(AT91C_BASE_SSC->SSC_SR & (AT91C_SSC_TXRDY)) {
+                       AT91C_BASE_SSC->SSC_THR = 0x00;
+               }
+               if(AT91C_BASE_SSC->SSC_SR & (AT91C_SSC_RXRDY)) {
+                       uint8_t b = (uint8_t)AT91C_BASE_SSC->SSC_RHR;
+
+                       mask = 0x80;
+                       for(i = 0; i < 8; i++, mask >>= 1) {
+                               bit = (b & mask);
+                               if(Handle14443UartBit(bit)) {
+                                       *len = Uart.byteCnt;
+                                       return TRUE;
+                               }
+                       }
+               }
+       }
 }
 
 //-----------------------------------------------------------------------------
@@ -330,99 +330,99 @@ static int GetIso14443CommandFromReader(uint8_t *received, int *len, int maxLen)
 //-----------------------------------------------------------------------------
 void SimulateIso14443Tag(void)
 {
-    static const uint8_t cmd1[] = { 0x05, 0x00, 0x08, 0x39, 0x73 };
-    static const uint8_t response1[] = {
-        0x50, 0x82, 0x0d, 0xe1, 0x74, 0x20, 0x38, 0x19, 0x22,
-        0x00, 0x21, 0x85, 0x5e, 0xd7
-    };
+       static const uint8_t cmd1[] = { 0x05, 0x00, 0x08, 0x39, 0x73 };
+       static const uint8_t response1[] = {
+               0x50, 0x82, 0x0d, 0xe1, 0x74, 0x20, 0x38, 0x19, 0x22,
+               0x00, 0x21, 0x85, 0x5e, 0xd7
+       };
 
-    uint8_t *resp;
-    int respLen;
+       uint8_t *resp;
+       int respLen;
 
-    uint8_t *resp1 = BigBuf_get_addr() + 800;
-    int resp1Len;
+       uint8_t *resp1 = BigBuf_get_addr() + 800;
+       int resp1Len;
 
-    uint8_t *receivedCmd = BigBuf_get_addr();
-    int len;
+       uint8_t *receivedCmd = BigBuf_get_addr();
+       int len;
 
-    int i;
+       int i;
 
-    int cmdsRecvd = 0;
+       int cmdsRecvd = 0;
 
-    FpgaDownloadAndGo(FPGA_BITSTREAM_HF);
-    memset(receivedCmd, 0x44, 400);
+       FpgaDownloadAndGo(FPGA_BITSTREAM_HF);
+       memset(receivedCmd, 0x44, 400);
 
-    CodeIso14443bAsTag(response1, sizeof(response1));
-    memcpy(resp1, ToSend, ToSendMax); resp1Len = ToSendMax;
+       CodeIso14443bAsTag(response1, sizeof(response1));
+       memcpy(resp1, ToSend, ToSendMax); resp1Len = ToSendMax;
 
-    // We need to listen to the high-frequency, peak-detected path.
-    SetAdcMuxFor(GPIO_MUXSEL_HIPKD);
-    FpgaSetupSsc();
+       // We need to listen to the high-frequency, peak-detected path.
+       SetAdcMuxFor(GPIO_MUXSEL_HIPKD);
+       FpgaSetupSsc();
 
-    cmdsRecvd = 0;
+       cmdsRecvd = 0;
 
-    for(;;) {
-        uint8_t b1, b2;
+       for(;;) {
+               uint8_t b1, b2;
 
-        if(!GetIso14443CommandFromReader(receivedCmd, &len, 100)) {
+               if(!GetIso14443CommandFromReader(receivedCmd, &len, 100)) {
                Dbprintf("button pressed, received %d commands", cmdsRecvd);
                break;
-        }
-
-        // Good, look at the command now.
-
-        if(len == sizeof(cmd1) && memcmp(receivedCmd, cmd1, len)==0) {
-            resp = resp1; respLen = resp1Len;
-        } else {
-            Dbprintf("new cmd from reader: len=%d, cmdsRecvd=%d", len, cmdsRecvd);
-            // And print whether the CRC fails, just for good measure
-            ComputeCrc14443(CRC_14443_B, receivedCmd, len-2, &b1, &b2);
-            if(b1 != receivedCmd[len-2] || b2 != receivedCmd[len-1]) {
-                // Not so good, try again.
-                DbpString("+++CRC fail");
-            } else {
-                DbpString("CRC passes");
-            }
-            break;
-        }
-
-        memset(receivedCmd, 0x44, 32);
-
-        cmdsRecvd++;
-
-        if(cmdsRecvd > 0x30) {
-            DbpString("many commands later...");
-            break;
-        }
-
-        if(respLen <= 0) continue;
-
-        // Modulate BPSK
-        // Signal field is off with the appropriate LED
-        LED_D_OFF();
-        FpgaWriteConfWord(FPGA_MAJOR_MODE_HF_SIMULATOR | FPGA_HF_SIMULATOR_MODULATE_BPSK);
-        AT91C_BASE_SSC->SSC_THR = 0xff;
-        FpgaSetupSsc();
-
-        // Transmit the response.
-        i = 0;
-        for(;;) {
-            if(AT91C_BASE_SSC->SSC_SR & (AT91C_SSC_TXRDY)) {
-                uint8_t b = resp[i];
-
-                AT91C_BASE_SSC->SSC_THR = b;
-
-                i++;
-                if(i > respLen) {
-                    break;
-                }
-            }
-            if(AT91C_BASE_SSC->SSC_SR & (AT91C_SSC_RXRDY)) {
-                volatile uint8_t b = (uint8_t)AT91C_BASE_SSC->SSC_RHR;
-                (void)b;
-            }
-        }
-    }
+               }
+
+               // Good, look at the command now.
+
+               if(len == sizeof(cmd1) && memcmp(receivedCmd, cmd1, len)==0) {
+                       resp = resp1; respLen = resp1Len;
+               } else {
+                       Dbprintf("new cmd from reader: len=%d, cmdsRecvd=%d", len, cmdsRecvd);
+                       // And print whether the CRC fails, just for good measure
+                       ComputeCrc14443(CRC_14443_B, receivedCmd, len-2, &b1, &b2);
+                       if(b1 != receivedCmd[len-2] || b2 != receivedCmd[len-1]) {
+                               // Not so good, try again.
+                               DbpString("+++CRC fail");
+                       } else {
+                               DbpString("CRC passes");
+                       }
+                       break;
+               }
+
+               memset(receivedCmd, 0x44, 32);
+
+               cmdsRecvd++;
+
+               if(cmdsRecvd > 0x30) {
+                       DbpString("many commands later...");
+                       break;
+               }
+
+               if(respLen <= 0) continue;
+
+               // Modulate BPSK
+               // Signal field is off with the appropriate LED
+               LED_D_OFF();
+               FpgaWriteConfWord(FPGA_MAJOR_MODE_HF_SIMULATOR | FPGA_HF_SIMULATOR_MODULATE_BPSK);
+               AT91C_BASE_SSC->SSC_THR = 0xff;
+               FpgaSetupSsc();
+
+               // Transmit the response.
+               i = 0;
+               for(;;) {
+                       if(AT91C_BASE_SSC->SSC_SR & (AT91C_SSC_TXRDY)) {
+                               uint8_t b = resp[i];
+
+                               AT91C_BASE_SSC->SSC_THR = b;
+
+                               i++;
+                               if(i > respLen) {
+                                       break;
+                               }
+                       }
+                       if(AT91C_BASE_SSC->SSC_SR & (AT91C_SSC_RXRDY)) {
+                               volatile uint8_t b = (uint8_t)AT91C_BASE_SSC->SSC_RHR;
+                               (void)b;
+                       }
+               }
+       }
 }
 
 //=============================================================================
@@ -433,25 +433,25 @@ void SimulateIso14443Tag(void)
 //=============================================================================
 
 static struct {
-    enum {
-        DEMOD_UNSYNCD,
-        DEMOD_PHASE_REF_TRAINING,
-        DEMOD_AWAITING_FALLING_EDGE_OF_SOF,
-        DEMOD_GOT_FALLING_EDGE_OF_SOF,
-        DEMOD_AWAITING_START_BIT,
-        DEMOD_RECEIVING_DATA,
-        DEMOD_ERROR_WAIT
-    }       state;
-    int     bitCount;
-    int     posCount;
-    int     thisBit;
-    int     metric;
-    int     metricN;
-    uint16_t    shiftReg;
-    uint8_t   *output;
-    int     len;
-    int     sumI;
-    int     sumQ;
+       enum {
+               DEMOD_UNSYNCD,
+               DEMOD_PHASE_REF_TRAINING,
+               DEMOD_AWAITING_FALLING_EDGE_OF_SOF,
+               DEMOD_GOT_FALLING_EDGE_OF_SOF,
+               DEMOD_AWAITING_START_BIT,
+               DEMOD_RECEIVING_DATA,
+               DEMOD_ERROR_WAIT
+       }       state;
+       int     bitCount;
+       int     posCount;
+       int     thisBit;
+       int     metric;
+       int     metricN;
+       uint16_t    shiftReg;
+       uint8_t   *output;
+       int     len;
+       int     sumI;
+       int     sumQ;
 } Demod;
 
 /*
@@ -467,238 +467,266 @@ static struct {
  */
 static RAMFUNC int Handle14443SamplesDemod(int ci, int cq)
 {
-    int v;
+       int v;
 
-    // The soft decision on the bit uses an estimate of just the
-    // quadrant of the reference angle, not the exact angle.
+       // The soft decision on the bit uses an estimate of just the
+       // quadrant of the reference angle, not the exact angle.
 #define MAKE_SOFT_DECISION() { \
-        if(Demod.sumI > 0) { \
-            v = ci; \
-        } else { \
-            v = -ci; \
-        } \
-        if(Demod.sumQ > 0) { \
-            v += cq; \
-        } else { \
-            v -= cq; \
-        } \
-    }
-
-    switch(Demod.state) {
-        case DEMOD_UNSYNCD:
-            v = ci;
-            if(v < 0) v = -v;
-            if(cq > 0) {
-                v += cq;
-            } else {
-                v -= cq;
-            }
-            if(v > 40) {
-                Demod.posCount = 0;
-                Demod.state = DEMOD_PHASE_REF_TRAINING;
-                Demod.sumI = 0;
-                Demod.sumQ = 0;
-            }
-            break;
-
-        case DEMOD_PHASE_REF_TRAINING:
-            if(Demod.posCount < 8) {
-                Demod.sumI += ci;
-                Demod.sumQ += cq;
-            } else if(Demod.posCount > 100) {
-                // error, waited too long
-                Demod.state = DEMOD_UNSYNCD;
-            } else {
-                MAKE_SOFT_DECISION();
-                if(v < 0) {
-                    Demod.state = DEMOD_AWAITING_FALLING_EDGE_OF_SOF;
-                    Demod.posCount = 0;
-                }
-            }
-            Demod.posCount++;
-            break;
-
-        case DEMOD_AWAITING_FALLING_EDGE_OF_SOF:
-            MAKE_SOFT_DECISION();
-            if(v < 0) {
-                Demod.state = DEMOD_GOT_FALLING_EDGE_OF_SOF;
-                Demod.posCount = 0;
-            } else {
-                if(Demod.posCount > 100) {
-                    Demod.state = DEMOD_UNSYNCD;
-                }
-            }
-            Demod.posCount++;
-            break;
-
-        case DEMOD_GOT_FALLING_EDGE_OF_SOF:
-            MAKE_SOFT_DECISION();
-            if(v > 0) {
-                if(Demod.posCount < 12) {
-                    Demod.state = DEMOD_UNSYNCD;
-                } else {
-                    LED_C_ON(); // Got SOF
-                    Demod.state = DEMOD_AWAITING_START_BIT;
-                    Demod.posCount = 0;
-                    Demod.len = 0;
-                    Demod.metricN = 0;
-                    Demod.metric = 0;
-                }
-            } else {
-                if(Demod.posCount > 100) {
-                    Demod.state = DEMOD_UNSYNCD;
-                }
-            }
-            Demod.posCount++;
-            break;
-
-        case DEMOD_AWAITING_START_BIT:
-            MAKE_SOFT_DECISION();
-            if(v > 0) {
-                if(Demod.posCount > 10) {
-                    Demod.state = DEMOD_UNSYNCD;
-                }
-            } else {
-                Demod.bitCount = 0;
-                Demod.posCount = 1;
-                Demod.thisBit = v;
-                Demod.shiftReg = 0;
-                Demod.state = DEMOD_RECEIVING_DATA;
-            }
-            break;
-
-        case DEMOD_RECEIVING_DATA:
-            MAKE_SOFT_DECISION();
-            if(Demod.posCount == 0) {
-                Demod.thisBit = v;
-                Demod.posCount = 1;
-            } else {
-                Demod.thisBit += v;
-
-                if(Demod.thisBit > 0) {
-                    Demod.metric += Demod.thisBit;
-                } else {
-                    Demod.metric -= Demod.thisBit;
-                }
-                (Demod.metricN)++;
-
-                Demod.shiftReg >>= 1;
-                if(Demod.thisBit > 0) {
-                    Demod.shiftReg |= 0x200;
-                }
-
-                Demod.bitCount++;
-                if(Demod.bitCount == 10) {
-                    uint16_t s = Demod.shiftReg;
-                    if((s & 0x200) && !(s & 0x001)) {
-                        uint8_t b = (s >> 1);
-                        Demod.output[Demod.len] = b;
-                        Demod.len++;
-                        Demod.state = DEMOD_AWAITING_START_BIT;
-                    } else if(s == 0x000) {
-                        // This is EOF
-                       LED_C_OFF();
-                        Demod.state = DEMOD_UNSYNCD;
-                        return TRUE;
-                    } else {
-                        Demod.state = DEMOD_UNSYNCD;
-                    }
-                }
-                Demod.posCount = 0;
-            }
-            break;
-
-        default:
-            Demod.state = DEMOD_UNSYNCD;
-            break;
-    }
-
-    if (Demod.state == DEMOD_UNSYNCD) LED_C_OFF(); // Not synchronized...
-    return FALSE;
+               if(Demod.sumI > 0) { \
+                       v = ci; \
+               } else { \
+                       v = -ci; \
+               } \
+               if(Demod.sumQ > 0) { \
+                       v += cq; \
+               } else { \
+                       v -= cq; \
+               } \
+       }
+
+       switch(Demod.state) {
+               case DEMOD_UNSYNCD:
+                       v = ci;
+                       if(v < 0) v = -v;
+                       if(cq > 0) {
+                               v += cq;
+                       } else {
+                               v -= cq;
+                       }
+                       if(v > 40) {
+                               Demod.posCount = 0;
+                               Demod.state = DEMOD_PHASE_REF_TRAINING;
+                               Demod.sumI = 0;
+                               Demod.sumQ = 0;
+                       }
+                       break;
+
+               case DEMOD_PHASE_REF_TRAINING:
+                       if(Demod.posCount < 8) {
+                               Demod.sumI += ci;
+                               Demod.sumQ += cq;
+                       } else if(Demod.posCount > 100) {
+                               // error, waited too long
+                               Demod.state = DEMOD_UNSYNCD;
+                       } else {
+                               MAKE_SOFT_DECISION();
+                               if(v < 0) {
+                                       Demod.state = DEMOD_AWAITING_FALLING_EDGE_OF_SOF;
+                                       Demod.posCount = 0;
+                               }
+                       }
+                       Demod.posCount++;
+                       break;
+
+               case DEMOD_AWAITING_FALLING_EDGE_OF_SOF:
+                       MAKE_SOFT_DECISION();
+                       if(v < 0) {
+                               Demod.state = DEMOD_GOT_FALLING_EDGE_OF_SOF;
+                               Demod.posCount = 0;
+                       } else {
+                               if(Demod.posCount > 100) {
+                                       Demod.state = DEMOD_UNSYNCD;
+                               }
+                       }
+                       Demod.posCount++;
+                       break;
+
+               case DEMOD_GOT_FALLING_EDGE_OF_SOF:
+                       MAKE_SOFT_DECISION();
+                       if(v > 0) {
+                               if(Demod.posCount < 12) {
+                                       Demod.state = DEMOD_UNSYNCD;
+                               } else {
+                                       LED_C_ON(); // Got SOF
+                                       Demod.state = DEMOD_AWAITING_START_BIT;
+                                       Demod.posCount = 0;
+                                       Demod.len = 0;
+                                       Demod.metricN = 0;
+                                       Demod.metric = 0;
+                               }
+                       } else {
+                               if(Demod.posCount > 100) {
+                                       Demod.state = DEMOD_UNSYNCD;
+                               }
+                       }
+                       Demod.posCount++;
+                       break;
+
+               case DEMOD_AWAITING_START_BIT:
+                       MAKE_SOFT_DECISION();
+                       if(v > 0) {
+                               if(Demod.posCount > 10) {
+                                       Demod.state = DEMOD_UNSYNCD;
+                               }
+                       } else {
+                               Demod.bitCount = 0;
+                               Demod.posCount = 1;
+                               Demod.thisBit = v;
+                               Demod.shiftReg = 0;
+                               Demod.state = DEMOD_RECEIVING_DATA;
+                       }
+                       break;
+
+               case DEMOD_RECEIVING_DATA:
+                       MAKE_SOFT_DECISION();
+                       if(Demod.posCount == 0) {
+                               Demod.thisBit = v;
+                               Demod.posCount = 1;
+                       } else {
+                               Demod.thisBit += v;
+
+                               if(Demod.thisBit > 0) {
+                                       Demod.metric += Demod.thisBit;
+                               } else {
+                                       Demod.metric -= Demod.thisBit;
+                               }
+                               (Demod.metricN)++;
+
+                               Demod.shiftReg >>= 1;
+                               if(Demod.thisBit > 0) {
+                                       Demod.shiftReg |= 0x200;
+                               }
+
+                               Demod.bitCount++;
+                               if(Demod.bitCount == 10) {
+                                       uint16_t s = Demod.shiftReg;
+                                       if((s & 0x200) && !(s & 0x001)) {
+                                               uint8_t b = (s >> 1);
+                                               Demod.output[Demod.len] = b;
+                                               Demod.len++;
+                                               Demod.state = DEMOD_AWAITING_START_BIT;
+                                       } else if(s == 0x000) {
+                                               // This is EOF
+                                               LED_C_OFF();
+                                               Demod.state = DEMOD_UNSYNCD;
+                                               return TRUE;
+                                       } else {
+                                               Demod.state = DEMOD_UNSYNCD;
+                                       }
+                               }
+                               Demod.posCount = 0;
+                       }
+                       break;
+
+               default:
+                       Demod.state = DEMOD_UNSYNCD;
+                       break;
+       }
+
+       if (Demod.state == DEMOD_UNSYNCD) LED_C_OFF(); // Not synchronized...
+       return FALSE;
+}
+static void DemodReset()
+{
+       // Clear out the state of the "UART" that receives from the tag.
+       Demod.len = 0;
+       Demod.state = DEMOD_UNSYNCD;
+       memset(Demod.output, 0x00, MAX_FRAME_SIZE);
+}
+static void DemodInit(uint8_t *data)
+{
+       Demod.output = data;
+       DemodReset();
+}
+
+static void UartReset()
+{
+       Uart.byteCntMax = MAX_FRAME_SIZE;
+       Uart.state = STATE_UNSYNCD;
+       Uart.byteCnt = 0;
+       Uart.bitCnt = 0;
+}
+static void UartInit(uint8_t *data)
+{
+       Uart.output = data;
+       UartReset();
 }
 
 /*
- *  Demodulate the samples we received from the tag
+ *  Demodulate the samples we received from the tag, also log to tracebuffer
  *  weTx: set to 'TRUE' if we behave like a reader
  *        set to 'FALSE' if we behave like a snooper
  *  quiet: set to 'TRUE' to disable debug output
  */
 static void GetSamplesFor14443Demod(int weTx, int n, int quiet)
 {
-    int max = 0;
-    int gotFrame = FALSE;
-
-//#   define DMA_BUFFER_SIZE 8
-    uint8_t *dmaBuf;
-
-    int lastRxCounter;
-    uint8_t *upTo;
-
-    int ci, cq;
-
-    int samples = 0;
-
-    // Clear out the state of the "UART" that receives from the tag.
-       uint8_t *BigBuf = BigBuf_get_addr();
-    memset(BigBuf, 0x00, 400);
-    Demod.output = BigBuf;
-    Demod.len = 0;
-    Demod.state = DEMOD_UNSYNCD;
-
-    // And the UART that receives from the reader
-    Uart.output = BigBuf + 1024;
-    Uart.byteCntMax = 100;
-    Uart.state = STATE_UNSYNCD;
-
-    // Setup for the DMA.
-    dmaBuf = BigBuf + 32;
-    upTo = dmaBuf;
-    lastRxCounter = DEMOD_DMA_BUFFER_SIZE;
-    FpgaSetupSscDma(dmaBuf, DEMOD_DMA_BUFFER_SIZE);
-
-    // Signal field is ON with the appropriate LED:
-    if (weTx) LED_D_ON(); else LED_D_OFF();
-    // And put the FPGA in the appropriate mode
-    FpgaWriteConfWord(
-       FPGA_MAJOR_MODE_HF_READER_RX_XCORR | FPGA_HF_READER_RX_XCORR_848_KHZ |
-       (weTx ? 0 : FPGA_HF_READER_RX_XCORR_SNOOP));
-
-    for(;;) {
-        int behindBy = lastRxCounter - AT91C_BASE_PDC_SSC->PDC_RCR;
-        if(behindBy > max) max = behindBy;
-
-        while(((lastRxCounter-AT91C_BASE_PDC_SSC->PDC_RCR) & (DEMOD_DMA_BUFFER_SIZE-1))
-                    > 2)
-        {
-            ci = upTo[0];
-            cq = upTo[1];
-            upTo += 2;
-            if(upTo - dmaBuf > DEMOD_DMA_BUFFER_SIZE) {
-                upTo -= DEMOD_DMA_BUFFER_SIZE;
-                AT91C_BASE_PDC_SSC->PDC_RNPR = (uint32_t) upTo;
-                AT91C_BASE_PDC_SSC->PDC_RNCR = DEMOD_DMA_BUFFER_SIZE;
-            }
-            lastRxCounter -= 2;
-            if(lastRxCounter <= 0) {
-                lastRxCounter += DEMOD_DMA_BUFFER_SIZE;
-            }
-
-            samples += 2;
-
-            Handle14443UartBit(1);
-            Handle14443UartBit(1);
-
-            if(Handle14443SamplesDemod(ci, cq)) {
-                gotFrame = 1;
-            }
-        }
-
-        if(samples > 2000) {
-            break;
-        }
-    }
-    AT91C_BASE_PDC_SSC->PDC_PTCR = AT91C_PDC_RXTDIS;
-    if (!quiet) Dbprintf("%x %x %x", max, gotFrame, Demod.len);
+       int max = 0;
+       int gotFrame = FALSE;
+       int lastRxCounter, ci, cq, samples = 0;
+
+       // Allocate memory from BigBuf for some buffers
+       // free all previous allocations first
+       BigBuf_free();
+       
+       // The command (reader -> tag) that we're receiving.
+       uint8_t *receivedCmd = BigBuf_malloc(MAX_FRAME_SIZE);
+       
+       // The response (tag -> reader) that we're receiving.
+       uint8_t *receivedResponse = BigBuf_malloc(MAX_FRAME_SIZE);
+       
+       // The DMA buffer, used to stream samples from the FPGA
+       uint8_t *dmaBuf = BigBuf_malloc(DMA_BUFFER_SIZE);
+
+       // Set up the demodulator for tag -> reader responses.
+       DemodInit(receivedResponse);
+       // Set up the demodulator for the reader -> tag commands
+       UartInit(receivedCmd);
+
+       // Setup and start DMA.
+       FpgaSetupSscDma(dmaBuf, DMA_BUFFER_SIZE);
+
+       uint8_t *upTo= dmaBuf;
+       lastRxCounter = DMA_BUFFER_SIZE;
+
+       // Signal field is ON with the appropriate LED:
+       if (weTx) LED_D_ON(); else LED_D_OFF();
+       // And put the FPGA in the appropriate mode
+       FpgaWriteConfWord(
+               FPGA_MAJOR_MODE_HF_READER_RX_XCORR | FPGA_HF_READER_RX_XCORR_848_KHZ |
+               (weTx ? 0 : FPGA_HF_READER_RX_XCORR_SNOOP));
+
+       for(;;) {
+               int behindBy = lastRxCounter - AT91C_BASE_PDC_SSC->PDC_RCR;
+               if(behindBy > max) max = behindBy;
+
+               while(((lastRxCounter-AT91C_BASE_PDC_SSC->PDC_RCR) & (DMA_BUFFER_SIZE-1))
+                                       > 2)
+               {
+                       ci = upTo[0];
+                       cq = upTo[1];
+                       upTo += 2;
+                       if(upTo - dmaBuf > DMA_BUFFER_SIZE) {
+                               upTo -= DMA_BUFFER_SIZE;
+                               AT91C_BASE_PDC_SSC->PDC_RNPR = (uint32_t) upTo;
+                               AT91C_BASE_PDC_SSC->PDC_RNCR = DMA_BUFFER_SIZE;
+                       }
+                       lastRxCounter -= 2;
+                       if(lastRxCounter <= 0) {
+                               lastRxCounter += DMA_BUFFER_SIZE;
+                       }
+
+                       samples += 2;
+
+                       Handle14443UartBit(1);
+                       Handle14443UartBit(1);
+
+                       if(Handle14443SamplesDemod(ci, cq)) {
+                               gotFrame = 1;
+                       }
+               }
+
+               if(samples > 2000) {
+                       break;
+               }
+       }
+       AT91C_BASE_PDC_SSC->PDC_PTCR = AT91C_PDC_RXTDIS;
+       if (!quiet) Dbprintf("%x %x %x", max, gotFrame, Demod.len);
+       //Tracing
+       if (tracing && Demod.len > 0) {
+               uint8_t parity[MAX_PARITY_SIZE];
+               GetParity(Demod.output , Demod.len, parity);
+               LogTrace(Demod.output,Demod.len, 0, 0, parity, FALSE);
+       }
 }
 
 //-----------------------------------------------------------------------------
@@ -708,29 +736,29 @@ static void GetSamplesFor14443Demod(int weTx, int n, int quiet)
 //-----------------------------------------------------------------------------
 /*static void GetSamplesFor14443(int weTx, int n)
 {
-    uint8_t *dest = (uint8_t *)BigBuf;
-    int c;
-
-    FpgaWriteConfWord(
-       FPGA_MAJOR_MODE_HF_READER_RX_XCORR | FPGA_HF_READER_RX_XCORR_848_KHZ |
-       (weTx ? 0 : FPGA_HF_READER_RX_XCORR_SNOOP));
-
-    c = 0;
-    for(;;) {
-        if(AT91C_BASE_SSC->SSC_SR & (AT91C_SSC_TXRDY)) {
-            AT91C_BASE_SSC->SSC_THR = 0x43;
-        }
-        if(AT91C_BASE_SSC->SSC_SR & (AT91C_SSC_RXRDY)) {
-            int8_t b;
-            b = (int8_t)AT91C_BASE_SSC->SSC_RHR;
-
-            dest[c++] = (uint8_t)b;
-
-            if(c >= n) {
-                break;
-            }
-        }
-    }
+       uint8_t *dest = (uint8_t *)BigBuf;
+       int c;
+
+       FpgaWriteConfWord(
+               FPGA_MAJOR_MODE_HF_READER_RX_XCORR | FPGA_HF_READER_RX_XCORR_848_KHZ |
+               (weTx ? 0 : FPGA_HF_READER_RX_XCORR_SNOOP));
+
+       c = 0;
+       for(;;) {
+               if(AT91C_BASE_SSC->SSC_SR & (AT91C_SSC_TXRDY)) {
+                       AT91C_BASE_SSC->SSC_THR = 0x43;
+               }
+               if(AT91C_BASE_SSC->SSC_SR & (AT91C_SSC_RXRDY)) {
+                       int8_t b;
+                       b = (int8_t)AT91C_BASE_SSC->SSC_RHR;
+
+                       dest[c++] = (uint8_t)b;
+
+                       if(c >= n) {
+                               break;
+                       }
+               }
+       }
 }*/
 
 //-----------------------------------------------------------------------------
@@ -738,49 +766,49 @@ static void GetSamplesFor14443Demod(int weTx, int n, int quiet)
 //-----------------------------------------------------------------------------
 static void TransmitFor14443(void)
 {
-    int c;
+       int c;
 
-    FpgaSetupSsc();
+       FpgaSetupSsc();
 
-    while(AT91C_BASE_SSC->SSC_SR & (AT91C_SSC_TXRDY)) {
-        AT91C_BASE_SSC->SSC_THR = 0xff;
-    }
+       while(AT91C_BASE_SSC->SSC_SR & (AT91C_SSC_TXRDY)) {
+               AT91C_BASE_SSC->SSC_THR = 0xff;
+       }
 
-    // Signal field is ON with the appropriate Red LED
+       // Signal field is ON with the appropriate Red LED
        LED_D_ON();
        // Signal we are transmitting with the Green LED
        LED_B_ON();
        FpgaWriteConfWord(
-       FPGA_MAJOR_MODE_HF_READER_TX | FPGA_HF_READER_TX_SHALLOW_MOD);
-
-    for(c = 0; c < 10;) {
-        if(AT91C_BASE_SSC->SSC_SR & (AT91C_SSC_TXRDY)) {
-            AT91C_BASE_SSC->SSC_THR = 0xff;
-            c++;
-        }
-        if(AT91C_BASE_SSC->SSC_SR & (AT91C_SSC_RXRDY)) {
-            volatile uint32_t r = AT91C_BASE_SSC->SSC_RHR;
-            (void)r;
-        }
-        WDT_HIT();
-    }
-
-    c = 0;
-    for(;;) {
-        if(AT91C_BASE_SSC->SSC_SR & (AT91C_SSC_TXRDY)) {
-            AT91C_BASE_SSC->SSC_THR = ToSend[c];
-            c++;
-            if(c >= ToSendMax) {
-                break;
-            }
-        }
-        if(AT91C_BASE_SSC->SSC_SR & (AT91C_SSC_RXRDY)) {
-            volatile uint32_t r = AT91C_BASE_SSC->SSC_RHR;
-            (void)r;
-        }
-        WDT_HIT();
-    }
-    LED_B_OFF(); // Finished sending
+               FPGA_MAJOR_MODE_HF_READER_TX | FPGA_HF_READER_TX_SHALLOW_MOD);
+
+       for(c = 0; c < 10;) {
+               if(AT91C_BASE_SSC->SSC_SR & (AT91C_SSC_TXRDY)) {
+                       AT91C_BASE_SSC->SSC_THR = 0xff;
+                       c++;
+               }
+               if(AT91C_BASE_SSC->SSC_SR & (AT91C_SSC_RXRDY)) {
+                       volatile uint32_t r = AT91C_BASE_SSC->SSC_RHR;
+                       (void)r;
+               }
+               WDT_HIT();
+       }
+
+       c = 0;
+       for(;;) {
+               if(AT91C_BASE_SSC->SSC_SR & (AT91C_SSC_TXRDY)) {
+                       AT91C_BASE_SSC->SSC_THR = ToSend[c];
+                       c++;
+                       if(c >= ToSendMax) {
+                               break;
+                       }
+               }
+               if(AT91C_BASE_SSC->SSC_SR & (AT91C_SSC_RXRDY)) {
+                       volatile uint32_t r = AT91C_BASE_SSC->SSC_RHR;
+                       (void)r;
+               }
+               WDT_HIT();
+       }
+       LED_B_OFF(); // Finished sending
 }
 
 //-----------------------------------------------------------------------------
@@ -789,54 +817,54 @@ static void TransmitFor14443(void)
 //-----------------------------------------------------------------------------
 static void CodeIso14443bAsReader(const uint8_t *cmd, int len)
 {
-    int i, j;
-    uint8_t b;
-
-    ToSendReset();
-
-    // Establish initial reference level
-    for(i = 0; i < 40; i++) {
-        ToSendStuffBit(1);
-    }
-    // Send SOF
-    for(i = 0; i < 10; i++) {
-        ToSendStuffBit(0);
-    }
-
-    for(i = 0; i < len; i++) {
-        // Stop bits/EGT
-        ToSendStuffBit(1);
-        ToSendStuffBit(1);
-        // Start bit
-        ToSendStuffBit(0);
-        // Data bits
-        b = cmd[i];
-        for(j = 0; j < 8; j++) {
-            if(b & 1) {
-                ToSendStuffBit(1);
-            } else {
-                ToSendStuffBit(0);
-            }
-            b >>= 1;
-        }
-    }
-    // Send EOF
-    ToSendStuffBit(1);
-    for(i = 0; i < 10; i++) {
-        ToSendStuffBit(0);
-    }
-    for(i = 0; i < 8; i++) {
-        ToSendStuffBit(1);
-    }
-
-    // And then a little more, to make sure that the last character makes
-    // it out before we switch to rx mode.
-    for(i = 0; i < 24; i++) {
-        ToSendStuffBit(1);
-    }
-
-    // Convert from last character reference to length
-    ToSendMax++;
+       int i, j;
+       uint8_t b;
+
+       ToSendReset();
+
+       // Establish initial reference level
+       for(i = 0; i < 40; i++) {
+               ToSendStuffBit(1);
+       }
+       // Send SOF
+       for(i = 0; i < 10; i++) {
+               ToSendStuffBit(0);
+       }
+
+       for(i = 0; i < len; i++) {
+               // Stop bits/EGT
+               ToSendStuffBit(1);
+               ToSendStuffBit(1);
+               // Start bit
+               ToSendStuffBit(0);
+               // Data bits
+               b = cmd[i];
+               for(j = 0; j < 8; j++) {
+                       if(b & 1) {
+                               ToSendStuffBit(1);
+                       } else {
+                               ToSendStuffBit(0);
+                       }
+                       b >>= 1;
+               }
+       }
+       // Send EOF
+       ToSendStuffBit(1);
+       for(i = 0; i < 10; i++) {
+               ToSendStuffBit(0);
+       }
+       for(i = 0; i < 8; i++) {
+               ToSendStuffBit(1);
+       }
+
+       // And then a little more, to make sure that the last character makes
+       // it out before we switch to rx mode.
+       for(i = 0; i < 24; i++) {
+               ToSendStuffBit(1);
+       }
+
+       // Convert from last character reference to length
+       ToSendMax++;
 }
 
 //-----------------------------------------------------------------------------
@@ -849,9 +877,23 @@ static void CodeIso14443bAsReader(const uint8_t *cmd, int len)
 //-----------------------------------------------------------------------------
 void AcquireRawAdcSamplesIso14443(uint32_t parameter)
 {
-    uint8_t cmd1[] = { 0x05, 0x00, 0x08, 0x39, 0x73 };
+       uint8_t cmd1[] = { 0x05, 0x00, 0x08, 0x39, 0x73 };
 
-    SendRawCommand14443B(sizeof(cmd1),1,1,cmd1);
+       SendRawCommand14443B(sizeof(cmd1),1,1,cmd1);
+}
+
+/**
+  Convenience function to encode, transmit and trace iso 14443b comms
+  **/
+static void CodeAndTransmit14443bAsReader(const uint8_t *cmd, int len)
+{
+       CodeIso14443bAsReader(cmd, len);
+       TransmitFor14443();
+       if (tracing) {
+               uint8_t parity[MAX_PARITY_SIZE];
+               GetParity(cmd, len, parity);
+               LogTrace(cmd,len, 0, 0, parity, TRUE);
+       }
 }
 
 //-----------------------------------------------------------------------------
@@ -865,126 +907,129 @@ void AcquireRawAdcSamplesIso14443(uint32_t parameter)
 //-----------------------------------------------------------------------------
 void ReadSTMemoryIso14443(uint32_t dwLast)
 {
-    uint8_t i = 0x00;
-
-    FpgaDownloadAndGo(FPGA_BITSTREAM_HF);
-    // Make sure that we start from off, since the tags are stateful;
-    // confusing things will happen if we don't reset them between reads.
-    LED_D_OFF();
-    FpgaWriteConfWord(FPGA_MAJOR_MODE_OFF);
-    SpinDelay(200);
-
-    SetAdcMuxFor(GPIO_MUXSEL_HIPKD);
-    FpgaSetupSsc();
-
-    // Now give it time to spin up.
-    // Signal field is on with the appropriate LED
-    LED_D_ON();
-    FpgaWriteConfWord(
-       FPGA_MAJOR_MODE_HF_READER_RX_XCORR | FPGA_HF_READER_RX_XCORR_848_KHZ);
-    SpinDelay(200);
-
-    // First command: wake up the tag using the INITIATE command
-    uint8_t cmd1[] = { 0x06, 0x00, 0x97, 0x5b};
-    CodeIso14443bAsReader(cmd1, sizeof(cmd1));
-    TransmitFor14443();
+       clear_trace();
+       set_tracing(TRUE);
+
+       uint8_t i = 0x00;
+
+       FpgaDownloadAndGo(FPGA_BITSTREAM_HF);
+       // Make sure that we start from off, since the tags are stateful;
+       // confusing things will happen if we don't reset them between reads.
+       LED_D_OFF();
+       FpgaWriteConfWord(FPGA_MAJOR_MODE_OFF);
+       SpinDelay(200);
+
+       SetAdcMuxFor(GPIO_MUXSEL_HIPKD);
+       FpgaSetupSsc();
+
+       // Now give it time to spin up.
+       // Signal field is on with the appropriate LED
+       LED_D_ON();
+       FpgaWriteConfWord(
+               FPGA_MAJOR_MODE_HF_READER_RX_XCORR | FPGA_HF_READER_RX_XCORR_848_KHZ);
+       SpinDelay(200);
+
+       // First command: wake up the tag using the INITIATE command
+       uint8_t cmd1[] = { 0x06, 0x00, 0x97, 0x5b};
+
+       CodeAndTransmit14443bAsReader(cmd1, sizeof(cmd1));
 //    LED_A_ON();
-    GetSamplesFor14443Demod(TRUE, 2000,TRUE);
+       GetSamplesFor14443Demod(TRUE, 2000,TRUE);
 //    LED_A_OFF();
 
-    if (Demod.len == 0) {
+       if (Demod.len == 0) {
        DbpString("No response from tag");
        return;
-    } else {
+       } else {
        Dbprintf("Randomly generated UID from tag (+ 2 byte CRC): %x %x %x",
                Demod.output[0], Demod.output[1],Demod.output[2]);
-    }
-    // There is a response, SELECT the uid
-    DbpString("Now SELECT tag:");
-    cmd1[0] = 0x0E; // 0x0E is SELECT
-    cmd1[1] = Demod.output[0];
-    ComputeCrc14443(CRC_14443_B, cmd1, 2, &cmd1[2], &cmd1[3]);
-    CodeIso14443bAsReader(cmd1, sizeof(cmd1));
-    TransmitFor14443();
+       }
+       // There is a response, SELECT the uid
+       DbpString("Now SELECT tag:");
+       cmd1[0] = 0x0E; // 0x0E is SELECT
+       cmd1[1] = Demod.output[0];
+       ComputeCrc14443(CRC_14443_B, cmd1, 2, &cmd1[2], &cmd1[3]);
+       CodeAndTransmit14443bAsReader(cmd1, sizeof(cmd1));
+
 //    LED_A_ON();
-    GetSamplesFor14443Demod(TRUE, 2000,TRUE);
+       GetSamplesFor14443Demod(TRUE, 2000,TRUE);
 //    LED_A_OFF();
-    if (Demod.len != 3) {
+       if (Demod.len != 3) {
        Dbprintf("Expected 3 bytes from tag, got %d", Demod.len);
        return;
-    }
-    // Check the CRC of the answer:
-    ComputeCrc14443(CRC_14443_B, Demod.output, 1 , &cmd1[2], &cmd1[3]);
-    if(cmd1[2] != Demod.output[1] || cmd1[3] != Demod.output[2]) {
+       }
+       // Check the CRC of the answer:
+       ComputeCrc14443(CRC_14443_B, Demod.output, 1 , &cmd1[2], &cmd1[3]);
+       if(cmd1[2] != Demod.output[1] || cmd1[3] != Demod.output[2]) {
        DbpString("CRC Error reading select response.");
        return;
-    }
-    // Check response from the tag: should be the same UID as the command we just sent:
-    if (cmd1[1] != Demod.output[0]) {
+       }
+       // Check response from the tag: should be the same UID as the command we just sent:
+       if (cmd1[1] != Demod.output[0]) {
        Dbprintf("Bad response to SELECT from Tag, aborting: %x %x", cmd1[1], Demod.output[0]);
        return;
-    }
-    // Tag is now selected,
-    // First get the tag's UID:
-    cmd1[0] = 0x0B;
-    ComputeCrc14443(CRC_14443_B, cmd1, 1 , &cmd1[1], &cmd1[2]);
-    CodeIso14443bAsReader(cmd1, 3); // Only first three bytes for this one
-    TransmitFor14443();
+       }
+       // Tag is now selected,
+       // First get the tag's UID:
+       cmd1[0] = 0x0B;
+       ComputeCrc14443(CRC_14443_B, cmd1, 1 , &cmd1[1], &cmd1[2]);
+       CodeAndTransmit14443bAsReader(cmd1, 3); // Only first three bytes for this one
+
 //    LED_A_ON();
-    GetSamplesFor14443Demod(TRUE, 2000,TRUE);
+       GetSamplesFor14443Demod(TRUE, 2000,TRUE);
 //    LED_A_OFF();
-    if (Demod.len != 10) {
+       if (Demod.len != 10) {
        Dbprintf("Expected 10 bytes from tag, got %d", Demod.len);
        return;
-    }
-    // The check the CRC of the answer (use cmd1 as temporary variable):
-    ComputeCrc14443(CRC_14443_B, Demod.output, 8, &cmd1[2], &cmd1[3]);
-           if(cmd1[2] != Demod.output[8] || cmd1[3] != Demod.output[9]) {
+       }
+       // The check the CRC of the answer (use cmd1 as temporary variable):
+       ComputeCrc14443(CRC_14443_B, Demod.output, 8, &cmd1[2], &cmd1[3]);
+                  if(cmd1[2] != Demod.output[8] || cmd1[3] != Demod.output[9]) {
        Dbprintf("CRC Error reading block! - Below: expected, got %x %x",
                (cmd1[2]<<8)+cmd1[3], (Demod.output[8]<<8)+Demod.output[9]);
        // Do not return;, let's go on... (we should retry, maybe ?)
-    }
-    Dbprintf("Tag UID (64 bits): %08x %08x",
+       }
+       Dbprintf("Tag UID (64 bits): %08x %08x",
        (Demod.output[7]<<24) + (Demod.output[6]<<16) + (Demod.output[5]<<8) + Demod.output[4],
        (Demod.output[3]<<24) + (Demod.output[2]<<16) + (Demod.output[1]<<8) + Demod.output[0]);
 
-    // Now loop to read all 16 blocks, address from 0 to last block
-    Dbprintf("Tag memory dump, block 0 to %d",dwLast);
-    cmd1[0] = 0x08;
-    i = 0x00;
-    dwLast++;
-    for (;;) {
-           if (i == dwLast) {
-                   DbpString("System area block (0xff):");
-                   i = 0xff;
-           }
-           cmd1[1] = i;
-           ComputeCrc14443(CRC_14443_B, cmd1, 2, &cmd1[2], &cmd1[3]);
-           CodeIso14443bAsReader(cmd1, sizeof(cmd1));
-           TransmitFor14443();
+       // Now loop to read all 16 blocks, address from 0 to last block
+       Dbprintf("Tag memory dump, block 0 to %d",dwLast);
+       cmd1[0] = 0x08;
+       i = 0x00;
+       dwLast++;
+       for (;;) {
+                  if (i == dwLast) {
+                       DbpString("System area block (0xff):");
+                       i = 0xff;
+               }
+               cmd1[1] = i;
+               ComputeCrc14443(CRC_14443_B, cmd1, 2, &cmd1[2], &cmd1[3]);
+               CodeAndTransmit14443bAsReader(cmd1, sizeof(cmd1));
+
 //         LED_A_ON();
-           GetSamplesFor14443Demod(TRUE, 2000,TRUE);
+               GetSamplesFor14443Demod(TRUE, 2000,TRUE);
 //         LED_A_OFF();
-           if (Demod.len != 6) { // Check if we got an answer from the tag
+               if (Demod.len != 6) { // Check if we got an answer from the tag
                DbpString("Expected 6 bytes from tag, got less...");
                return;
-           }
-           // The check the CRC of the answer (use cmd1 as temporary variable):
-           ComputeCrc14443(CRC_14443_B, Demod.output, 4, &cmd1[2], &cmd1[3]);
-            if(cmd1[2] != Demod.output[4] || cmd1[3] != Demod.output[5]) {
+               }
+               // The check the CRC of the answer (use cmd1 as temporary variable):
+               ComputeCrc14443(CRC_14443_B, Demod.output, 4, &cmd1[2], &cmd1[3]);
+                       if(cmd1[2] != Demod.output[4] || cmd1[3] != Demod.output[5]) {
                Dbprintf("CRC Error reading block! - Below: expected, got %x %x",
                        (cmd1[2]<<8)+cmd1[3], (Demod.output[4]<<8)+Demod.output[5]);
                // Do not return;, let's go on... (we should retry, maybe ?)
-           }
-           // Now print out the memory location:
-           Dbprintf("Address=%x, Contents=%x, CRC=%x", i,
+               }
+               // Now print out the memory location:
+               Dbprintf("Address=%x, Contents=%x, CRC=%x", i,
                (Demod.output[3]<<24) + (Demod.output[2]<<16) + (Demod.output[1]<<8) + Demod.output[0],
                (Demod.output[4]<<8)+Demod.output[5]);
-           if (i == 0xff) {
+               if (i == 0xff) {
                break;
-           }
-           i++;
-    }
+               }
+               i++;
+       }
 }
 
 
@@ -1007,171 +1052,137 @@ void ReadSTMemoryIso14443(uint32_t dwLast)
  */
 void RAMFUNC SnoopIso14443(void)
 {
-    // We won't start recording the frames that we acquire until we trigger;
-    // a good trigger condition to get started is probably when we see a
-    // response from the tag.
-    int triggered = TRUE;
+       // We won't start recording the frames that we acquire until we trigger;
+       // a good trigger condition to get started is probably when we see a
+       // response from the tag.
+       int triggered = TRUE;
 
-    FpgaDownloadAndGo(FPGA_BITSTREAM_HF);
+       FpgaDownloadAndGo(FPGA_BITSTREAM_HF);
        BigBuf_free();
-    // The command (reader -> tag) that we're working on receiving.
-    uint8_t *receivedCmd = BigBuf_malloc(READER_TAG_BUFFER_SIZE);
-    // The response (tag -> reader) that we're working on receiving.
-    uint8_t *receivedResponse = BigBuf_malloc(TAG_READER_BUFFER_SIZE);
-
-    // As we receive stuff, we copy it from receivedCmd or receivedResponse
-    // into trace, along with its length and other annotations.
-    uint8_t *trace = BigBuf_get_addr();
-    traceLen = 0;
-
-    // The DMA buffer, used to stream samples from the FPGA.
-    uint8_t *dmaBuf = BigBuf_malloc(DEMOD_DMA_BUFFER_SIZE);
-    int lastRxCounter;
-    uint8_t *upTo;
-    int ci, cq;
-    int maxBehindBy = 0;
-
-    // Count of samples received so far, so that we can include timing
-    // information in the trace buffer.
-    int samples = 0;
-
-    // Initialize the trace buffer
-    memset(trace, 0x44, BigBuf_max_traceLen());
-
-    // Set up the demodulator for tag -> reader responses.
-    Demod.output = receivedResponse;
-    Demod.len = 0;
-    Demod.state = DEMOD_UNSYNCD;
-
-    // And the reader -> tag commands
-    memset(&Uart, 0, sizeof(Uart));
-    Uart.output = receivedCmd;
-    Uart.byteCntMax = 100;
-    Uart.state = STATE_UNSYNCD;
-
-    // Print some debug information about the buffer sizes
-    Dbprintf("Snooping buffers initialized:");
-    Dbprintf("  Trace: %i bytes", BigBuf_max_traceLen());
-    Dbprintf("  Reader -> tag: %i bytes", READER_TAG_BUFFER_SIZE);
-    Dbprintf("  tag -> Reader: %i bytes", TAG_READER_BUFFER_SIZE);
-    Dbprintf("  DMA: %i bytes", DEMOD_DMA_BUFFER_SIZE);
-
-    // And put the FPGA in the appropriate mode
-    // Signal field is off with the appropriate LED
-    LED_D_OFF();
-    FpgaWriteConfWord(
-       FPGA_MAJOR_MODE_HF_READER_RX_XCORR | FPGA_HF_READER_RX_XCORR_848_KHZ |
-       FPGA_HF_READER_RX_XCORR_SNOOP);
-    SetAdcMuxFor(GPIO_MUXSEL_HIPKD);
-
-    // Setup for the DMA.
-    FpgaSetupSsc();
-    upTo = dmaBuf;
-    lastRxCounter = DEMOD_DMA_BUFFER_SIZE;
-    FpgaSetupSscDma((uint8_t *)dmaBuf, DEMOD_DMA_BUFFER_SIZE);
-               
-    LED_A_ON();
-               
-    // And now we loop, receiving samples.
-    for(;;) {
-       int behindBy = (lastRxCounter - AT91C_BASE_PDC_SSC->PDC_RCR) &
-                                (DEMOD_DMA_BUFFER_SIZE-1);
-        if(behindBy > maxBehindBy) {
-            maxBehindBy = behindBy;
-            if(behindBy > (9*DEMOD_DMA_BUFFER_SIZE/10)) { // TODO: understand whether we can increase/decrease as we want or not?
-                Dbprintf("blew circular buffer! behindBy=0x%x", behindBy);
-                goto done;
-            }
-        }
-        if(behindBy < 2) continue;
-
-        ci = upTo[0];
-        cq = upTo[1];
-        upTo += 2;
-        lastRxCounter -= 2;
-        if(upTo - dmaBuf > DEMOD_DMA_BUFFER_SIZE) {
-            upTo -= DEMOD_DMA_BUFFER_SIZE;
-            lastRxCounter += DEMOD_DMA_BUFFER_SIZE;
-            AT91C_BASE_PDC_SSC->PDC_RNPR = (uint32_t) upTo;
-            AT91C_BASE_PDC_SSC->PDC_RNCR = DEMOD_DMA_BUFFER_SIZE;
-        }
-
-        samples += 2;
-
-#define HANDLE_BIT_IF_BODY \
-            if(triggered) { \
-                trace[traceLen++] = ((samples >>  0) & 0xff); \
-                trace[traceLen++] = ((samples >>  8) & 0xff); \
-                trace[traceLen++] = ((samples >> 16) & 0xff); \
-                trace[traceLen++] = ((samples >> 24) & 0xff); \
-                trace[traceLen++] = 0; \
-                trace[traceLen++] = 0; \
-                trace[traceLen++] = 0; \
-                trace[traceLen++] = 0; \
-                trace[traceLen++] = Uart.byteCnt; \
-                memcpy(trace+traceLen, receivedCmd, Uart.byteCnt); \
-                traceLen += Uart.byteCnt; \
-                if(traceLen > 1000) break; \
-            } \
-            /* And ready to receive another command. */ \
-            memset(&Uart, 0, sizeof(Uart)); \
-            Uart.output = receivedCmd; \
-            Uart.byteCntMax = 100; \
-            Uart.state = STATE_UNSYNCD; \
-            /* And also reset the demod code, which might have been */ \
-            /* false-triggered by the commands from the reader. */ \
-            memset(&Demod, 0, sizeof(Demod)); \
-            Demod.output = receivedResponse; \
-            Demod.state = DEMOD_UNSYNCD; \
-
-        if(Handle14443UartBit(ci & 1)) {
-            HANDLE_BIT_IF_BODY
-        }
-        if(Handle14443UartBit(cq & 1)) {
-            HANDLE_BIT_IF_BODY
-        }
-
-        if(Handle14443SamplesDemod(ci, cq)) {
-            // timestamp, as a count of samples
-            trace[traceLen++] = ((samples >>  0) & 0xff);
-            trace[traceLen++] = ((samples >>  8) & 0xff);
-            trace[traceLen++] = ((samples >> 16) & 0xff);
-            trace[traceLen++] = 0x80 | ((samples >> 24) & 0xff);
-            // correlation metric (~signal strength estimate)
-            if(Demod.metricN != 0) {
-                Demod.metric /= Demod.metricN;
-            }
-            trace[traceLen++] = ((Demod.metric >>  0) & 0xff);
-            trace[traceLen++] = ((Demod.metric >>  8) & 0xff);
-            trace[traceLen++] = ((Demod.metric >> 16) & 0xff);
-            trace[traceLen++] = ((Demod.metric >> 24) & 0xff);
-            // length
-            trace[traceLen++] = Demod.len;
-            memcpy(trace+traceLen, receivedResponse, Demod.len);
-            traceLen += Demod.len;
-            if(traceLen > BigBuf_max_traceLen()) {
-                               DbpString("Reached trace limit");
-                               goto done;
-                       }
 
-            triggered = TRUE;
-            LED_A_OFF();
-            LED_B_ON();
+       clear_trace();
+       set_tracing(TRUE);
+
+       // The DMA buffer, used to stream samples from the FPGA
+       uint8_t *dmaBuf = BigBuf_malloc(DMA_BUFFER_SIZE);
+       int lastRxCounter;
+       uint8_t *upTo;
+       int ci, cq;
+       int maxBehindBy = 0;
+
+       // Count of samples received so far, so that we can include timing
+       // information in the trace buffer.
+       int samples = 0;
 
-            // And ready to receive another response.
-            memset(&Demod, 0, sizeof(Demod));
-            Demod.output = receivedResponse;
-            Demod.state = DEMOD_UNSYNCD;
-        }
-       WDT_HIT();
+       DemodInit(BigBuf_malloc(MAX_FRAME_SIZE));
+       UartInit(BigBuf_malloc(MAX_FRAME_SIZE));
 
-        if(BUTTON_PRESS()) {
-            DbpString("cancelled");
-            goto done;
-        }
-    }
+       // Print some debug information about the buffer sizes
+       Dbprintf("Snooping buffers initialized:");
+       Dbprintf("  Trace: %i bytes", BigBuf_max_traceLen());
+       Dbprintf("  Reader -> tag: %i bytes", MAX_FRAME_SIZE);
+       Dbprintf("  tag -> Reader: %i bytes", MAX_FRAME_SIZE);
+       Dbprintf("  DMA: %i bytes", DMA_BUFFER_SIZE);
 
-done:
+       // Signal field is off with the appropriate LED
+       LED_D_OFF();
+
+       // And put the FPGA in the appropriate mode
+       FpgaWriteConfWord(
+               FPGA_MAJOR_MODE_HF_READER_RX_XCORR | FPGA_HF_READER_RX_XCORR_848_KHZ |
+               FPGA_HF_READER_RX_XCORR_SNOOP);
+       SetAdcMuxFor(GPIO_MUXSEL_HIPKD);
+
+       // Setup for the DMA.
+       FpgaSetupSsc();
+       upTo = dmaBuf;
+       lastRxCounter = DMA_BUFFER_SIZE;
+       FpgaSetupSscDma((uint8_t *)dmaBuf, DMA_BUFFER_SIZE);
+       uint8_t parity[MAX_PARITY_SIZE];
+       LED_A_ON();
+               
+       // And now we loop, receiving samples.
+       for(;;) {
+               int behindBy = (lastRxCounter - AT91C_BASE_PDC_SSC->PDC_RCR) &
+                                                               (DMA_BUFFER_SIZE-1);
+               if(behindBy > maxBehindBy) {
+                       maxBehindBy = behindBy;
+                       if(behindBy > (9*DMA_BUFFER_SIZE/10)) { // TODO: understand whether we can increase/decrease as we want or not?
+                               Dbprintf("blew circular buffer! behindBy=0x%x", behindBy);
+                               break;
+                       }
+               }
+               if(behindBy < 2) continue;
+
+               ci = upTo[0];
+               cq = upTo[1];
+               upTo += 2;
+               lastRxCounter -= 2;
+               if(upTo - dmaBuf > DMA_BUFFER_SIZE) {
+                       upTo -= DMA_BUFFER_SIZE;
+                       lastRxCounter += DMA_BUFFER_SIZE;
+                       AT91C_BASE_PDC_SSC->PDC_RNPR = (uint32_t) upTo;
+                       AT91C_BASE_PDC_SSC->PDC_RNCR = DMA_BUFFER_SIZE;
+               }
+
+               samples += 2;
+
+               if(Handle14443UartBit(ci & 1)) {
+                       if(triggered && tracing) {
+                               GetParity(Uart.output, Uart.byteCnt, parity);
+                               LogTrace(Uart.output,Uart.byteCnt,samples, samples,parity,TRUE);
+                       }
+                       if(Uart.byteCnt==0) Dbprintf("[1] Error, Uart.byteCnt==0, Uart.bitCnt=%d", Uart.bitCnt);
+
+                       /* And ready to receive another command. */
+                       UartReset();
+                       /* And also reset the demod code, which might have been */
+                       /* false-triggered by the commands from the reader. */
+                       DemodReset();
+               }
+               if(Handle14443UartBit(cq & 1)) {
+                       if(triggered && tracing) {
+                               GetParity(Uart.output, Uart.byteCnt, parity);
+                               LogTrace(Uart.output,Uart.byteCnt,samples, samples,parity,TRUE);
+                       }
+                       if(Uart.byteCnt==0) Dbprintf("[2] Error, Uart.byteCnt==0, Uart.bitCnt=%d", Uart.bitCnt);
+
+                       /* And ready to receive another command. */
+                       UartReset();
+                       /* And also reset the demod code, which might have been */
+                       /* false-triggered by the commands from the reader. */
+                       DemodReset();
+               }
+
+               if(Handle14443SamplesDemod(ci, cq)) {
+
+                       //Use samples as a time measurement
+                       if(tracing)
+                       {
+                               uint8_t parity[MAX_PARITY_SIZE];
+                               GetParity(Demod.output, Demod.len, parity);
+                               LogTrace(Demod.output,Demod.len,samples, samples,parity,FALSE);
+                       }
+                       triggered = TRUE;
+                       LED_A_OFF();
+                       LED_B_ON();
+
+                       // And ready to receive another response.
+                       DemodReset();
+               }
+               WDT_HIT();
+
+               if(!tracing) {
+                       DbpString("Reached trace limit");
+                       break;
+               }
+
+               if(BUTTON_PRESS()) {
+                       DbpString("cancelled");
+                       break;
+               }
+       }
+       FpgaDisableSscDma();
        LED_A_OFF();
        LED_B_OFF();
        LED_C_OFF();
@@ -1181,7 +1192,7 @@ done:
        Dbprintf("  Uart State: %x", Uart.state);
        Dbprintf("  Uart ByteCnt: %i", Uart.byteCnt);
        Dbprintf("  Uart ByteCntMax: %i", Uart.byteCntMax);
-       Dbprintf("  Trace length: %i", traceLen);
+       Dbprintf("  Trace length: %i", BigBuf_get_traceLen());
 }
 
 /*
@@ -1199,41 +1210,41 @@ done:
 
 void SendRawCommand14443B(uint32_t datalen, uint32_t recv,uint8_t powerfield, uint8_t data[])
 {
-    FpgaDownloadAndGo(FPGA_BITSTREAM_HF);
-    if(!powerfield)
-    {
-        // Make sure that we start from off, since the tags are stateful;
-        // confusing things will happen if we don't reset them between reads.
-        FpgaWriteConfWord(FPGA_MAJOR_MODE_OFF);
-        LED_D_OFF();
-        SpinDelay(200);
-    }
-
-    if(!GETBIT(GPIO_LED_D))
-    {
-        SetAdcMuxFor(GPIO_MUXSEL_HIPKD);
-        FpgaSetupSsc();
-
-        // Now give it time to spin up.
-        // Signal field is on with the appropriate LED
-        LED_D_ON();
-        FpgaWriteConfWord(
-            FPGA_MAJOR_MODE_HF_READER_RX_XCORR | FPGA_HF_READER_RX_XCORR_848_KHZ);
-        SpinDelay(200);
-    }
-
-    CodeIso14443bAsReader(data, datalen);
-    TransmitFor14443();
-    if(recv)
-    {
-        uint16_t iLen = MIN(Demod.len,USB_CMD_DATA_SIZE);
-        GetSamplesFor14443Demod(TRUE, 2000, TRUE);
-        cmd_send(CMD_ACK,iLen,0,0,Demod.output,iLen);
-    }
-    if(!powerfield)
-    {
-        FpgaWriteConfWord(FPGA_MAJOR_MODE_OFF);
-        LED_D_OFF();
-    }
+       FpgaDownloadAndGo(FPGA_BITSTREAM_HF);
+       if(!powerfield)
+       {
+               // Make sure that we start from off, since the tags are stateful;
+               // confusing things will happen if we don't reset them between reads.
+               FpgaWriteConfWord(FPGA_MAJOR_MODE_OFF);
+               LED_D_OFF();
+               SpinDelay(200);
+       }
+
+       if(!GETBIT(GPIO_LED_D))
+       {
+               SetAdcMuxFor(GPIO_MUXSEL_HIPKD);
+               FpgaSetupSsc();
+
+               // Now give it time to spin up.
+               // Signal field is on with the appropriate LED
+               LED_D_ON();
+               FpgaWriteConfWord(
+                       FPGA_MAJOR_MODE_HF_READER_RX_XCORR | FPGA_HF_READER_RX_XCORR_848_KHZ);
+               SpinDelay(200);
+       }
+
+       CodeAndTransmit14443bAsReader(data, datalen);
+
+       if(recv)
+       {
+               uint16_t iLen = MIN(Demod.len,USB_CMD_DATA_SIZE);
+               GetSamplesFor14443Demod(TRUE, 2000, TRUE);
+               cmd_send(CMD_ACK,iLen,0,0,Demod.output,iLen);
+       }
+       if(!powerfield)
+       {
+               FpgaWriteConfWord(FPGA_MAJOR_MODE_OFF);
+               LED_D_OFF();
+       }
 }
 
index 103f25e691cfa6106cfabe7ffd47ced9e29720d9..a7102168e09d75522e1e35ac02526136a464a57d 100644 (file)
 #include "iso14443a.h"
 #include "crapto1.h"
 #include "mifareutil.h"
-
+#include "BigBuf.h"
 static uint32_t iso14a_timeout;
 int rsamples = 0;
-int tracing = TRUE;
 uint8_t trigger = 0;
 // the block number for the ISO14443-4 PCB
 static uint8_t iso14_pcb_blocknum = 0;
@@ -146,16 +145,7 @@ void iso14a_set_trigger(bool enable) {
        trigger = enable;
 }
 
-void iso14a_clear_trace() {
-       uint8_t *trace = BigBuf_get_addr();
-       uint16_t max_traceLen = BigBuf_max_traceLen();
-       memset(trace, 0x44, max_traceLen);
-       traceLen = 0;
-}
 
-void iso14a_set_tracing(bool enable) {
-       tracing = enable;
-}
 
 void iso14a_set_timeout(uint32_t timeout) {
        iso14a_timeout = timeout;
@@ -199,63 +189,6 @@ void AppendCrc14443a(uint8_t* data, int len)
        ComputeCrc14443(CRC_14443_A,data,len,data+len,data+len+1);
 }
 
-// The function LogTrace() is also used by the iClass implementation in iClass.c
-bool RAMFUNC LogTrace(const uint8_t *btBytes, uint16_t iLen, uint32_t timestamp_start, uint32_t timestamp_end, uint8_t *parity, bool readerToTag)
-{
-       if (!tracing) return FALSE;
-       
-       uint8_t *trace = BigBuf_get_addr();
-       uint16_t num_paritybytes = (iLen-1)/8 + 1;      // number of valid paritybytes in *parity
-       uint16_t duration = timestamp_end - timestamp_start;
-
-       // Return when trace is full
-       uint16_t max_traceLen = BigBuf_max_traceLen();
-       if (traceLen + sizeof(iLen) + sizeof(timestamp_start) + sizeof(duration) + num_paritybytes + iLen >= max_traceLen) {
-               tracing = FALSE;        // don't trace any more
-               return FALSE;
-       }
-       
-       // Traceformat:
-       // 32 bits timestamp (little endian)
-       // 16 bits duration (little endian)
-       // 16 bits data length (little endian, Highest Bit used as readerToTag flag)
-       // y Bytes data
-       // x Bytes parity (one byte per 8 bytes data)
-       
-       // timestamp (start)
-       trace[traceLen++] = ((timestamp_start >> 0) & 0xff);
-       trace[traceLen++] = ((timestamp_start >> 8) & 0xff);
-       trace[traceLen++] = ((timestamp_start >> 16) & 0xff);
-       trace[traceLen++] = ((timestamp_start >> 24) & 0xff);
-       
-       // duration
-       trace[traceLen++] = ((duration >> 0) & 0xff);
-       trace[traceLen++] = ((duration >> 8) & 0xff);
-
-       // data length
-       trace[traceLen++] = ((iLen >> 0) & 0xff);
-       trace[traceLen++] = ((iLen >> 8) & 0xff);
-
-       // readerToTag flag
-       if (!readerToTag) {
-               trace[traceLen - 1] |= 0x80;
-       }
-
-       // data bytes
-       if (btBytes != NULL && iLen != 0) {
-               memcpy(trace + traceLen, btBytes, iLen);
-       }
-       traceLen += iLen;
-
-       // parity bytes
-       if (parity != NULL && iLen != 0) {
-               memcpy(trace + traceLen, parity, num_paritybytes);
-       }
-       traceLen += num_paritybytes;
-
-       return TRUE;
-}
-
 //=============================================================================
 // ISO 14443 Type A - Miller decoder
 //=============================================================================
@@ -616,8 +549,8 @@ void RAMFUNC SnoopIso14443a(uint8_t param) {
        uint8_t *dmaBuf = BigBuf_malloc(DMA_BUFFER_SIZE);
 
        // init trace buffer
-       iso14a_clear_trace();
-       iso14a_set_tracing(TRUE);
+       clear_trace();
+       set_tracing(TRUE);
 
        uint8_t *data = dmaBuf;
        uint8_t previous_data = 0;
@@ -741,7 +674,7 @@ void RAMFUNC SnoopIso14443a(uint8_t param) {
 
        FpgaDisableSscDma();
        Dbprintf("maxDataLen=%d, Uart.state=%x, Uart.len=%d", maxDataLen, Uart.state, Uart.len);
-       Dbprintf("traceLen=%d, Uart.output[0]=%08x", traceLen, (uint32_t)Uart.output[0]);
+       Dbprintf("traceLen=%d, Uart.output[0]=%08x", BigBuf_get_traceLen(), (uint32_t)Uart.output[0]);
        LEDsoff();
 }
 
@@ -1077,8 +1010,8 @@ void SimulateIso14443aTag(int tagType, int uid_1st, int uid_2nd, byte_t* data)
        free_buffer_pointer = BigBuf_malloc(ALLOCATED_TAG_MODULATION_BUFFER_SIZE);
 
        // clear trace
-    iso14a_clear_trace();
-       iso14a_set_tracing(TRUE);
+       clear_trace();
+       set_tracing(TRUE);
 
        // Prepare the responses of the anticollision phase
        // there will be not enough time to do this at the moment the reader sends it REQA
@@ -1936,10 +1869,10 @@ void ReaderIso14443a(UsbCommand *c)
        uint8_t par[MAX_PARITY_SIZE];
   
        if(param & ISO14A_CONNECT) {
-               iso14a_clear_trace();
+               clear_trace();
        }
 
-       iso14a_set_tracing(TRUE);
+       set_tracing(TRUE);
 
        if(param & ISO14A_REQUEST_TRIGGER) {
                iso14a_set_trigger(TRUE);
@@ -2035,8 +1968,8 @@ void ReaderMifare(bool first_try)
        // free eventually allocated BigBuf memory. We want all for tracing.
        BigBuf_free();
        
-       iso14a_clear_trace();
-       iso14a_set_tracing(TRUE);
+       clear_trace();
+       set_tracing(TRUE);
 
        byte_t nt_diff = 0;
        uint8_t par[1] = {0};   // maximum 8 Bytes to be sent here, 1 byte parity is therefore enough
@@ -2209,7 +2142,7 @@ void ReaderMifare(bool first_try)
        FpgaWriteConfWord(FPGA_MAJOR_MODE_OFF);
        LEDsoff();
 
-       iso14a_set_tracing(FALSE);
+       set_tracing(FALSE);
 }
 
 /**
@@ -2268,8 +2201,8 @@ void Mifare1ksim(uint8_t flags, uint8_t exitAfterNReads, uint8_t arg2, uint8_t *
        BigBuf_free_keep_EM();
 
        // clear trace
-    iso14a_clear_trace();
-       iso14a_set_tracing(TRUE);
+       clear_trace();
+       set_tracing(TRUE);
 
        // Authenticate response - nonce
        uint32_t nonce = bytes_to_num(rAUTH_NT, 4);
@@ -2714,7 +2647,7 @@ void Mifare1ksim(uint8_t flags, uint8_t exitAfterNReads, uint8_t arg2, uint8_t *
                        }
                }
        }
-       if (MF_DBGLEVEL >= 1)   Dbprintf("Emulator stopped. Tracing: %d  trace length: %d ",    tracing, traceLen);
+       if (MF_DBGLEVEL >= 1)   Dbprintf("Emulator stopped. Tracing: %d  trace length: %d ",    tracing, BigBuf_get_traceLen());
        
 }
 
@@ -2732,8 +2665,8 @@ void RAMFUNC SniffMifare(uint8_t param) {
        // C(red) A(yellow) B(green)
        LEDsoff();
        // init trace buffer
-       iso14a_clear_trace();
-       iso14a_set_tracing(TRUE);
+       clear_trace();
+       set_tracing(TRUE);
 
        // The command (reader -> tag) that we're receiving.
        // The length of a received command will in most cases be no more than 18 bytes.
index 026049351319cc476c33b4b8e73d6db830618b0d..7fcad0e06379e7e6232acd08ed7011d6310e2af8 100644 (file)
@@ -88,7 +88,4 @@ extern int iso14443a_select_card(uint8_t *uid_ptr, iso14a_card_select_t *resp_da
 extern void iso14a_set_trigger(bool enable);
 extern void iso14a_set_timeout(uint32_t timeout);
 
-extern void iso14a_clear_trace();
-extern void iso14a_set_tracing(bool enable);
-
 #endif /* __ISO14443A_H */
index 50a5634dc2d694db6f0a64ae1093bb750f020b10..a16cbf16612f9130e29f26ecce116c13669aacfa 100644 (file)
@@ -41,7 +41,7 @@ void MifareReadBlock(uint8_t arg0, uint8_t arg1, uint8_t arg2, uint8_t *datain)
        pcs = &mpcs;\r
 \r
        // clear trace\r
-       iso14a_clear_trace();\r
+       clear_trace();\r
        iso14443a_setup(FPGA_HF_ISO14443A_READER_LISTEN);\r
 \r
        LED_A_ON();\r
@@ -98,7 +98,7 @@ void MifareUC_Auth1(uint8_t arg0, uint8_t *datain){
        LED_B_OFF();\r
        LED_C_OFF();\r
     \r
-       iso14a_clear_trace();\r
+       clear_trace();\r
        iso14443a_setup(FPGA_HF_ISO14443A_READER_LISTEN);\r
 \r
        if(!iso14443a_select_card(uid, NULL, &cuid)) {\r
@@ -162,7 +162,7 @@ void MifareUReadBlock(uint8_t arg0,uint8_t *datain)
        LED_B_OFF();\r
        LED_C_OFF();\r
     \r
-       iso14a_clear_trace();\r
+       clear_trace();\r
        iso14443a_setup(FPGA_HF_ISO14443A_READER_LISTEN);\r
     \r
        int len = iso14443a_select_card(uid, NULL, &cuid);\r
@@ -213,7 +213,7 @@ void MifareReadSector(uint8_t arg0, uint8_t arg1, uint8_t arg2, uint8_t *datain)
        pcs = &mpcs;\r
 \r
        // clear trace\r
-       iso14a_clear_trace();\r
+       clear_trace();\r
 \r
        iso14443a_setup(FPGA_HF_ISO14443A_READER_LISTEN);\r
 \r
@@ -276,7 +276,7 @@ void MifareUReadCard(uint8_t arg0, int arg1, uint8_t *datain)
        if (MF_DBGLEVEL >= MF_DBG_ALL) \r
                Dbprintf("Pages %d",Pages);\r
        \r
-       iso14a_clear_trace();\r
+       clear_trace();\r
        iso14443a_setup(FPGA_HF_ISO14443A_READER_LISTEN);\r
 \r
        int len = iso14443a_select_card(uid, NULL, &cuid);\r
@@ -350,7 +350,7 @@ void MifareWriteBlock(uint8_t arg0, uint8_t arg1, uint8_t arg2, uint8_t *datain)
        pcs = &mpcs;\r
 \r
        // clear trace\r
-       iso14a_clear_trace();\r
+       clear_trace();\r
 \r
        iso14443a_setup(FPGA_HF_ISO14443A_READER_LISTEN);\r
 \r
@@ -411,7 +411,7 @@ void MifareUWriteBlock(uint8_t arg0, uint8_t *datain)
        uint8_t uid[10] = {0x00};\r
         uint32_t cuid;\r
 \r
-        iso14a_clear_trace();\r
+               clear_trace();\r
                iso14443a_setup(FPGA_HF_ISO14443A_READER_LISTEN);\r
 \r
         LED_A_ON();\r
@@ -458,7 +458,7 @@ void MifareUWriteBlock_Special(uint8_t arg0, uint8_t *datain)
        uint8_t uid[10] = {0x00};\r
        uint32_t cuid;\r
 \r
-       iso14a_clear_trace();\r
+       clear_trace();\r
        iso14443a_setup(FPGA_HF_ISO14443A_READER_LISTEN);\r
 \r
        LED_A_ON();\r
@@ -537,8 +537,8 @@ void MifareNested(uint32_t arg0, uint32_t arg1, uint32_t calibrate, uint8_t *dat
        // free eventually allocated BigBuf memory\r
        BigBuf_free();\r
        // clear trace\r
-       iso14a_clear_trace();\r
-       iso14a_set_tracing(false);\r
+       clear_trace();\r
+       set_tracing(false);\r
        \r
        iso14443a_setup(FPGA_HF_ISO14443A_READER_LISTEN);\r
 \r
@@ -709,7 +709,7 @@ void MifareNested(uint32_t arg0, uint32_t arg1, uint32_t calibrate, uint8_t *dat
 \r
        FpgaWriteConfWord(FPGA_MAJOR_MODE_OFF);\r
        LEDsoff();\r
-       iso14a_set_tracing(TRUE);\r
+       set_tracing(TRUE);\r
 }\r
 \r
 //-----------------------------------------------------------------------------\r
@@ -738,8 +738,8 @@ void MifareChkKeys(uint8_t arg0, uint8_t arg1, uint8_t arg2, uint8_t *datain)
        MF_DBGLEVEL = MF_DBG_NONE;\r
        \r
        // clear trace\r
-       iso14a_clear_trace();\r
-       iso14a_set_tracing(TRUE);\r
+       clear_trace();\r
+       set_tracing(TRUE);\r
 \r
        iso14443a_setup(FPGA_HF_ISO14443A_READER_LISTEN);\r
 \r
@@ -829,8 +829,8 @@ void MifareECardLoad(uint32_t arg0, uint32_t arg1, uint32_t arg2, uint8_t *datai
        uint8_t uid[10];\r
 \r
        // clear trace\r
-       iso14a_clear_trace();\r
-       iso14a_set_tracing(false);\r
+       clear_trace();\r
+       set_tracing(false);\r
        \r
        iso14443a_setup(FPGA_HF_ISO14443A_READER_LISTEN);\r
 \r
@@ -931,8 +931,8 @@ void MifareCSetBlock(uint32_t arg0, uint32_t arg1, uint32_t arg2, uint8_t *datai
                LED_B_OFF();\r
                LED_C_OFF();\r
        \r
-               iso14a_clear_trace();\r
-               iso14a_set_tracing(TRUE);\r
+               clear_trace();\r
+               set_tracing(TRUE);\r
                iso14443a_setup(FPGA_HF_ISO14443A_READER_LISTEN);\r
        }\r
 \r
@@ -1049,8 +1049,8 @@ void MifareCGetBlock(uint32_t arg0, uint32_t arg1, uint32_t arg2, uint8_t *datai
                LED_B_OFF();\r
                LED_C_OFF();\r
        \r
-               iso14a_clear_trace();\r
-               iso14a_set_tracing(TRUE);\r
+               clear_trace();\r
+               set_tracing(TRUE);\r
                iso14443a_setup(FPGA_HF_ISO14443A_READER_LISTEN);\r
        }\r
 \r
@@ -1136,7 +1136,7 @@ void Mifare_DES_Auth1(uint8_t arg0, uint8_t *datain){
        uint8_t uid[10] = {0x00};\r
        uint32_t cuid;\r
     \r
-       iso14a_clear_trace();\r
+       clear_trace();\r
        iso14443a_setup(FPGA_HF_ISO14443A_READER_LISTEN);\r
 \r
        int len = iso14443a_select_card(uid, NULL, &cuid);\r
index 59e8469752b5587672004eb37c522a6b531364a9..0cc2963bc3a88c7c7854ea11689d75773f3265bf 100644 (file)
@@ -139,7 +139,7 @@ bool RAMFUNC MfSniffLogic(const uint8_t *data, uint16_t len, uint8_t *parity, ui
 }\r
 \r
 bool RAMFUNC MfSniffSend(uint16_t maxTimeoutMs) {\r
-       if (traceLen && (GetTickCount() > timerData + maxTimeoutMs)) {\r
+       if (BigBuf_get_traceLen() && (GetTickCount() > timerData + maxTimeoutMs)) {\r
                return intMfSniffSend();\r
        }\r
        return FALSE;\r
@@ -149,7 +149,7 @@ bool RAMFUNC MfSniffSend(uint16_t maxTimeoutMs) {
 bool intMfSniffSend() {\r
 \r
        int pckSize = 0;\r
-       int pckLen = traceLen;\r
+       int pckLen = BigBuf_get_traceLen();\r
        int pckNum = 0;\r
        uint8_t *trace = BigBuf_get_addr();\r
        \r
@@ -157,7 +157,7 @@ bool intMfSniffSend() {
        while (pckLen > 0) {\r
                pckSize = MIN(USB_CMD_DATA_SIZE, pckLen);\r
                LED_B_ON();\r
-               cmd_send(CMD_ACK, 1, traceLen, pckSize, trace + traceLen - pckLen, pckSize);\r
+               cmd_send(CMD_ACK, 1, BigBuf_get_traceLen(), pckSize, trace + BigBuf_get_traceLen() - pckLen, pckSize);\r
                LED_B_OFF();\r
 \r
                pckLen -= pckSize;\r
@@ -168,7 +168,7 @@ bool intMfSniffSend() {
        cmd_send(CMD_ACK,2,0,0,0,0);\r
        LED_B_OFF();\r
 \r
-       iso14a_clear_trace();\r
+       clear_trace();\r
        \r
        return TRUE;\r
 }\r
index 0558fb947024e2095d3ad57ad566fb88ba4a506b..c3d4d2c621d3d3252dd06415de5f6084204af37e 100644 (file)
@@ -12,6 +12,7 @@
 #include "util.h"
 #include "string.h"
 #include "apps.h"
+#include "BigBuf.h"
 
 
 
@@ -34,7 +35,7 @@ void print_result(char *name, uint8_t *buf, size_t len) {
 }
 
 size_t nbytes(size_t nbits) {
-       return (nbits/8)+((nbits%8)>0);
+       return (nbits >> 3)+((nbits % 8) > 0);
 }
 
 uint32_t SwapBits(uint32_t value, int nrbits) {
@@ -428,4 +429,3 @@ uint32_t RAMFUNC GetCountSspClk(){
        }
 }
 
-
index a55c41b2bbe2d209eec7a8d468488cebd1f29e78..07a4aa4951b15235873e171dbf107e1a763f1665 100644 (file)
@@ -157,9 +157,28 @@ NXP/Philips CUSTOM COMMANDS
 #define MIFARE_ULC_AUTH_1       0x1A
 #define MIFARE_ULC_AUTH_2        0xAF
 
+/**
+06 00 = INITIATE
+0E xx = SELECT ID (xx = Chip-ID)
+0B = Get UID
+08 yy = Read Block (yy = block number)
+09 yy dd dd dd dd = Write Block (yy = block number; dd dd dd dd = data to be written)
+0C = Reset to Inventory
+0F = Completion
+0A 11 22 33 44 55 66 = Authenticate (11 22 33 44 55 66 = data to authenticate)
+**/
+
 #define ISO14443B_REQB         0x05
 #define ISO14443B_ATTRIB       0x1D
 #define ISO14443B_HALT         0x50
+#define ISO14443B_INITIATE     0x06
+#define ISO14443B_SELECT       0x0E
+#define ISO14443B_GET_UID      0x0B
+#define ISO14443B_READ_BLK     0x08
+#define ISO14443B_WRITE_BLK    0x09
+#define ISO14443B_RESET        0x0C
+#define ISO14443B_COMPLETION   0x0F
+#define ISO14443B_AUTHENTICATE 0x0A
 
 //First byte is 26
 #define ISO15693_INVENTORY     0x01
@@ -287,13 +306,33 @@ void annotateIso15693(char *exp, size_t size, uint8_t* cmd, uint8_t cmdsize)
                }
        }
 }
+
+/**
+06 00 = INITIATE
+0E xx = SELECT ID (xx = Chip-ID)
+0B = Get UID
+08 yy = Read Block (yy = block number)
+09 yy dd dd dd dd = Write Block (yy = block number; dd dd dd dd = data to be written)
+0C = Reset to Inventory
+0F = Completion
+0A 11 22 33 44 55 66 = Authenticate (11 22 33 44 55 66 = data to authenticate)
+**/
+
 void annotateIso14443b(char *exp, size_t size, uint8_t* cmd, uint8_t cmdsize)
 {
        switch(cmd[0]){
        case ISO14443B_REQB   : snprintf(exp,size,"REQB");break;
        case ISO14443B_ATTRIB : snprintf(exp,size,"ATTRIB");break;
        case ISO14443B_HALT   : snprintf(exp,size,"HALT");break;
-       default:                snprintf(exp,size ,"?");break;
+       case ISO14443B_INITIATE     : snprintf(exp,size,"INITIATE");break;
+       case ISO14443B_SELECT       : snprintf(exp,size,"SELECT(%d)",cmd[1]);break;
+       case ISO14443B_GET_UID      : snprintf(exp,size,"GET UID");break;
+       case ISO14443B_READ_BLK     : snprintf(exp,size,"READ_BLK(%d)", cmd[1]);break;
+       case ISO14443B_WRITE_BLK    : snprintf(exp,size,"WRITE_BLK(%d)",cmd[1]);break;
+       case ISO14443B_RESET        : snprintf(exp,size,"RESET");break;
+       case ISO14443B_COMPLETION   : snprintf(exp,size,"COMPLETION");break;
+       case ISO14443B_AUTHENTICATE : snprintf(exp,size,"AUTHENTICATE");break;
+       default                     : snprintf(exp,size ,"?");break;
        }
 
 }
@@ -412,15 +451,18 @@ uint16_t printTraceLine(uint16_t tracepos, uint16_t traceLen, uint8_t *trace, ui
        if (tracepos + data_len + parity_len > traceLen) {
                return traceLen;
        }
-
        uint8_t *frame = trace + tracepos;
        tracepos += data_len;
        uint8_t *parityBytes = trace + tracepos;
        tracepos += parity_len;
 
+
        //--- Draw the data column
+       //char line[16][110];
        char line[16][110];
-       for (int j = 0; j < data_len; j++) {
+
+       for (int j = 0; j < data_len && j/16 < 16; j++) {
+
                int oddparity = 0x01;
                int k;
 
@@ -429,11 +471,17 @@ uint16_t printTraceLine(uint16_t tracepos, uint16_t traceLen, uint8_t *trace, ui
                }
 
                uint8_t parityBits = parityBytes[j>>3];
-
                if (isResponse && (oddparity != ((parityBits >> (7-(j&0x0007))) & 0x01))) {
-                       sprintf(line[j/16]+((j%16)*4), "%02x! ", frame[j]);
+                       snprintf(line[j/16]+(( j % 16) * 4),110, "%02x! ", frame[j]);
+
                } else {
-                       sprintf(line[j/16]+((j%16)*4), "%02x  ", frame[j]);
+                       snprintf(line[j/16]+(( j % 16) * 4),110, "%02x! ", frame[j]);
+               }
+       }
+       if(data_len == 0)
+       {
+               if(data_len == 0){
+                       sprintf(line[0],"<empty trace - possible error>");
                }
        }
        //--- Draw the CRC column
@@ -478,8 +526,8 @@ uint16_t printTraceLine(uint16_t tracepos, uint16_t traceLen, uint8_t *trace, ui
                        annotateIso14443b(explanation,sizeof(explanation),frame,data_len);
        }
 
-       int num_lines = (data_len - 1)/16 + 1;
-       for (int j = 0; j < num_lines; j++) {
+       int num_lines = MIN((data_len - 1)/16 + 1, 16);
+       for (int j = 0; j < num_lines ; j++) {
                if (j == 0) {
                        PrintAndLog(" %9d | %9d | %s | %-64s| %s| %s",
                                (timestamp - first_timestamp),
index cf8658750c8eb48b76705726feecf202156081f7..525ffcc63d1d62a79c14c1845ff8099fe3390b06 100644 (file)
@@ -145,97 +145,10 @@ demodError:
 
 int CmdHF14BList(const char *Cmd)
 {
-       uint8_t *got = malloc(USB_CMD_DATA_SIZE);
-
-       // Query for the actual size of the trace
-       UsbCommand response;
-       GetFromBigBuf(got, USB_CMD_DATA_SIZE, 0);
-       WaitForResponse(CMD_ACK, &response);
-       uint16_t traceLen = response.arg[2];
-       if (traceLen > USB_CMD_DATA_SIZE) {
-               uint8_t *p = realloc(got, traceLen);
-               if (p == NULL) {
-                       PrintAndLog("Cannot allocate memory for trace");
-                       free(got);
-                       return 2;
-               }
-               got = p;
-               GetFromBigBuf(got, traceLen, 0);
-               WaitForResponse(CMD_ACK,NULL);
-       }
-  PrintAndLog("recorded activity: (TraceLen = %d bytes)", traceLen);
-  PrintAndLog(" time  :rssi: who bytes");
-  PrintAndLog("---------+----+----+-----------");
-
-  int i = 0;
-  int prev = -1;
-
-  for(;;) {
-    
-       if(i >= traceLen) { break; }
-
-    bool isResponse;
-    int timestamp = *((uint32_t *)(got+i));
-    if(timestamp & 0x80000000) {
-      timestamp &= 0x7fffffff;
-      isResponse = 1;
-    } else {
-      isResponse = 0;
-    }
-    int metric = *((uint32_t *)(got+i+4));
-
-    int len = got[i+8];
+       PrintAndLog("Deprecated command, use 'hf list 14b' instead");
 
-    if(len > 100) {
-      break;
-    }
-    if(i + len >= traceLen) {
-      break;
-    }
-
-    uint8_t *frame = (got+i+9);
-
-       // Break and stick with current result if buffer was not completely full
-       if (frame[0] == 0x44 && frame[1] == 0x44 && frame[2] == 0x44 && frame[3] == 0x44) break; 
-       
-    char line[1000] = "";
-    int j;
-    for(j = 0; j < len; j++) {
-      sprintf(line+(j*3), "%02x  ", frame[j]);
-    }
-
-    char *crc;
-    if(len > 2) {
-      uint8_t b1, b2;
-      ComputeCrc14443(CRC_14443_B, frame, len-2, &b1, &b2);
-      if(b1 != frame[len-2] || b2 != frame[len-1]) {
-        crc = "**FAIL CRC**";
-      } else {
-        crc = "";
-      }
-    } else {
-      crc = "(SHORT)";
-    }
-
-    char metricString[100];
-    if(isResponse) {
-      sprintf(metricString, "%3d", metric);
-    } else {
-      strcpy(metricString, "   ");
-    }
-
-    PrintAndLog(" +%7d: %s: %s %s %s",
-      (prev < 0 ? 0 : timestamp - prev),
-      metricString,
-      (isResponse ? "TAG" : "   "), line, crc);
-
-    prev = timestamp;
-    i += (len + 9);
-  }
-  free(got);
-  return 0;
+       return 0;
 }
-
 int CmdHF14BRead(const char *Cmd)
 {
   UsbCommand c = {CMD_ACQUIRE_RAW_ADC_SAMPLES_ISO_14443, {strtol(Cmd, NULL, 0), 0, 0}};
@@ -473,7 +386,7 @@ static command_t CommandTable[] =
 {
   {"help",        CmdHelp,        1, "This help"},
   {"demod",       CmdHF14BDemod,  1, "Demodulate ISO14443 Type B from tag"},
-  {"list",        CmdHF14BList,   0, "List ISO 14443 history"},
+  {"list",        CmdHF14BList,   0, "[Deprecated] List ISO 14443b history"},
   {"read",        CmdHF14BRead,   0, "Read HF tag (ISO 14443)"},
   {"sim",         CmdHF14Sim,     0, "Fake ISO 14443 tag"},
   {"simlisten",   CmdHFSimlisten, 0, "Get HF samples as fake tag"},
index c023d57f6a06467bc9ba16e47f303eeda00994b8..b6b5ea444e49981666a42a9f311671baa7f82f92 100644 (file)
 #include "data.h"\r
 #include "lfdemod.h"\r
 \r
-\r
 #define LF_TRACE_BUFF_SIZE 20000 // 32 x 32 x 10  (32 bit times numofblock (7), times clock skip..)\r
 #define LF_BITSSTREAM_LEN 1000 // more then 1000 bits shouldn't happend..  8block * 4 bytes * 8bits = \r
-static int CmdHelp(const char *Cmd);\r
 \r
-// int CmdReadBlk(const char *Cmd)\r
-// {\r
-       // int block = -1;\r
-       // sscanf(Cmd, "%d", &block);\r
-\r
-       // if ((block > 7) | (block < 0)) {\r
-               // PrintAndLog("Block must be between 0 and 7");\r
-               // return 1;\r
-       // }    \r
-\r
-       // UsbCommand c;\r
-       // c.cmd = CMD_T55XX_READ_BLOCK;\r
-       // c.d.asBytes[0] = 0x00;\r
-       // c.arg[0] = 0;\r
-       // c.arg[1] = block;\r
-       // c.arg[2] = 0;\r
-       // SendCommand(&c);\r
-       // WaitForResponse(CMD_ACK, NULL);\r
-       \r
-       // uint8_t data[LF_TRACE_BUFF_SIZE] = {0x00};\r
-       \r
-       // GetFromBigBuf(data,LF_TRACE_BUFF_SIZE,0);  //3560 -- should be offset..\r
-       // WaitForResponseTimeout(CMD_ACK,NULL, 1500);\r
-\r
-       // for (int j = 0; j < LF_TRACE_BUFF_SIZE; j++) {\r
-               // GraphBuffer[j] = (int)data[j];\r
-       // }\r
-       // GraphTraceLen = LF_TRACE_BUFF_SIZE;\r
-       // ManchesterDemod(block);\r
-       // RepaintGraphWindow();\r
-  // return 0;\r
-// }\r
+int usage_t55xx_rd(){\r
+       PrintAndLog("Usage:  lf t55xx rd <block> <password>");\r
+    PrintAndLog("     <block>, block number to read. Between 0-7");\r
+    PrintAndLog("     <password>, OPTIONAL password (8 hex characters)");\r
+    PrintAndLog("");\r
+    PrintAndLog("    sample: lf t55xx rd 0           = try reading data from block 0");\r
+       PrintAndLog("          : lf t55xx rd 0 feedbeef  = try reading data from block 0 using password");\r
+       PrintAndLog("");\r
+       return 0;\r
+}\r
+int usage_t55xx_wr(){\r
+       PrintAndLog("Usage:  lf t55xx wr <block> <data> [password]");\r
+    PrintAndLog("     <block>, block number to read. Between 0-7");\r
+       PrintAndLog("     <data>,  4 bytes of data to write (8 hex characters)");\r
+    PrintAndLog("     [password], OPTIONAL password 4bytes (8 hex characters)");\r
+    PrintAndLog("");\r
+    PrintAndLog("    sample: lf t55xx wd 3 11223344  = try writing data 11223344 to block 3");\r
+       PrintAndLog("          : lf t55xx wd 3 11223344 feedbeef  = try writing data 11223344 to block 3 using password feedbeef");\r
+       PrintAndLog("");\r
+       return 0;\r
+}\r
+int usage_t55xx_trace() {\r
+       PrintAndLog("Usage:  lf t55xx trace  [graph buffer data]");\r
+       PrintAndLog("     [graph buffer data], if set, use Graphbuffer otherwise read data from tag.");\r
+       PrintAndLog("");\r
+       PrintAndLog("     sample: lf t55xx trace");\r
+       PrintAndLog("           : lf t55xx trace 1");\r
+       PrintAndLog("");\r
+       return 0;\r
+}\r
+int usage_t55xx_info() {\r
+       PrintAndLog("Usage:  lf t55xx info [graph buffer data]");\r
+       PrintAndLog("     [graph buffer data], if set, use Graphbuffer otherwise read data from tag.");\r
+       PrintAndLog("");\r
+       PrintAndLog("    sample: lf t55xx info");\r
+       PrintAndLog("          : lf t55xx info 1");\r
+       PrintAndLog("");\r
+       return 0;\r
+}\r
+\r
+int usage_t55xx_dump(){\r
+       PrintAndLog("Usage:  lf t55xx dump <password>");\r
+    PrintAndLog("     <password>, OPTIONAL password 4bytes (8 hex characters)");\r
+       PrintAndLog("");\r
+       PrintAndLog("        sample: lf t55xx dump");\r
+       PrintAndLog("              : lf t55xx dump feedbeef");\r
+       PrintAndLog("");\r
+       return 0;\r
+}\r
+static int CmdHelp(const char *Cmd);\r
 \r
 int CmdReadBlk(const char *Cmd)\r
 {\r
        int invert = 0;\r
        int clk = 0;\r
        int block = -1;\r
+       int password = 0xFFFFFFFF; //default to blank Block 7\r
        int errCnt;\r
        size_t bitlen;\r
-       //int decodedBitlen;\r
+       int maxErr = 100;\r
+    uint8_t askAmp = 0;\r
        uint32_t blockData;\r
        uint8_t bits[MAX_GRAPH_TRACE_LEN] = {0x00};\r
        \r
-       sscanf(Cmd, "%d", &block);\r
        \r
-       if ((block > 7) | (block < 0)) {\r
+       char cmdp = param_getchar(Cmd, 0);\r
+       if (cmdp == 'h' || cmdp == 'H') {\r
+               usage_t55xx_rd();\r
+               return 0;\r
+       }\r
+\r
+       int res = sscanf(Cmd, "%d %x", &block, &password);\r
+\r
+       if ( res < 1 || res > 2 ){\r
+               usage_t55xx_rd();\r
+               return 1;\r
+       }\r
+       \r
+       if ((block < 0) | (block > 7)) {\r
                PrintAndLog("Block must be between 0 and 7");\r
                return 1;\r
+       }       \r
+\r
+       UsbCommand c = {CMD_T55XX_READ_BLOCK, {0, block, 0}};\r
+       c.d.asBytes[0] = 0x0; \r
+\r
+       //Password mode\r
+       if ( res == 2 ) {\r
+               c.arg[2] = password;\r
+               c.d.asBytes[0] = 0x1; \r
        }\r
 \r
-       UsbCommand c = { CMD_T55XX_READ_BLOCK, { 0, block, 0 } };\r
        SendCommand(&c);\r
        if ( !WaitForResponseTimeout(CMD_ACK,NULL,1500) ) {\r
                PrintAndLog("command execution time out");\r
@@ -89,7 +127,7 @@ int CmdReadBlk(const char *Cmd)
 \r
        bitlen = getFromGraphBuf(bits);\r
        \r
-       errCnt = askrawdemod(bits, &bitlen, &clk, &invert);\r
+       errCnt = askrawdemod(bits, &bitlen, &clk, &invert, maxErr, askAmp);\r
        \r
        //throw away static - allow 1 and -1 (in case of threshold command first)\r
        if ( errCnt == -1 || bitlen < 16 ){  \r
@@ -124,81 +162,44 @@ int CmdReadBlk(const char *Cmd)
        return 0;\r
 }\r
 \r
-int CmdReadBlkPWD(const char *Cmd)\r
+int CmdWriteBlk(const char *Cmd)\r
 {\r
-       int Block = -1; //default to invalid block\r
-       int Password = 0xFFFFFFFF; //default to blank Block 7\r
-\r
-\r
-       sscanf(Cmd, "%d %x", &Block, &Password);\r
+       int block = 8; //default to invalid block\r
+       int data = 0xFFFFFFFF; //default to blank Block \r
+       int password = 0xFFFFFFFF; //default to blank Block 7\r
+       \r
+       char cmdp = param_getchar(Cmd, 0);\r
+       if (cmdp == 'h' || cmdp == 'H') {\r
+               usage_t55xx_wr();\r
+               return 0;\r
+       }\r
+  \r
+       int res = sscanf(Cmd, "%d %x %x",&block, &data, &password);\r
+       \r
+       if ( res < 2 || res > 3) {\r
+               usage_t55xx_wr();\r
+               return 1;\r
+       }\r
 \r
-       if ((Block > 7) | (Block < 0)) {\r
+       if (block > 7) {\r
                PrintAndLog("Block must be between 0 and 7");\r
                return 1;\r
-       }       \r
-\r
-       PrintAndLog("Reading page 0 block %d pwd %08X", Block, Password);\r
-\r
-       UsbCommand c = {CMD_T55XX_READ_BLOCK, {0, Block, Password} };\r
-       c.d.asBytes[0] = 0x1; //Password mode\r
-       SendCommand(&c);\r
-       WaitForResponse(CMD_ACK, NULL);\r
-               \r
-       uint8_t data[LF_TRACE_BUFF_SIZE] = {0x00};\r
-\r
-       GetFromBigBuf(data,LF_TRACE_BUFF_SIZE,0);\r
-       WaitForResponseTimeout(CMD_ACK,NULL, 1500);\r
-\r
-       for (int j = 0; j < LF_TRACE_BUFF_SIZE; j++) {\r
-               GraphBuffer[j] = ((int)data[j]);\r
        }\r
-       GraphTraceLen = LF_TRACE_BUFF_SIZE;\r
-       ManchesterDemod(Block); \r
-\r
-       RepaintGraphWindow();\r
-  return 0;\r
-}\r
-\r
-int CmdWriteBlk(const char *Cmd)\r
-{\r
-  int Block = 8; //default to invalid block\r
-  int Data = 0xFFFFFFFF; //default to blank Block \r
-\r
-       sscanf(Cmd, "%d %x", &Block, &Data);\r
-\r
-  if (Block > 7) {\r
-       PrintAndLog("Block must be between 0 and 7");\r
-       return 1;\r
-  }    \r
-\r
-       PrintAndLog("Writing block %d  data %08X", Block, Data);\r
-\r
-       UsbCommand c = {CMD_T55XX_WRITE_BLOCK, {Data, Block, 0}};\r
-  c.d.asBytes[0] = 0x0; //Normal mode\r
-  SendCommand(&c);\r
-  return 0;\r
-}\r
-\r
-int CmdWriteBlkPWD(const char *Cmd)\r
-{\r
-  int Block = 8; //default to invalid block\r
-  int Data = 0xFFFFFFFF; //default to blank Block \r
-  int Password = 0xFFFFFFFF; //default to blank Block 7\r
-\r
-\r
-       sscanf(Cmd, "%d %x %x",&Block, &Data, &Password);\r
-\r
-  if (Block > 7) {\r
-       PrintAndLog("Block must be between 0 and 7");\r
-       return 1;\r
-  }    \r
-\r
-       PrintAndLog("Writing block %d  data %08X  password %08X", Block, Data, Password);\r
-\r
-       UsbCommand c = {CMD_T55XX_WRITE_BLOCK, {Data, Block, Password}};\r
-  c.d.asBytes[0] = 0x1; //Password mode\r
-  SendCommand(&c);\r
-  return 0;\r
+       \r
+       UsbCommand c = {CMD_T55XX_WRITE_BLOCK, {data, block, 0}};\r
+       c.d.asBytes[0] = 0x0; \r
+\r
+       if (res == 2) {\r
+               PrintAndLog("Writing block %d  data %08X", block, data);\r
+       } else {\r
+               //Password mode\r
+               c.arg[2] = password;\r
+               c.d.asBytes[0] = 0x1; \r
+               PrintAndLog("Writing block %d  data %08X  password %08X", block, data, password);\r
+       }\r
+       \r
+       SendCommand(&c);\r
+       return 0;\r
 }\r
 \r
 int CmdReadTrace(const char *Cmd)\r
@@ -206,11 +207,7 @@ int CmdReadTrace(const char *Cmd)
        char cmdp = param_getchar(Cmd, 0);\r
 \r
        if (strlen(Cmd) > 1 || cmdp == 'h' || cmdp == 'H') {\r
-               PrintAndLog("Usage:  lf t55xx trace  [use data from Graphbuffer]");\r
-               PrintAndLog("     [use data from Graphbuffer], if not set, try reading data from tag.");\r
-               PrintAndLog("");\r
-               PrintAndLog("     sample: lf t55xx trace");\r
-               PrintAndLog("           : lf t55xx trace 1");\r
+               usage_t55xx_trace();\r
                return 0;\r
        }\r
 \r
@@ -297,15 +294,9 @@ int CmdInfo(const char *Cmd){
        char cmdp = param_getchar(Cmd, 0);\r
 \r
        if (strlen(Cmd) > 1 || cmdp == 'h' || cmdp == 'H') {\r
-               PrintAndLog("Usage:  lf t55xx info  [use data from Graphbuffer]");\r
-               PrintAndLog("     [use data from Graphbuffer], if not set, try reading data from tag.");\r
-               PrintAndLog("");\r
-               PrintAndLog("    sample: lf t55xx info");\r
-               PrintAndLog("    sample: lf t55xx info 1");\r
+               usage_t55xx_info();\r
                return 0;\r
-       }\r
-\r
-       if ( strlen(Cmd) == 0 ){\r
+       } else {\r
                CmdReadBlk("0");\r
        }       \r
 \r
@@ -358,17 +349,16 @@ int CmdInfo(const char *Cmd){
 \r
 int CmdDump(const char *Cmd){\r
 \r
-       char cmdp = param_getchar(Cmd, 0);\r
-       char s[20];\r
+       char s[20] = {0x00};\r
        uint8_t pwd[4] = {0x00};\r
-       bool hasPwd = ( strlen(Cmd) > 0);\r
-       \r
+\r
+       char cmdp = param_getchar(Cmd, 0);\r
        if ( cmdp == 'h' || cmdp == 'H') {\r
-               PrintAndLog("Usage:  lf t55xx dump <password>");\r
-               PrintAndLog("        sample: lf t55xx dump FFFFFFFF");\r
+               usage_t55xx_dump();\r
                return 0;\r
        }\r
-       \r
+\r
+       bool hasPwd = ( strlen(Cmd) > 0);       \r
        if ( hasPwd ){\r
                if (param_gethex(Cmd, 0, pwd, 8)) {\r
                        PrintAndLog("password must include 8 HEX symbols");\r
@@ -380,11 +370,10 @@ int CmdDump(const char *Cmd){
                memset(s,0,sizeof(s));\r
                if ( hasPwd ) {\r
                        sprintf(s,"%d %02x%02x%02x%02x", i, pwd[0],pwd[1],pwd[2],pwd[3]);\r
-                       CmdReadBlkPWD(s);\r
                } else {\r
                        sprintf(s,"%d", i);\r
-                       CmdReadBlk(s);\r
                }\r
+               CmdReadBlk(s);\r
        }\r
        return 0;\r
 }\r
@@ -536,14 +525,11 @@ uint32_t PackBits(uint8_t start, uint8_t len, uint8_t* bits){
 static command_t CommandTable[] =\r
 {\r
   {"help",   CmdHelp,        1, "This help"},\r
-  {"rd",     CmdReadBlk,     0, "<block> -- Read T55xx block data (page 0)"},\r
-  {"rdpwd",  CmdReadBlkPWD,  0, "<block> <password> -- Read T55xx block data with password mode"},\r
-  {"wr",     CmdWriteBlk,    0, "<block> <data> -- Write T55xx block data (page 0)"},\r
-  {"wrpwd",  CmdWriteBlkPWD, 0, "<block> <password> <data> -- Write T55xx block data with password"},\r
+  {"rd",     CmdReadBlk,     0, "<block> [password] -- Read T55xx block data (page 0) [optional password]"},\r
+  {"wr",     CmdWriteBlk,    0, "<block> <data> [password] -- Write T55xx block data (page 0) [optional password]"},\r
   {"trace",  CmdReadTrace,   0, "[1] Read T55xx traceability data (page 1/ blk 0-1)"},\r
   {"info",   CmdInfo,        0, "[1] Read T55xx configuration data (page 0/ blk 0)"},\r
-  {"dump",   CmdDump,        0, "[password] Dump T55xx card block 0-7. optional with password"},\r
-  //{"fsk",    CmdIceFsk,      0, "FSK demod"},\r
+  {"dump",   CmdDump,        0, "[password] Dump T55xx card block 0-7. [optional password]"},\r
   {"man",    CmdIceManchester,      0, "Manchester demod (with SST)"},\r
   {NULL, NULL, 0, NULL}\r
 };\r
index 10ae1310692d4ba03c5526a3aa21329fea2bcdbd..6645a99ea5e5f7519380a6d2dc306c1cc9ae879f 100644 (file)
@@ -108,7 +108,7 @@ int manchester_decode( int * data, const size_t len, uint8_t * dataout,  size_t
        DetectHighLowInGraph(&high, &low, TRUE); 
 
        /* get clock */
-       clock = GetClock("",0, 0);      
+       clock = GetAskClock("",false, false);
 
        startindex = DetectFirstTransition(data, len, high);
   
index 986c94461052a9560ddeaf21477bf6495621f2f3..80086f49c3acf5521c148651f1fd142179095d60 100644 (file)
@@ -7,4 +7,12 @@
 #
 
 # proxmark3
+ACTION!="add|change", GOTO="mm_usb_device_blacklist_end"
+SUBSYSTEM!="tty", GOTO="mm_ignore"
+
+ATTRS{idVendor}=="2d2d" ATTRS{idProduct}=="504d", ENV{ID_MM_DEVICE_IGNORE}="1" SYMLINK+="pm3-%n"
+
+LABEL="mm_ignore"
 ATTRS{idVendor}=="2d2d" ATTRS{idProduct}=="504d", ENV{ID_MM_DEVICE_IGNORE}="1"
+
+LABEL="mm_usb_device_blacklist_end"
Impressum, Datenschutz