FIX: the 14b crc was called wrong in LUA. You enter a hexstring already, and get...

diff --git a/client/lualibs/utils.lua b/client/lualibs/utils.lua
index bf62fc881429026b78ac790c182cbf4b67973a39..39f8bca2041b3a7509496868403a2950672de565 100644 (file)
--- a/client/lualibs/utils.lua
+++ b/client/lualibs/utils.lua
@@ -75,9 +75,9 @@ local Utils =
                if #s == 0 then return nil end\r
                if  type(s) == 'string' then\r
                        local utils = require('utils')\r
-                       local ascii = utils.ConvertHexToAscii(s)\r
-                       local hashed = core.iso14443b_crc(ascii)\r
-                       return utils.ConvertAsciiToHex(hashed)\r
+                       return utils.ConvertAsciiToHex(\r
+                                                       core.iso14443b_crc(s)\r
+                                                       )\r
                end\r
                return nil              \r
        end,\r

diff --git a/client/scripting.c b/client/scripting.c
index 6eef88ba31a427b9038c439dfe035976009a815a..aae8c3ca6845ff09f281373ec3cbf03dd4e91122 100644 (file)
--- a/client/scripting.c
+++ b/client/scripting.c
@@ -82,7 +82,6 @@ static int l_WaitForResponseTimeout(lua_State *L){
     }
 
     UsbCommand response;
-
     if(WaitForResponseTimeout(cmd, &response, ms_timeout))
     {
         //Push it as a string
@@ -222,18 +221,17 @@ static int l_iso14443b_crc(lua_State *L)
                      unsigned char *TransmitFirst,
                      unsigned char *TransmitSecond)
        */
-       unsigned char buf[USB_CMD_DATA_SIZE];
-    size_t len = 0;    
-    const char *data = luaL_checklstring(L, 1, &len);
-       if (USB_CMD_DATA_SIZE < len)
-               len =  USB_CMD_DATA_SIZE-2;
+    size_t size = 0;   
+    const char *data = luaL_checklstring(L, 1, &size);
+
+       unsigned char buf[USB_CMD_DATA_SIZE] = {0x00};
        
-       for (int i = 0; i < len; i += 2) {
-               sscanf(&data[i], "%02x", (unsigned int *)&buf[i / 2]);
-       }       
-       ComputeCrc14443(CRC_14443_B, buf, len, &buf[len], &buf[len+1]);
+       for (int i = 0; i < size; i += 2)
+               sscanf(&data[i], "%02x", (unsigned int *)&buf[i / 2]);  
        
-    lua_pushlstring(L, (const char *)&buf, len+2);
+       size /= 2;      
+       ComputeCrc14443(CRC_14443_B, buf, size, &buf[size], &buf[size+1]);      
+    lua_pushlstring(L, (const char *)&buf, size+2);
     return 1;
 }