add force_align_arg_pointer attribute to all callback functions

* inspired by issue #404 and respective fix PR #538
* possible fix for mysterious crashes, e.g. issue #497 and http://www.proxmark.org/forum/viewtopic.php?id=5388

diff --git a/client/cmdhfmfhard.c b/client/cmdhfmfhard.c
index 69ad898db4ead30997ce98ede7837db0b886d2cb..cf19436c39614e154be2a46e85ea7d0a64561ae2 100644 (file)
--- a/client/cmdhfmfhard.c
+++ b/client/cmdhfmfhard.c
@@ -1158,7 +1158,13 @@ static bool timeout(void)
 }
 
 
 }
 
 

-static void *check_for_BitFlipProperties_thread(void *args)
+static void 
+#ifdef __has_attribute
+#if __has_attribute(force_align_arg_pointer)
+__attribute__((force_align_arg_pointer)) 
+#endif
+#endif
+*check_for_BitFlipProperties_thread(void *args)

 {
        uint8_t first_byte = ((uint8_t *)args)[0];
        uint8_t last_byte = ((uint8_t *)args)[1];
 {
        uint8_t first_byte = ((uint8_t *)args)[0];
        uint8_t last_byte = ((uint8_t *)args)[1];


@@ -1906,7 +1912,13 @@ static void init_book_of_work(void)
 }
 
 
 }
 
 

-static void *generate_candidates_worker_thread(void *args)
+static void 
+#ifdef __has_attribute
+#if __has_attribute(force_align_arg_pointer)
+__attribute__((force_align_arg_pointer)) 
+#endif
+#endif
+*generate_candidates_worker_thread(void *args)

 {
        uint16_t *sum_args = (uint16_t *)args;
        uint16_t sum_a0 = sums[sum_args[0]];
 {
        uint16_t *sum_args = (uint16_t *)args;
        uint16_t sum_a0 = sums[sum_args[0]];

diff --git a/client/mifarehost.c b/client/mifarehost.c
index d204bf12c87e9a3358eba16c392e05a80ae980dc..dd656ee1f24253677c4d1b5199db28203e784a33 100644 (file)
--- a/client/mifarehost.c
+++ b/client/mifarehost.c
@@ -295,7 +295,13 @@ typedef
 \r
 \r
 // wrapper function for multi-threaded lfsr_recovery32\r
 \r
 \r
 // wrapper function for multi-threaded lfsr_recovery32\r

-void* nested_worker_thread(void *arg)\r
+void\r
+#ifdef __has_attribute\r
+#if __has_attribute(force_align_arg_pointer)\r
+__attribute__((force_align_arg_pointer)) \r
+#endif\r
+#endif\r
+*nested_worker_thread(void *arg)\r

 {\r
        struct Crypto1State *p1;\r
        StateList_t *statelist = arg;\r
 {\r
        struct Crypto1State *p1;\r
        StateList_t *statelist = arg;\r


@@ -309,6 +315,7 @@ void* nested_worker_thread(void *arg)
        return statelist->head.slhead;\r
 }\r
 \r
        return statelist->head.slhead;\r
 }\r
 \r

+\r

 int mfnested(uint8_t blockNo, uint8_t keyType, uint8_t *key, uint8_t trgBlockNo, uint8_t trgKeyType, uint8_t *resultKey, bool calibrate)\r
 {\r
        uint16_t i;\r
 int mfnested(uint8_t blockNo, uint8_t keyType, uint8_t *key, uint8_t trgBlockNo, uint8_t trgKeyType, uint8_t *resultKey, bool calibrate)\r
 {\r
        uint16_t i;\r

diff --git a/client/proxmark3.c b/client/proxmark3.c
index 99ba9fbad77ec9dbcea40bc0b36074ea7914b0e5..95dd7cb948168a17ccbc841bd097ced81c763d70 100644 (file)
--- a/client/proxmark3.c
+++ b/client/proxmark3.c
@@ -67,7 +67,14 @@ struct receiver_arg {
 byte_t rx[sizeof(UsbCommand)];
 byte_t* prx = rx;
 
 byte_t rx[sizeof(UsbCommand)];
 byte_t* prx = rx;
 

-static void *uart_receiver(void *targ) {
+
+static void
+#ifdef __has_attribute
+#if __has_attribute(force_align_arg_pointer)
+__attribute__((force_align_arg_pointer)) 
+#endif
+#endif
+*uart_receiver(void *targ) {

        struct receiver_arg *arg = (struct receiver_arg*)targ;
        size_t rxlen;
 
        struct receiver_arg *arg = (struct receiver_arg*)targ;
        size_t rxlen;
 


@@ -95,7 +102,13 @@ static void *uart_receiver(void *targ) {
 }
 
 
 }
 
 

-void main_loop(char *script_cmds_file, char *script_cmd, bool usb_present) {
+void
+#ifdef __has_attribute
+#if __has_attribute(force_align_arg_pointer)
+__attribute__((force_align_arg_pointer)) 
+#endif
+#endif
+main_loop(char *script_cmds_file, char *script_cmd, bool usb_present) {

        struct receiver_arg rarg;
        char *cmd = NULL;
        pthread_t reader_thread;
        struct receiver_arg rarg;
        char *cmd = NULL;
        pthread_t reader_thread;