]> git.zerfleddert.de Git - proxmark3-svn/log
proxmark3-svn
8 years agoCHG: Adding clarity to the command helptext.
iceman1001 [Thu, 1 Sep 2016 18:36:42 +0000 (20:36 +0200)]
CHG: Adding clarity to the command helptext.

8 years agoCHG: Supressing output for LF or HF antenna values if zero, in 'hw tune' command
iceman1001 [Thu, 1 Sep 2016 18:36:10 +0000 (20:36 +0200)]
CHG:  Supressing output for LF or HF antenna values if zero,  in 'hw tune' command

8 years agoFIX: added a sanity check in preamble search to make sure it doesn't look out-of...
iceman1001 [Thu, 1 Sep 2016 18:34:56 +0000 (20:34 +0200)]
FIX: added a sanity check in preamble search to make sure it doesn't look out-of-bounds in the memcmp call

8 years agoCHG: removed call to bigbuff free.
iceman1001 [Thu, 1 Sep 2016 18:31:22 +0000 (20:31 +0200)]
CHG: removed call to bigbuff free.

8 years agoCHG: a different version string when compiling on systems without git or the release...
iceman1001 [Thu, 1 Sep 2016 14:11:31 +0000 (16:11 +0200)]
CHG:  a different version string when compiling on systems without git or the release tags.

8 years agoFIX: Only need to print a uint32_t,
iceman1001 [Thu, 1 Sep 2016 14:10:25 +0000 (16:10 +0200)]
FIX: Only need to print a uint32_t,

8 years agoFIX: bug in nextwatch demod, which if the found psk bits was smaller than the preamb...
iceman1001 [Thu, 1 Sep 2016 14:09:31 +0000 (16:09 +0200)]
FIX:  bug in nextwatch demod, which if the found psk bits was smaller than the preamble the client crashed.
REM: removed some debugstatements

8 years agoCHG: reverting use of bigbuff, because I forgot that every switch between LF/HF...
iceman1001 [Wed, 31 Aug 2016 22:52:54 +0000 (00:52 +0200)]
CHG:  reverting use of bigbuff,  because I forgot that every switch between LF/HF images destroys BigBuff.

8 years agoCHG: removed a redundant include to strings.h, which made compilation errors on...
iceman1001 [Wed, 31 Aug 2016 20:10:06 +0000 (22:10 +0200)]
CHG:  removed a redundant include to strings.h, which made compilation errors on OS X

8 years agoFIX: should fix the typedefintion error for OS X regarding bool cmd_send
iceman1001 [Wed, 31 Aug 2016 19:11:57 +0000 (21:11 +0200)]
FIX:  should fix the typedefintion error for OS X regarding  bool cmd_send

8 years agoCHG: A repaint the plot window should be done to make sure its visual.
iceman1001 [Wed, 31 Aug 2016 17:24:18 +0000 (19:24 +0200)]
CHG:  A repaint the plot window should be done to make sure its visual.

8 years agoCHG: the loop in main, for usb_poll_validate_length, shouldn't do anything, it...
iceman1001 [Wed, 31 Aug 2016 17:22:52 +0000 (19:22 +0200)]
CHG:  the loop in main,  for usb_poll_validate_length, shouldn't do anything,  it should be done inside the next call to usb_read...

8 years agoCHG: this timeout doesn't influence the bad performance with my older pm3 device...
iceman1001 [Wed, 31 Aug 2016 17:18:48 +0000 (19:18 +0200)]
CHG:  this timeout doesn't influence the bad performance with my older pm3 device (green pcb).  I think its too slow.

8 years agoFIX: Forget that the prng was 0x8000 length and not 0xFFFF. Sorry. Also returned...
iceman1001 [Wed, 31 Aug 2016 17:17:39 +0000 (19:17 +0200)]
FIX:  Forget that the prng was 0x8000 length and not 0xFFFF.  Sorry.  Also returned to the decomposed loop.  Don't know if this armsrc optimises this at compilation time. Does someone know?

CHG: returned the iso14443a_setup order, it might influence my older PM3 device.

*Note*  my Elechouse revisions PM3 works great with this but my older xpfga (green pcb) is hopeless.  It can't fix onto the nonces in 'hf mf mifare'  I think its too slow.

8 years agoADD: added a simple averging filter function. input parameter K, can be 1 to 8
iceman1001 [Mon, 29 Aug 2016 18:29:31 +0000 (20:29 +0200)]
ADD:  added a simple averging filter function. input parameter K, can be 1 to 8

ref: http://www.edn.com/design/systems-design/4320010/A-simple-software-lowpass-filter-suits-embedded-system-applications

8 years agoFIX: the check for formatlen was wrong.
iceman1001 [Fri, 26 Aug 2016 20:31:45 +0000 (22:31 +0200)]
FIX:  the check for formatlen was wrong.

Still missing the other formats,  only 26bit in this one.

8 years agoCHG: starting to add the legic changes.. *work in progress*
iceman1001 [Fri, 26 Aug 2016 15:19:27 +0000 (17:19 +0200)]
CHG: starting to add the legic changes..  *work in progress*

8 years agoFIX: minor adjustments to 'lf awid bruteforce'
iceman1001 [Fri, 26 Aug 2016 15:18:48 +0000 (17:18 +0200)]
FIX: minor adjustments to 'lf awid bruteforce'
FIX: making the 'lf hid bruteforce' to work the same way as the awid one..

8 years agoFIX: fixes the broken build,...
iceman1001 [Fri, 26 Aug 2016 15:17:40 +0000 (17:17 +0200)]
FIX:  fixes the broken build,...
FIX:  increased the timeout,  to make 'hf mf chk' work better.

8 years agoFIX: 'lf awid bruteforce' cleaning up all debug messages
iceman1001 [Fri, 26 Aug 2016 14:35:30 +0000 (16:35 +0200)]
FIX:  'lf awid bruteforce'  cleaning up all debug messages

8 years agoFIX: Better udp_csr handeling. Usb messages gets to the device better, which makes...
iceman1001 [Fri, 26 Aug 2016 14:22:56 +0000 (16:22 +0200)]
FIX:  Better udp_csr handeling.  Usb messages gets to the device better,  which makes "lf awid bruteforce" work :)

8 years agoCHG: forgot a semicolon...
iceman1001 [Wed, 24 Aug 2016 13:05:10 +0000 (15:05 +0200)]
CHG: forgot a semicolon...

8 years agoCHG: removed some extra time to sync,
iceman1001 [Wed, 24 Aug 2016 13:01:36 +0000 (15:01 +0200)]
CHG: removed some extra time to sync,
CHG: first_try ,  it must recalibrate all the times when it comes from the client.

8 years agosome text changes.
iceman1001 [Wed, 24 Aug 2016 12:58:50 +0000 (14:58 +0200)]
some text changes.

8 years agoCHG: added a verification to see if the found candidate key was able to validate...
iceman1001 [Wed, 24 Aug 2016 12:10:30 +0000 (14:10 +0200)]
CHG:   added a verification to see if the found candidate key was able to validate against tag.  If not ok,  start darkside attack again.

8 years agoFIX: the underlaying bug on deviceside code. The SSPCLOCK wasn't reset to zero somet...
iceman1001 [Wed, 24 Aug 2016 10:37:31 +0000 (12:37 +0200)]
FIX: the underlaying bug on deviceside code.  The SSPCLOCK wasn't reset to zero sometimes. More specific,  TC2 wasn't reset cause all sorts of timing issues for the device side randomly.  Like 'hf mf mifare',  like iclass,  like 'hf mf sim'  etc etc.

8 years agoCHG: change the number of calls to prng_successor was done. Fewer should mean faster :)
iceman1001 [Wed, 24 Aug 2016 10:35:24 +0000 (12:35 +0200)]
CHG:  change the number of calls to prng_successor was done.  Fewer should mean faster :)

8 years agoCHG: fixed the collapsing comments when opening this file in notepad++ Need spaces...
iceman1001 [Wed, 24 Aug 2016 10:34:34 +0000 (12:34 +0200)]
CHG: fixed the collapsing comments when opening this file in notepad++  Need spaces between // text  or  /* ...

8 years agoREM: removed an test function
iceman1001 [Wed, 24 Aug 2016 10:32:43 +0000 (12:32 +0200)]
REM: removed an test function

8 years agoCHG: Changed the number of times the call to prng_successor is called.
iceman1001 [Wed, 24 Aug 2016 10:32:05 +0000 (12:32 +0200)]
CHG:  Changed the number of times the call to prng_successor is called.

8 years agoCHG: syntax suger.
iceman1001 [Wed, 24 Aug 2016 10:31:09 +0000 (12:31 +0200)]
CHG: syntax suger.

8 years agoCHG: updated Reveng version from 1.4.0 -> 1.4.4 .
iceman1001 [Sun, 21 Aug 2016 18:51:29 +0000 (20:51 +0200)]
CHG:  updated Reveng version from 1.4.0 -> 1.4.4 .
---snippet from their update log:

1.4.4 27 July 2016

    Added 5 new algorithms, CRC-8/AUTOSAR, CRC-8/OPENSAFETY, CRC-16/OPENSAFETY-A, CRC-16/OPENSAFETY-B and CRC-32/AUTOSAR from the CRC Catalogue.
    Added a build option to verify the order of the preset and alias tables at compile time.

1.4.3 14 July 2016

    Added algorithm CRC-16/CMS from the CRC Catalogue.

1.4.2 8 July 2016

    Added algorithm CRC-16/PROFIBUS from the CRC Catalogue.

1.4.1a 29 June 2016

    Fixed a regression that caused the Windows release to crash on older systems.

1.4.1 27 June 2016

    -P sets the Width value just like -k.
    pcmp() quickly returns when the comparands are identical.
    Added resources for the Windows executable.

8 years agoADD: Mifare Desfire defines
iceman1001 [Sun, 14 Aug 2016 15:38:54 +0000 (17:38 +0200)]
ADD:  Mifare Desfire defines

8 years agochg; syntax suger
iceman1001 [Sun, 14 Aug 2016 15:38:11 +0000 (17:38 +0200)]
chg;  syntax suger

8 years agohelp text adjustments
iceman1001 [Sun, 14 Aug 2016 15:11:42 +0000 (17:11 +0200)]
help text adjustments

8 years agoADD: added a sanity check in T55x7 commands info/trace/detect against useing the...
iceman1001 [Sun, 14 Aug 2016 15:04:40 +0000 (17:04 +0200)]
ADD:  added a sanity check in T55x7 commands info/trace/detect against useing the commands when device is in offline but user didn't use '1' in arguments.

8 years agoadd: annotage Mifare Desfire. from https://github.com/JohannesStoye/proxmark3/commi...
iceman1001 [Sun, 14 Aug 2016 14:29:39 +0000 (16:29 +0200)]
add:  annotage Mifare Desfire.  from https://github.com/JohannesStoye/proxmark3/commit/3102c1bae358566e112e465e58da27ffb7219bc9#diff-93cfa90a992ea759349344d0de98029e
Thanks @johannesStoye

8 years agochg: remove a char..
iceman1001 [Wed, 10 Aug 2016 14:29:23 +0000 (16:29 +0200)]
chg:  remove a char..

8 years agoCHG: more struct errors.. my bad,
iceman1001 [Wed, 10 Aug 2016 14:28:23 +0000 (16:28 +0200)]
CHG: more struct errors.. my bad,

8 years agoCHG: removed some debug statements, added another. Change the crapto1.c, lets...
iceman1001 [Wed, 10 Aug 2016 14:25:56 +0000 (16:25 +0200)]
CHG:  removed some debug statements, added another.  Change the crapto1.c,  lets see if the special attack works better now against chinese clones.

8 years agoCHG: minor code cleaning in 'hf 14a reader'
iceman1001 [Wed, 10 Aug 2016 14:24:49 +0000 (16:24 +0200)]
CHG:  minor code cleaning in 'hf 14a reader'

8 years agoCHG: on a slow usb connection it seems the pingcmd which stops the bruteforce on...
iceman1001 [Wed, 10 Aug 2016 14:23:59 +0000 (16:23 +0200)]
CHG:  on a slow usb connection it seems the pingcmd which stops the bruteforce on deviceside doesnt get there. Lets send three pings to make sure the device gets it.

8 years agoFIX: at least now the special zero parity attack, repeats and doesn't crash. Howev...
iceman1001 [Wed, 10 Aug 2016 08:55:29 +0000 (10:55 +0200)]
FIX:  at least now the special zero parity attack,  repeats and doesn't crash.  However it doesn't find the key either :(

8 years agoCHG; still looking at 14b, this time started to look at the tracelog times not working.
iceman1001 [Tue, 9 Aug 2016 21:13:18 +0000 (23:13 +0200)]
CHG; still looking at 14b,  this time started to look at the tracelog times not working.

8 years agostarted fixing the paritiy == 0 special attack against chinese clones with bad prng...
iceman1001 [Tue, 9 Aug 2016 21:11:07 +0000 (23:11 +0200)]
started fixing the paritiy == 0 special attack against chinese clones with bad prng, which hasnt been working for ages.

8 years agofix: wrong spelling
iceman1001 [Tue, 9 Aug 2016 10:15:26 +0000 (12:15 +0200)]
fix:  wrong spelling

8 years agoFIX: Travis CI complains about missing stdbool.h includes
iceman1001 [Tue, 9 Aug 2016 10:11:11 +0000 (12:11 +0200)]
FIX:  Travis CI complains about missing stdbool.h includes

8 years agoADD: 'lf awid brute' is now possible to give a starting cardnumber. if given, the...
iceman1001 [Tue, 9 Aug 2016 09:56:06 +0000 (11:56 +0200)]
ADD: 'lf awid brute' is now possible to give a starting cardnumber.  if given,  the bruteforce loops from it as a mid point. Testing one step up, then one step down until it reaches 65535 and 0.
CHG: 'lf awid brute' inputs are now changed, take notice to new format.

8 years agosyntax suger
iceman1001 [Tue, 9 Aug 2016 07:12:16 +0000 (09:12 +0200)]
syntax suger
chg:  added clearCommandBuffer(); before calls to sendcommand.

8 years agoCHG: textual fixes in help text
iceman1001 [Tue, 9 Aug 2016 07:10:26 +0000 (09:10 +0200)]
CHG: textual fixes in help text
CHG: better exit message for 'lf awid bruteforce'

8 years agoFIX: delay was parsed incorrect into a uint8_t...
iceman1001 [Mon, 8 Aug 2016 20:17:15 +0000 (22:17 +0200)]
FIX: delay was parsed incorrect into a uint8_t...
CHG: help text fixed

8 years agoADD: Added a delay in ms to 'lf awid brute' Thanks to @crayon for the idea.
iceman1001 [Mon, 8 Aug 2016 20:09:51 +0000 (22:09 +0200)]
ADD:  Added a delay in ms to 'lf awid brute'  Thanks to @crayon for the idea.

8 years agoFIX: the cmdline parsing was a bit too hard. Thanks to @crayon for pointing out...
iceman1001 [Mon, 8 Aug 2016 19:27:53 +0000 (21:27 +0200)]
FIX:   the cmdline parsing was a bit too hard. Thanks to @crayon for pointing out there were a bug here.

8 years agolayouts.
iceman1001 [Mon, 8 Aug 2016 17:02:46 +0000 (19:02 +0200)]
layouts.

8 years agoeven more..
iceman1001 [Mon, 8 Aug 2016 17:00:53 +0000 (19:00 +0200)]
even more..

8 years agomore layout
iceman1001 [Mon, 8 Aug 2016 17:00:09 +0000 (19:00 +0200)]
more layout

8 years agocorrecting the layout...
iceman1001 [Mon, 8 Aug 2016 16:58:05 +0000 (18:58 +0200)]
correcting the layout...

8 years agotextual changes.
iceman1001 [Mon, 8 Aug 2016 16:51:34 +0000 (18:51 +0200)]
textual changes.

8 years agoCHG: added the libncurses5-dev instruction for COMPILING.txt
iceman1001 [Mon, 8 Aug 2016 16:07:36 +0000 (18:07 +0200)]
CHG: added the  libncurses5-dev instruction for COMPILING.txt
CHG: updated the readme with latest changes from changelog

8 years agotextual changes
iceman1001 [Mon, 8 Aug 2016 15:56:04 +0000 (17:56 +0200)]
textual changes

8 years agoADD: J-Run's 2nd phase tool mf_key_brute ref: https://github.com/J-Run/mf_key_brute...
iceman1001 [Mon, 8 Aug 2016 15:49:30 +0000 (17:49 +0200)]
ADD:  J-Run's 2nd phase tool mf_key_brute  ref: https://github.com/J-Run/mf_key_brute   Estimated time to search keyspace is ~18min.

J_Run's 2nd phase of multiple sector nested authentication key recovery
You have a known 4 last bytes of a key recovered with mf_nonce_brute tool.
First 2 bytes of key will be bruteforced

Usage:  hf mf keybrute [h] <block number> <A|B> <key>
options:
      h               this help
      <block number>  target block number
      <A|B>           target key type
      <key>           candidate key from mf_nonce_brute tool
samples:
           hf mf keybrute 1 A 000011223344

8 years agoMerge branch 'master' of https://github.com/iceman1001/proxmark3
iceman1001 [Mon, 8 Aug 2016 05:46:12 +0000 (07:46 +0200)]
Merge branch 'master' of https://github.com/iceman1001/proxmark3

8 years agoMerge pull request #21 from alexgrin/iceman_master
Iceman [Mon, 8 Aug 2016 05:43:26 +0000 (07:43 +0200)]
Merge pull request #21 from alexgrin/iceman_master

FIX: erroneous semicolon

8 years agoFIX: erroneous semicolon
Alexis Green [Mon, 8 Aug 2016 03:07:25 +0000 (20:07 -0700)]
FIX: erroneous semicolon

8 years agofix: forgot something small.. sloppy.
iceman1001 [Sun, 7 Aug 2016 20:15:35 +0000 (22:15 +0200)]
fix:  forgot something small.. sloppy.

8 years agoADD: added the 'max frame size' parameter set, valid sizes: 16|24|32|40|48|64...
iceman1001 [Sun, 7 Aug 2016 20:05:10 +0000 (22:05 +0200)]
ADD:  added the 'max frame size' parameter set,   valid sizes: 16|24|32|40|48|64|96|128|256
it can be verified by setting debuglevel to 3 or more.

8 years agoCHG: fixes to match the new arguments to the darkside attack (keytype A|B and blockn...
iceman1001 [Sun, 7 Aug 2016 19:19:11 +0000 (21:19 +0200)]
CHG:  fixes to match the new arguments to the darkside attack (keytype A|B and blocknumber) in mifare_autopwn.lua script.

8 years agoCHG: moved some TEA crypto stuff from 14b into analyse.
iceman1001 [Sun, 7 Aug 2016 19:08:17 +0000 (21:08 +0200)]
CHG:  moved some TEA crypto stuff from 14b into analyse.

8 years agoCHG: increased the script-filename column width from 16 to 21.
iceman1001 [Sun, 7 Aug 2016 19:05:09 +0000 (21:05 +0200)]
CHG: increased the script-filename column width from 16 to 21.

8 years agotextual changes.
iceman1001 [Sun, 7 Aug 2016 16:50:25 +0000 (18:50 +0200)]
textual changes.

8 years agoCHG: applied some of the changes unto "hf 14b snoop" *untested* Hard to test without...
iceman1001 [Sun, 7 Aug 2016 16:49:36 +0000 (18:49 +0200)]
CHG:  applied some of the changes unto "hf 14b snoop" *untested* Hard to test without a proper reader/tag to snoop

8 years agoCHG: iso14443b.c got some more love. using the "hf 14b raw" command gives now...
iceman1001 [Sun, 7 Aug 2016 15:49:33 +0000 (17:49 +0200)]
CHG:  iso14443b.c  got some more love.  using the "hf 14b raw" command gives now a much stabil read from more distances than before.

8 years agoMerge pull request #20 from alexgrin/iceman_master
Iceman [Sat, 6 Aug 2016 20:42:39 +0000 (22:42 +0200)]
Merge pull request #20 from alexgrin/iceman_master

FIX: Coverity badge link now works.

8 years agoFIX: Coverity badge link now works.
Alexis Green [Thu, 4 Aug 2016 22:52:54 +0000 (15:52 -0700)]
FIX: Coverity badge link now works.

8 years agoCHG: some calyspo stuff
iceman1001 [Thu, 4 Aug 2016 19:57:40 +0000 (21:57 +0200)]
CHG:  some calyspo stuff

8 years agoCHG: marshmellow42 's improved "hf mf sim x"
iceman1001 [Thu, 4 Aug 2016 19:57:18 +0000 (21:57 +0200)]
CHG:  marshmellow42 's improved "hf mf sim x"

8 years agoCHG: moved a defince arraylen into util.h and changed to uppercase.
iceman1001 [Thu, 4 Aug 2016 19:54:11 +0000 (21:54 +0200)]
CHG: moved a defince arraylen into util.h  and changed to uppercase.

8 years agoCHG: trying to unify the crc algos in one place.
iceman1001 [Thu, 4 Aug 2016 19:52:32 +0000 (21:52 +0200)]
CHG: trying to unify the crc algos in one place.

8 years agoADD: @donwan581 select keytype for the darkside attack.
iceman1001 [Thu, 4 Aug 2016 19:51:26 +0000 (21:51 +0200)]
ADD:  @donwan581 select keytype for the darkside attack.

8 years agoCHG: cleaning up.
iceman1001 [Thu, 4 Aug 2016 19:37:43 +0000 (21:37 +0200)]
CHG:  cleaning up.

8 years agoFIX: coverity scan 133850, again. Why on earth did the 7 come from. I removed it.
iceman1001 [Wed, 3 Aug 2016 10:09:16 +0000 (12:09 +0200)]
FIX: coverity scan 133850,  again.  Why on earth did the 7 come from. I removed it.

8 years agofix: COVERITYSCAN 133871, fix one part, breaking another. shouldnt have changed...
iceman1001 [Wed, 3 Aug 2016 09:57:40 +0000 (11:57 +0200)]
fix: COVERITYSCAN 133871,  fix one part,  breaking another.  shouldnt have changed to uint8_t since it can never be negative.

8 years agoFIX: coverity scan 133859 structually dead code, looks like this is a rest from...
iceman1001 [Wed, 3 Aug 2016 08:53:26 +0000 (10:53 +0200)]
FIX:  coverity scan 133859 structually dead code,  looks like this is a rest from and old loop. I just removed it.

8 years agoFIX; coverity scan 133850, & operation should keep only topbit of lower nibble.
iceman1001 [Wed, 3 Aug 2016 08:01:37 +0000 (10:01 +0200)]
FIX; coverity scan 133850,  & operation should keep only topbit of lower nibble.
CHG: tabs fixed

8 years agoCoverity Scan 133850, need to ask @jason about this one.
iceman1001 [Wed, 3 Aug 2016 07:32:07 +0000 (09:32 +0200)]
Coverity Scan 133850,   need to ask @jason about this one.

8 years agoMerge branch 'master' of https://github.com/iceman1001/proxmark3
iceman1001 [Wed, 3 Aug 2016 07:30:01 +0000 (09:30 +0200)]
Merge branch 'master' of https://github.com/iceman1001/proxmark3

8 years agoFIX: 133853, If you have 3items in a array, don't start with index 4 or 3, mental...
iceman1001 [Wed, 3 Aug 2016 07:28:54 +0000 (09:28 +0200)]
FIX: 133853,  If you have 3items in a array,  don't start with index 4 or 3,   mental note to self, stop coding when you are tired.

8 years agoMerge pull request #19 from alexgrin/iceman_master
Iceman [Wed, 3 Aug 2016 06:00:22 +0000 (08:00 +0200)]
Merge pull request #19 from alexgrin/iceman_master

Another Coverity fix

8 years agoFIX: CoverityScan 123358 and 133864 - Unchecked return value
Alexis Green [Wed, 3 Aug 2016 05:44:36 +0000 (22:44 -0700)]
FIX: CoverityScan 123358 and 133864 - Unchecked return value

8 years agoFIX: CoverityScan 121362 - Pointer to local outside scope
Alexis Green [Tue, 2 Aug 2016 23:12:44 +0000 (16:12 -0700)]
FIX: CoverityScan 121362 - Pointer to local outside scope

8 years agoFIX: mental note to self, don't code when tried. "size" should have been "sizeof...
iceman1001 [Tue, 2 Aug 2016 22:51:26 +0000 (00:51 +0200)]
FIX: mental note to self, don't code when tried. "size" should have been "sizeof".   I need to fix my build for armsrc again.

8 years agoFIX: forgot a semicolon
iceman1001 [Tue, 2 Aug 2016 22:42:23 +0000 (00:42 +0200)]
FIX:  forgot a semicolon

8 years agoFIX: Coverity scan 1333852, Make sure (card) is not null before accessing it.
iceman1001 [Tue, 2 Aug 2016 22:39:02 +0000 (00:39 +0200)]
FIX: Coverity scan 1333852, Make sure (card) is not null before accessing it.

8 years agoCHG: Some testing of timings on 14443b,
iceman1001 [Tue, 2 Aug 2016 22:35:14 +0000 (00:35 +0200)]
CHG: Some testing of timings on 14443b,
FIX: CoverityScan 133854 , out-of-bounds read,  when calculating crc.

8 years agoFIX: COverityScan 133865, out-of-bounds access, Forgot that bits is not used in...
iceman1001 [Tue, 2 Aug 2016 22:25:53 +0000 (00:25 +0200)]
FIX: COverityScan 133865, out-of-bounds access,   Forgot that bits is not used in Logtrace but bytes.

8 years agoFIX: CoverityScan 133857, cast to uint32_t will stop eventual problems. However...
iceman1001 [Tue, 2 Aug 2016 22:15:26 +0000 (00:15 +0200)]
FIX: CoverityScan 133857, cast to uint32_t will stop eventual problems.  However its a uint_16 so it shouldnt be a problem to start with.

8 years agoFIX. COVERITYscan 133860, initialize to zero. This function is still not working...
iceman1001 [Tue, 2 Aug 2016 22:13:33 +0000 (00:13 +0200)]
FIX. COVERITYscan 133860,  initialize to zero.  This function is still not working but at least now it doesnt crash the client.

8 years agoFIX: CoverityScan, 1333853, out-of-bounds, well, if I have 3 items in a array...
iceman1001 [Tue, 2 Aug 2016 22:10:21 +0000 (00:10 +0200)]
FIX: CoverityScan,  1333853,  out-of-bounds,  well, if I have 3 items in a array, don't start reading 4...

8 years agoMerge pull request #18 from alexgrin/iceman_master
Iceman [Tue, 2 Aug 2016 21:22:51 +0000 (23:22 +0200)]
Merge pull request #18 from alexgrin/iceman_master

A few fixes

8 years agoFIX: LEGIC - potential stack corruption calculating CRC from user input
Alexis Green [Tue, 2 Aug 2016 21:10:33 +0000 (14:10 -0700)]
FIX: LEGIC - potential stack corruption calculating CRC from user input

Impressum, Datenschutz