FIX: Coverity, out-of-bounds read, 124 is less than (0x10*8)+2 (130)

FIX: Coverity, dead-code, bitcomparison always false.   Copy-paste error?  but  0x0F can never be equal 0x10..  I guessing its 0x01. @pwpivi have to correct me if its wrong.

diff --git a/client/cmdhftopaz.c b/client/cmdhftopaz.c
index aab1d248b46710e77d0ab3050497480f6f5067d6..466af7c0faf6d5830af029f46d203df439489fce 100644 (file)
--- a/client/cmdhftopaz.c
+++ b/client/cmdhftopaz.c
@@ -257,7 +257,7 @@ int CmdHFTopazReader(const char *Cmd) {
        uint8_t atqa[2];
        uint8_t rid_response[8];
        uint8_t *uid_echo = &rid_response[2];
-       uint8_t rall_response[124];
+       uint8_t rall_response[130];
        
        status = topaz_select(atqa, rid_response);
        
@@ -286,7 +286,7 @@ int CmdHFTopazReader(const char *Cmd) {
        PrintAndLog("HR0  : %02x (%sa Topaz tag (%scapable of carrying a NDEF message), %s memory map)", rid_response[0], 
                                                (rid_response[0] & 0xF0) == 0x10 ? "" : "not ",
                                                (rid_response[0] & 0xF0) == 0x10 ? "" : "not ",
-                                               (rid_response[0] & 0x0F) == 0x10 ? "static" : "dynamic");
+                                               (rid_response[0] & 0x0F) == 0x01 ? "static" : "dynamic");
        PrintAndLog("HR1  : %02x", rid_response[1]);
        
        status = topaz_rall(uid_echo, rall_response);